diff mbox

[14/51] html: Turn the navbar into a breadcrumb bar

Message ID 1440440620-25937-15-git-send-email-damien.lespiau@intel.com
State Changes Requested
Headers show

Commit Message

Damien Lespiau Aug. 24, 2015, 6:23 p.m. UTC 
From: Belén Barros Peña <belen.barros.pena@intel.com>

So we can have a somewhat of a hierarchical progression:

  All projects -> $project patches -> patch name

That should also help when we add series, we'll be able to just add the
series in there.

By default, we have:

  All projects -> $project patches

both being links, so we can return to the list of patches from any page
where the project is defined. The '$project patches' link becomes
insensitive in the list page. Finally the patch page adds the patch at
the end.

Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Signed-off-by: Belén Barros Peña <belen.barros.pena@intel.com>
---
 patchwork/templates/patchwork/list.html  |  1 +
 patchwork/templates/patchwork/patch.html |  7 ++++++-
 templates/base.html                      | 15 ++++++---------
 3 files changed, 13 insertions(+), 10 deletions(-)

Comments

Stephen Finucane Sept. 9, 2015, 2:47 p.m. UTC | #1 
> From: Belén Barros Peña <belen.barros.pena@intel.com>

> 

> So we can have a somewhat of a hierarchical progression:

> 

>   All projects -> $project patches -> patch name

> 

> That should also help when we add series, we'll be able to just add the

> series in there.

> 

> By default, we have:

> 

>   All projects -> $project patches

> 

> both being links, so we can return to the list of patches from any page

> where the project is defined. The '$project patches' link becomes

> insensitive in the list page. Finally the patch page adds the patch at

> the end.

> 

> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>

> Signed-off-by: Belén Barros Peña <belen.barros.pena@intel.com>


Looks good. One usability suggestion though: could you emphasise the $project name, i.e. '$project'? Single quotes or text decoration (bold, underline, italics) would suffice. Otherwise:

Acked-by: Stephen Finucane <stephen.finucane@intel.com>
Damien Lespiau Sept. 9, 2015, 4:21 p.m. UTC | #2 
On Wed, Sep 09, 2015 at 03:47:08PM +0100, Finucane, Stephen wrote:
> > From: Belén Barros Peña <belen.barros.pena@intel.com>
> > 
> > So we can have a somewhat of a hierarchical progression:
> > 
> >   All projects -> $project patches -> patch name
> > 
> > That should also help when we add series, we'll be able to just add the
> > series in there.
> > 
> > By default, we have:
> > 
> >   All projects -> $project patches
> > 
> > both being links, so we can return to the list of patches from any page
> > where the project is defined. The '$project patches' link becomes
> > insensitive in the list page. Finally the patch page adds the patch at
> > the end.
> > 
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> > Signed-off-by: Belén Barros Peña <belen.barros.pena@intel.com>
> 
> Looks good. One usability suggestion though: could you emphasise the
> $project name, i.e. '$project'? Single quotes or text decoration
> (bold, underline, italics) would suffice. Otherwise:
> 
> Acked-by: Stephen Finucane <stephen.finucane@intel.com>

The title bar can definitely do with (at least) another iteration. Put
that one on my TODO list.
diff mbox

Patch

diff --git a/patchwork/templates/patchwork/list.html b/patchwork/templates/patchwork/list.html
index 654fe8c..f895d28 100644
--- a/patchwork/templates/patchwork/list.html
+++ b/patchwork/templates/patchwork/list.html
@@ -5,6 +5,7 @@ 
 
 {% block title %}{{project.name}}{% endblock %}
 {% block heading %}{{project.name}}{% endblock %}
+{% block breadcrumb %}{{ project.linkname }} patches{% endblock %}
 
 {% block body %}
 
diff --git a/patchwork/templates/patchwork/patch.html b/patchwork/templates/patchwork/patch.html
index f18ee3b..ef257f2 100644
--- a/patchwork/templates/patchwork/patch.html
+++ b/patchwork/templates/patchwork/patch.html
@@ -5,7 +5,12 @@ 
 {% load patch %}
 
 {% block title %}{{patch.name}}{% endblock %}
-{% block heading %}{{patch.name}}{%endblock%}
+{% block breadcrumb %}
+<a href="{% url 'patchwork.views.patch.list' project_id=project.linkname %}"
+ >{{ project.linkname }} patches</a>
+ &#8594;
+ {{ patch.name }}
+{% endblock %}
 
 {% block body %}
 <script language="JavaScript" type="text/javascript">
diff --git a/templates/base.html b/templates/base.html
index 3b2c83e..f770ac9 100644
--- a/templates/base.html
+++ b/templates/base.html
@@ -63,15 +63,12 @@ 
 {% if project %}
   <div id="nav">
    <div id="navleft">
-    <strong>Project</strong>: {{ project.linkname }}
-     :
-     <a href="{% url 'patchwork.views.patch.list' project_id=project.linkname %}"
-      >patches</a>
-    {% if other_projects %}
-     :
-     <a href="{% url 'patchwork.views.projects' %}"
-     >other projects</a>
-    {% endif %}
+     <a href="{% url 'patchwork.views.projects' %}">All projects</a>
+     &#8594;
+     {% block breadcrumb %}
+      <a href="{% url 'patchwork.views.patch.list' project_id=project.linkname %}"
+       >{{ project.linkname }} patches</a>
+     {% endblock %}
    </div>
    <div style="clear: both"></div>
   </div>