From patchwork Sun Jan 15 19:49:24 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 136420 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (localhost [IPv6:::1]) by ozlabs.org (Postfix) with ESMTP id 37F921007F2 for ; Tue, 17 Jan 2012 18:27:14 +1100 (EST) Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e06smtp11.uk.ibm.com", Issuer "GeoTrust SSL CA" (not verified)) by ozlabs.org (Postfix) with ESMTPS id C7078B6F13 for ; Mon, 16 Jan 2012 06:49:34 +1100 (EST) Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 15 Jan 2012 19:49:28 -0000 Received: from d06nrmr1407.portsmouth.uk.ibm.com ([9.149.38.185]) by e06smtp11.uk.ibm.com ([192.168.101.141]) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Sun, 15 Jan 2012 19:49:27 -0000 Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by d06nrmr1407.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q0FJnQ1k2351248 for ; Sun, 15 Jan 2012 19:49:26 GMT Received: from d06av04.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q0FJnQSL011563 for ; Sun, 15 Jan 2012 12:49:26 -0700 Received: from localhost (sig-9-79-13-199.uk.ibm.com [9.79.13.199]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q0FJnPVs011558; Sun, 15 Jan 2012 12:49:26 -0700 From: Stefan Hajnoczi To: patchwork@lists.ozlabs.org Subject: [PATCH] notifications: do not HTML-escape patch change notifications Date: Sun, 15 Jan 2012 19:49:24 +0000 Message-Id: <1326656964-24361-1-git-send-email-stefanha@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.8.3 x-cbid: 12011519-5024-0000-0000-0000016123B1 X-Mailman-Approved-At: Tue, 17 Jan 2012 18:27:13 +1100 Cc: Stefan Hajnoczi X-BeenThere: patchwork@lists.ozlabs.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Patchwork development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Patch change notifications are text/plain emails and should not HTML-escape patch names. This means quotes and ampersands in patch names should not be turned into " and & HTML entities. Signed-off-by: Stefan Hajnoczi --- I spotted the following in the patch change notification I received: ''' The following patch (submitted by you) has been updated in patchwork: * parser: allow words starting with "diff" at beginning of line - http://patchwork.ozlabs.org/patch/136093/ ''' Notice that "diff" is "diff" because of Django's automatic HTML escaping. I'm sending this patch to fix that - but I have not tested this patch! templates/patchwork/patch-change-notification.mail | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/templates/patchwork/patch-change-notification.mail b/templates/patchwork/patch-change-notification.mail index d86a6af..19a2a09 100644 --- a/templates/patchwork/patch-change-notification.mail +++ b/templates/patchwork/patch-change-notification.mail @@ -2,7 +2,7 @@ Hello, The following patch{{notifications|length|pluralize:"es"}} (submitted by you) {{notifications|length|pluralize:"has,have"}} been updated in patchwork: {% for notification in notifications %} - * {{notification.patch.name}} + * {{notification.patch.name|safe}} - http://{{site.domain}}{{notification.patch.get_absolute_url}} was: {{notification.orig_state}} now: {{notification.patch.state}}