Message ID | 20181006214506.22720-1-stephen@that.guru |
---|---|
Headers | show |
Series | Add dbbackup, dbrestore commands | expand |
Series looks good to me. I haven't taken a deep enough look to feel comfortable Reviewed-by-ing it, but it looks sufficiently simple and straight-forward that I wouldn't object to it being merged. Regards, Daniel Stephen Finucane <stephen@that.guru> writes: > This is a big help when developing and makes tinkering with the DB a far > less daunting ordeal. > > Stephen Finucane (4): > docs: Hardcode username, password > doc: Cleanup development installation guide > Add support for 'django-dbbackup' > Remove django-debug-toolbar from test requirements > > .gitignore | 3 + > docs/development/installation.rst | 138 +++++++++++++++--------------- > patchwork/settings/dev.py | 41 ++++++--- > requirements-dev.txt | 2 + > requirements-test.txt | 1 - > 5 files changed, 104 insertions(+), 81 deletions(-) > > -- > 2.17.1 > > _______________________________________________ > Patchwork mailing list > Patchwork@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/patchwork
On Wed, 2018-10-10 at 15:35 +1100, Daniel Axtens wrote: > Series looks good to me. I haven't taken a deep enough look to > feel comfortable Reviewed-by-ing it, but it looks sufficiently simple > and straight-forward that I wouldn't object to it being merged. > > Regards, > Daniel Fair. I've gone ahead and applied this as it's helpful while working on the Submission de-normalization work. Thanks! Stephen
On Wed, 2018-10-10 at 09:16 +0100, Stephen Finucane wrote: > On Wed, 2018-10-10 at 15:35 +1100, Daniel Axtens wrote: > > Series looks good to me. I haven't taken a deep enough look to > > feel comfortable Reviewed-by-ing it, but it looks sufficiently simple > > and straight-forward that I wouldn't object to it being merged. > > > > Regards, > > Daniel > > Fair. I've gone ahead and applied this as it's helpful while working on > the Submission de-normalization work. Thanks! > > Stephen I have dropped the first patch in the series though as it no longer applies, given the other doc patch. Stephen