mbox series

[0/6] Convert Series-Patch relationship to 1:N

Message ID 20180906211406.14363-1-stephen@that.guru
Headers show
Series Convert Series-Patch relationship to 1:N | expand

Message

Stephen Finucane Sept. 6, 2018, 9:14 p.m. UTC 
This is mostly a tech debt reduction exercise. As noted in the main
patch, the M:N relationship between series and patches was, in
hindsight, a design decision made for the wrong reasons. It's one of the
things holding us back on the improved tagging series and it makes a lot
of things more difficult to do than they should be. Time to fix it, IMO.

Stephen Finucane (6):
  tests: Add more tests for series-ified mbox views
  tests: Hardcode expected values
  models: Convert Series-Patch relationship to 1:N
  models: Remove 'SeriesMixin'
  tests: Remove 'create_series_patch'
  views: Add support for boolean 'series' parameters

 patchwork/admin.py                            |  2 +-
 patchwork/api/cover.py                        | 19 +++--
 patchwork/api/patch.py                        | 20 +++--
 .../0027_add_patch_series_fields.py           | 32 +++++++
 ...migrate_data_from_series_patch_to_patch.py | 35 ++++++++
 .../0029_remove_patch_series_model.py         | 58 +++++++++++++
 patchwork/models.py                           | 83 +++++--------------
 patchwork/parser.py                           |  6 +-
 patchwork/signals.py                          | 40 ++++-----
 .../templates/patchwork/download_buttons.html | 15 +---
 patchwork/templates/patchwork/patch-list.html | 12 ++-
 patchwork/templates/patchwork/submission.html | 24 ++----
 patchwork/tests/api/test_series.py            | 12 ++-
 patchwork/tests/test_detail.py                | 16 ----
 patchwork/tests/test_events.py                | 39 +++++----
 patchwork/tests/test_mboxviews.py             | 69 +++++++++++++--
 patchwork/tests/test_series.py                | 38 +++++----
 patchwork/tests/utils.py                      | 45 ++++++----
 patchwork/views/patch.py                      |  4 +-
 patchwork/views/utils.py                      | 17 ++--
 20 files changed, 362 insertions(+), 224 deletions(-)
 create mode 100644 patchwork/migrations/0027_add_patch_series_fields.py
 create mode 100644 patchwork/migrations/0028_migrate_data_from_series_patch_to_patch.py
 create mode 100644 patchwork/migrations/0029_remove_patch_series_model.py

Comments

Daniel Axtens Sept. 10, 2018, 1:24 p.m. UTC | #1 
Stephen Finucane <stephen@that.guru> writes:

> This is mostly a tech debt reduction exercise. As noted in the main
> patch, the M:N relationship between series and patches was, in
> hindsight, a design decision made for the wrong reasons. It's one of the
> things holding us back on the improved tagging series and it makes a lot
> of things more difficult to do than they should be. Time to fix it, IMO.

I was going to propose this too! Great minds or something :)

I will review them as I get a chance.

Regards,
Daniel

>
> Stephen Finucane (6):
>   tests: Add more tests for series-ified mbox views
>   tests: Hardcode expected values
>   models: Convert Series-Patch relationship to 1:N
>   models: Remove 'SeriesMixin'
>   tests: Remove 'create_series_patch'
>   views: Add support for boolean 'series' parameters
>
>  patchwork/admin.py                            |  2 +-
>  patchwork/api/cover.py                        | 19 +++--
>  patchwork/api/patch.py                        | 20 +++--
>  .../0027_add_patch_series_fields.py           | 32 +++++++
>  ...migrate_data_from_series_patch_to_patch.py | 35 ++++++++
>  .../0029_remove_patch_series_model.py         | 58 +++++++++++++
>  patchwork/models.py                           | 83 +++++--------------
>  patchwork/parser.py                           |  6 +-
>  patchwork/signals.py                          | 40 ++++-----
>  .../templates/patchwork/download_buttons.html | 15 +---
>  patchwork/templates/patchwork/patch-list.html | 12 ++-
>  patchwork/templates/patchwork/submission.html | 24 ++----
>  patchwork/tests/api/test_series.py            | 12 ++-
>  patchwork/tests/test_detail.py                | 16 ----
>  patchwork/tests/test_events.py                | 39 +++++----
>  patchwork/tests/test_mboxviews.py             | 69 +++++++++++++--
>  patchwork/tests/test_series.py                | 38 +++++----
>  patchwork/tests/utils.py                      | 45 ++++++----
>  patchwork/views/patch.py                      |  4 +-
>  patchwork/views/utils.py                      | 17 ++--
>  20 files changed, 362 insertions(+), 224 deletions(-)
>  create mode 100644 patchwork/migrations/0027_add_patch_series_fields.py
>  create mode 100644 patchwork/migrations/0028_migrate_data_from_series_patch_to_patch.py
>  create mode 100644 patchwork/migrations/0029_remove_patch_series_model.py
>
> -- 
> 2.17.1
>
> _______________________________________________
> Patchwork mailing list
> Patchwork@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/patchwork