| Message ID | bde71207d3d067cf520887d2981d6702a68a493f.camel@canonical.com |
|---|---|
| State | Accepted |
| Delegated to: | Dumitru Ceara |
| Headers | show |
| Series | [ovs-dev] ovn-ctl man: Add election timer config to manpage | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | fail | apply and check: fail |
On 10/31/23 14:49, martin.kalcok@canonical.com wrote: > > Raft election timers for NB and SB DB clusters are configurable via > ovn-ctl but the options are not mention on the man page. > > Signed-off-by: Martin Kalcok <martin.kalcok@canonical.com> > --- > utilities/ovn-ctl.8.xml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/utilities/ovn-ctl.8.xml b/utilities/ovn-ctl.8.xml > index 82804096f..01f4aa26b 100644 > --- a/utilities/ovn-ctl.8.xml > +++ b/utilities/ovn-ctl.8.xml > @@ -136,12 +136,14 @@ > <p><code>--db-nb-cluster-remote-addr=<var>IP ADDRESS</var></code></p> > <p><code>--db-nb-cluster-remote-port=<var>PORT NUMBER</var></code></p> > <p><code>--db-nb-cluster-remote-proto=<var>PROTO (tcp/ssl)</var></code></p> > + <p><code>--db-nb-election-timer=<var>Timeout in milliseconds</var></code></p> > <p><code>--db-sb-cluster-local-addr=<var>IP ADDRESS</var></code></p> > <p><code>--db-sb-cluster-local-port=<var>PORT NUMBER</var></code></p> > <p><code>--db-sb-cluster-local-proto=<var>PROTO (tcp/ssl)</var></code></p> > <p><code>--db-sb-cluster-remote-addr=<var>IP ADDRESS</var></code></p> > <p><code>--db-sb-cluster-remote-port=<var>PORT NUMBER</var></code></p> > <p><code>--db-sb-cluster-remote-proto=<var>PROTO (tcp/ssl)</var></code></p> > + <p><code>--db-sb-election-timer=<var>Timeout in milliseconds</var></code></p> > <p><code>--db-ic-nb-cluster-local-addr=<var>IP ADDRESS</var></code></p> > <p><code>--db-ic-nb-cluster-local-port=<var>PORT NUMBER</var></code></p> > <p><code>--db-ic-nb-cluster-local-proto=<var>PROTO (tcp/ssl)</var></code></p> Hi Martin, As the 0-day Robot mentioned, this patch is malformed. Given that it's not that large, I patched it manually. For future contributions please use git format-patch + git send-email: https://github.com/ovn-org/ovn/blob/3bf67405faed9fc5c2d07024b0775e0d363651a6/Documentation/internals/contributing/submitting-patches.rst?plain=1#L90 I applied this to main and backported it to all stable branches. I also added you to the list of authors. Thanks, Dumitru
diff --git a/utilities/ovn-ctl.8.xml b/utilities/ovn-ctl.8.xml index 82804096f..01f4aa26b 100644 --- a/utilities/ovn-ctl.8.xml +++ b/utilities/ovn-ctl.8.xml @@ -136,12 +136,14 @@ <p><code>--db-nb-cluster-remote-addr=<var>IP ADDRESS</var></code></p> <p><code>--db-nb-cluster-remote-port=<var>PORT NUMBER</var></code></p> <p><code>--db-nb-cluster-remote-proto=<var>PROTO (tcp/ssl)</var></code></p> + <p><code>--db-nb-election-timer=<var>Timeout in milliseconds</var></code></p> <p><code>--db-sb-cluster-local-addr=<var>IP ADDRESS</var></code></p> <p><code>--db-sb-cluster-local-port=<var>PORT NUMBER</var></code></p> <p><code>--db-sb-cluster-local-proto=<var>PROTO (tcp/ssl)</var></code></p> <p><code>--db-sb-cluster-remote-addr=<var>IP ADDRESS</var></code></p> <p><code>--db-sb-cluster-remote-port=<var>PORT NUMBER</var></code></p> <p><code>--db-sb-cluster-remote-proto=<var>PROTO (tcp/ssl)</var></code></p> + <p><code>--db-sb-election-timer=<var>Timeout in milliseconds</var></code></p> <p><code>--db-ic-nb-cluster-local-addr=<var>IP ADDRESS</var></code></p> <p><code>--db-ic-nb-cluster-local-port=<var>PORT NUMBER</var></code></p> <p><code>--db-ic-nb-cluster-local-proto=<var>PROTO (tcp/ssl)</var></code></p>
Raft election timers for NB and SB DB clusters are configurable via ovn-ctl but the options are not mention on the man page. Signed-off-by: Martin Kalcok <martin.kalcok@canonical.com> --- utilities/ovn-ctl.8.xml | 2 ++ 1 file changed, 2 insertions(+)