From patchwork Wed Jan 17 11:11:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Bianconi X-Patchwork-Id: 1887368 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bktfeRIw; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TFNW86xxmz1yPg for ; Wed, 17 Jan 2024 22:12:04 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 7249E83B66; Wed, 17 Jan 2024 11:12:02 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 7249E83B66 Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bktfeRIw X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T5HlAkcrenFR; Wed, 17 Jan 2024 11:12:01 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id 848E682451; Wed, 17 Jan 2024 11:12:00 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 848E682451 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4C72DC008E; Wed, 17 Jan 2024 11:12:00 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 439E6C0072 for ; Wed, 17 Jan 2024 11:11:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 1793741E62 for ; Wed, 17 Jan 2024 11:11:59 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1793741E62 Authentication-Results: smtp4.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bktfeRIw X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NGOxgaqrrlHr for ; Wed, 17 Jan 2024 11:11:58 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id 6688341E60 for ; Wed, 17 Jan 2024 11:11:58 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 6688341E60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705489917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=csQ8MOhG5n8SwTtM1vGanGXlYA6q6EQ0zY1wUgR3De0=; b=bktfeRIwVlo9n+ndV36s9DIlyyrDKfNe7vK1klIe7ShtP5ps3YBceEbktA0JJeq6BEBE+s bVLOY+TBKQJ3KtAhlIsjO4pKKxBMltcqePsQJJb5sD07bGEOGDzN+FWvngjpEZEoQTkYM8 DYAsxFyX9lZkIgcwrZ8nnpe0QOt+5xY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590-mRz13CBaNtiM-nI4F9j72g-1; Wed, 17 Jan 2024 06:11:55 -0500 X-MC-Unique: mRz13CBaNtiM-nI4F9j72g-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-40e4576b7e6so77263915e9.0 for ; Wed, 17 Jan 2024 03:11:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705489914; x=1706094714; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=csQ8MOhG5n8SwTtM1vGanGXlYA6q6EQ0zY1wUgR3De0=; b=a93rt9GixyY8vc8I+ZYsbbXvFchT2y+wJPGxHgjqezLWrNLVTHMjqjaYFhhGcVB/WG 0HYlJf2BHnH/28FxhAgJG279Z8gl9v5HyCDtkdDb3qa5vuf6bbrfCHZECJb+Vq4HJcd6 aEtUQaeB+78LUtOH9IjH4/ocRM3AJp0K1+hKUwq6bMdlUlaby0+5PPM1reiLmYo2GTx+ HSAojhT5w/gVt5iwO9v1/q1VEh/32IQm20DfdfVaztfI0R1Ep5b0r0XgAapgbf+FFYdu SGNxUmdmZAzTvZw5iB3FyMl/mWnNER7Cip+6GV6BeFE5Ehu5VXha1qeEosq1LZpztTJ2 XQmg== X-Gm-Message-State: AOJu0Yyg4WBIztvydA6xASknZWtwqAIjP0jd/VNOxQxBCQ6ro/mjjyA7 WNEbNUQQLEj28BTKEmrpOTR4U+4fmmJ/3HFw7PBD/YWUexeojBaB2w7KcdCCXC8t/Cj3cdQKSPZ HtJkQVGxuh2KQqdRIIW4as80iH2RF+GthRsiVX/tQ+sZRMqkEEx4ijgXpCbCzj0c60/rkaXMD6Q D+ekURHoVc1Cw7jCNhn+VL X-Received: by 2002:a05:600c:5101:b0:40e:76b5:1973 with SMTP id o1-20020a05600c510100b0040e76b51973mr1773434wms.48.1705489914566; Wed, 17 Jan 2024 03:11:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IEmfOdoauXpipSoqZRxY7tLwohSDB5Sy9lYfD8/4vqd77YJLBdnAekjOw/oQIoTj8I37QRJnQ== X-Received: by 2002:a05:600c:5101:b0:40e:76b5:1973 with SMTP id o1-20020a05600c510100b0040e76b51973mr1773429wms.48.1705489914258; Wed, 17 Jan 2024 03:11:54 -0800 (PST) Received: from localhost (net-93-71-3-198.cust.vodafonedsl.it. [93.71.3.198]) by smtp.gmail.com with ESMTPSA id hn33-20020a05600ca3a100b0040e621feca9sm20441712wmb.17.2024.01.17.03.11.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jan 2024 03:11:54 -0800 (PST) From: Lorenzo Bianconi To: ovs-dev@openvswitch.org Date: Wed, 17 Jan 2024 12:11:42 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: dceara@redhat.com Subject: [ovs-dev] [PATCH ovn 2/3] ovn-nbctl: fix nbctl_pre_lr_route_add for BFD X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" In order to properly check if we already have a running BFD session for the next hop used by the brand new route, load logical port column of the nb BFD table in nbctl_pre_lr_route_add routine. Fixes: db6d30783bec ("ovn-nbctl: Don't replicate entire database unnecessarily.") Signed-off-by: Lorenzo Bianconi Acked-by: Mark Michelson --- utilities/ovn-nbctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c index 526369b68..0586eccdb 100644 --- a/utilities/ovn-nbctl.c +++ b/utilities/ovn-nbctl.c @@ -4394,6 +4394,7 @@ nbctl_pre_lr_route_add(struct ctl_context *ctx) ovsdb_idl_add_column(ctx->idl, &nbrec_logical_router_port_col_name); ovsdb_idl_add_column(ctx->idl, &nbrec_bfd_col_dst_ip); + ovsdb_idl_add_column(ctx->idl, &nbrec_bfd_col_logical_port); ovsdb_idl_add_column(ctx->idl, &nbrec_logical_router_static_route_col_ip_prefix);