From patchwork Thu Jul 11 03:41:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Qiang Qiang45 Zhang X-Patchwork-Id: 1959087 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=lenovo.com header.i=@lenovo.com header.a=rsa-sha256 header.s=DKIM202306 header.b=wIgEVvbj; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WKLBP0LM5z1xqr for ; Thu, 11 Jul 2024 13:41:47 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id ECF0B416A9; Thu, 11 Jul 2024 03:41:44 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id aRFhyJl2i9-i; Thu, 11 Jul 2024 03:41:43 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.9.56; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 2C06F4148B Authentication-Results: smtp4.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=lenovo.com header.i=@lenovo.com header.a=rsa-sha256 header.s=DKIM202306 header.b=wIgEVvbj Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 2C06F4148B; Thu, 11 Jul 2024 03:41:43 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id CA4F7C0A97; Thu, 11 Jul 2024 03:41:42 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1AA91C0A96 for ; Thu, 11 Jul 2024 03:41:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 068146107D for ; Thu, 11 Jul 2024 03:41:42 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id s4QY-0xIr1-f for ; Thu, 11 Jul 2024 03:41:40 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=148.163.152.46; helo=mx0b-00823401.pphosted.com; envelope-from=zhangqiang45@lenovo.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org E877F6107A Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=reject dis=none) header.from=lenovo.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org E877F6107A Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=lenovo.com header.i=@lenovo.com header.a=rsa-sha256 header.s=DKIM202306 header.b=wIgEVvbj Received: from mx0b-00823401.pphosted.com (mx0b-00823401.pphosted.com [148.163.152.46]) by smtp3.osuosl.org (Postfix) with ESMTPS id E877F6107A for ; Thu, 11 Jul 2024 03:41:39 +0000 (UTC) Received: from pps.filterd (m0355092.ppops.net [127.0.0.1]) by mx0b-00823401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46B3N3UH017385; Thu, 11 Jul 2024 03:41:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lenovo.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=DKIM202306; bh=vpE0ogjF3qbg5Ti0lF1XN44 Wv3UFC/FPCDCem2FCu/I=; b=wIgEVvbjCjjU6iBwA1NwIz1aNEPJtkbPpKx9wmM REtOplPbzuz+jCw8uR/8Lj8g/ayjc/Aik8w1Xuj3HHOlXmmJaa9eEGs8j0vjRiT4 t1UNXyzFzMB8ezIR1GlengNMCENui79amMlT2GXJgkFOBZwj0JTn1JPB2XcZJbwz BLTih4N8/TFPMDi3oSObE0TDsNoVgh9A0dnBkljxa3L11yB7OzWUHm4eyFcoxBx6 vpaF+/PLKzVrfckKz2IASPpzXZtTyeFsYCtruCH3RzW5DdFR79VCNuTogQ8C2Kui q+nKFDi8NCg52j2eIFzjHyqmW8Zcp4tI2XQkCJkV7qpZswQ== Received: from sinpr02cu002.outbound.protection.outlook.com (mail-southeastasiaazlp17012055.outbound.protection.outlook.com [40.93.129.55]) by mx0b-00823401.pphosted.com (PPS) with ESMTPS id 407m8fjtqk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Jul 2024 03:41:38 +0000 (GMT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fE+C6R1keYz5kSX4119MRpPr2pbAV1BH7zFo0QrnfgwujjuDDCVycQkhXoLdkazVUfepl+IKU8WWfLHU2ezFzwB/BOIdSlTA3ham/AXY0UVoK7xjD2eD+kDQ2Uc6N3O5eINKQQcQJsytPaeeKraLKWhaQ2NGOg5SdJ4V7i/DzZWxp2C48FM4OX/UyzD5yjN6pAN1dCHOOQwtt2VDSsHXhLKGoFPYTnD+OsT18R3NquCV+H6yaRgPNSlut2vLhURAmMFdSC2QoDgzFT8vTFKOi2SaSy9JWAcmlCPK7QDy1ns3vTxM07P7Ag3o6lC12q/Rf+pTHpJjVGWNtiDu4SAVCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vpE0ogjF3qbg5Ti0lF1XN44Wv3UFC/FPCDCem2FCu/I=; b=xJUcNqHFGQe5hlSHvC2y/OSajKqUMTHWtKJXrFVRd+6u3znGH2cHu/45iaJojf+bGgiXd4mUd+dGAXE8DZLj+xdp+klDYkJ3qRYzpdTMJWQjRIRRzju+DeEluhsminPrfGXTa91AAQSfaBSgKMA1nK2Dp5APjYBpDLApgFwZaL1pFACug2TeoF+/q9qyacj9OE8kZ3PMbhKznxWWXSnkCPLxIhjsyVjxk1ITnCXEXaMohFNSIPUFMQlWmDmVcMZBTcqyybYLAwgfXVPm9Lm/OcNM74dRmH5ymagNZYgmLC1p9g+JNdss6J74JohgzbwbbSBqWkzNbQj2bIol14dTuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=lenovo.com; dmarc=pass action=none header.from=lenovo.com; dkim=pass header.d=lenovo.com; arc=none Received: from SEZPR03MB7402.apcprd03.prod.outlook.com (2603:1096:101:12e::8) by SEYPR03MB8389.apcprd03.prod.outlook.com (2603:1096:101:20d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.35; Thu, 11 Jul 2024 03:41:34 +0000 Received: from SEZPR03MB7402.apcprd03.prod.outlook.com ([fe80::ef3e:3dcf:f408:780e]) by SEZPR03MB7402.apcprd03.prod.outlook.com ([fe80::ef3e:3dcf:f408:780e%4]) with mapi id 15.20.7762.020; Thu, 11 Jul 2024 03:41:34 +0000 To: Ales Musil CC: "dev@openvswitch.org" Thread-Topic: [External] Re: [ovs-dev] [PATCH ovn] northd: Fix issues for Forwarding_Group Thread-Index: AdrRCeNELPyUOyh9T5CUi72uzO0seQBjS1AAACtIRoA= Date: Thu, 11 Jul 2024 03:41:34 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SEZPR03MB7402:EE_|SEYPR03MB8389:EE_ x-ms-office365-filtering-correlation-id: 8e87a2e2-7248-4d1f-c4f7-08dca15b5c62 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|69100299015|1800799024|38070700018; x-microsoft-antispam-message-info: =?utf-8?q?JPstzf/pVg7Ix5lfygy5Fesq3SvkJW9?= =?utf-8?q?U0KoeRjQ6EK+Fc/OiuLQW6Kk5cYJknkYPxkAi0snhZ33y7l8jHkHiOfumbH2Y73b7?= =?utf-8?q?td+rLm1QUu5IlSqmQiwWvZZz7MI2whRDw7SMIn6EV3jIZLMphVXCU3TyHyNi/Pu+4?= =?utf-8?q?l3IXsWQGjE3iYV870AwLt4Ry+GPkVFGxBu/D8ED1UteNkrl5mJyxQHTO1/FQ1k+Xz?= =?utf-8?q?hbyghmdM4nOHKoR7vnKxUiEZI5qOPnEgDlhrSRayU6HbuEC0sEVdo2+K2zStpRokW?= =?utf-8?q?dj+ncfzLm+7ZyFfXlwZJZfoQoNH4du6Ykz0Kz+1qq/qnSyYJuBpMQmJAkmLkdkzKt?= =?utf-8?q?teTKsjnIBdSVv3sBcfo5McTq3b3P4jABAntMAn9Gps2izgGXxLtpQciBP2fz67+6C?= =?utf-8?q?Q5NgB6Czu1M+6jukPgs6CaYQpziiAWRRJhzpcBiCH2qft6L6VQtUXpfkEWi7n3Qx2?= =?utf-8?q?ICU6yCOvsIs+CmjNQvj3OUVyJLV+vTJPn35lea6mE9YMo/fGkVKS0HOJeLk1OWfYO?= =?utf-8?q?khjB2D42OhTxWHUj/4IgnkqA4BNLOeVZWBD3Zk7ivt+NQRQtt/HM6+B6Z2cVVkq3M?= =?utf-8?q?ch4G5hWZoVdSluNxrrN1crns40mJAyssmOIkYl4HNth4pb1L90eGqCkcCG4nUbzuY?= =?utf-8?q?lcEMlaCMJgckLs3S7n2UMytY8DVcXIwwE2wLZlLs6bSNSA+vNMdHl/UQ58jBH90Q+?= =?utf-8?q?yEJbMwqoSt5cWu+hZ+a89YN68VuVHhIh8V83ZE57o71EGuX9V/LXNL7ARza4cJlhL?= =?utf-8?q?iOZ0UAQMEioCQVsalVuWc182dyMsjV7AhF5rd8+tHObhDSpAMPbxW9GiPMDVsv0J0?= =?utf-8?q?GSkqt4Hmwhtjb4Ee+h2ZA8DvkuGQgY2wAdSi6TSkanTkrK+PGo5FAhrvcvj/gQIgN?= =?utf-8?q?osu+7P9mZZ9SRf39L5KAl2N64z5P+33lUO3iVdACPOWYVxS9NY2CEwrHnKvLEEHi0?= =?utf-8?q?oxj/hy1CSr4Ao35yyzMVDptl/xZdepoxdinzFg4skh+4ggZKrpcvLOYj658nItKRw?= =?utf-8?q?6aoqsd5KfE9xRR7tASUtdT84X5axmdEnBuwLIGEmR4DaFWXhPJn6iMUvnwKWMkGN1?= =?utf-8?q?8r4Ie0K6d1QcIU4VpnEb5Neoc7ZG92Nc3l8vZefc/2JkVlSYTbyb5rh/RKtqvR/uN?= =?utf-8?q?EWqdcJa7Sw3pYIdsKqeN6Zkhwibg3tZHXzN7qeIPRfJQfFG238/lhySqpKfOBwhWS?= =?utf-8?q?eL2jWXyXE9CtDL1jRpqw33iQ5hqexrzLUdtMitZMule1Qg/vrQBJsB29MUnNSEc7w?= =?utf-8?q?rtPovjJXsZSDyS/VIReHRxELCvG/H1pOJIowAOe44MH28NpjI42XMSNo=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:zh-cn; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR03MB7402.apcprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(69100299015)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?vUrhoVDYxtoRjDYK3LrAfArMMbOb?= =?utf-8?q?S55gSYu48lzpKwlTgEyHtejphLhDOfzDIDTp0BfOY50CmWSLAx/4N3AizEr0Tl/Hr?= =?utf-8?q?55v/pVUQUSQ9eBu+h01pT0XVaU15f0BXF3KlghGOhV0Tz+IkYvSZhePtf8hDxKtIS?= =?utf-8?q?NxHw1wI4lEjIUNsR8xsNJ1I6lQLioyW01kKPFjyPBDWvZRUd9U3s2MJOboCLUOuOy?= =?utf-8?q?jzjYya+DEc4kd+vg7Atjwxgtjvf8+rJR2EBfraP4WDdWEKs4tSmoywWsfTKXYImd5?= =?utf-8?q?lDn07VRc99AQcqcaMozvX1S4zMrN3T2Azvd5D5PwcwFRuu0VnedX0pl7i5MzUE1NX?= =?utf-8?q?4XfMzT+W/XALJQPcr5DO0MT0FHDUQFfOao4IQmaA4ftv3GihpQa26xEveLKWYhN9e?= =?utf-8?q?WxuzPmfv+ZSrheEckfcLAEq2R/+8bvpN7MzwYyswKNwS6PH+9kwyb0ev9b5bnLfOW?= =?utf-8?q?KYOxQAbnes2vde8VZ1pn2Wmi24Z7e4t6K7J2HZEcLgXJ6zmNUyZonPkB1cDXxnxRv?= =?utf-8?q?ffjhIpFEtcxwSIdc2j/ehl2x3RoVH1ikPNGqG/6GH43tqXkzznLFB/7C+Fav2Qkqm?= =?utf-8?q?mFERmvgKUWeqFe+KMn9qF6aeYgq/oJsm3A4GC9c8dohUxnEOG4aoK6uz0JD9qWq2M?= =?utf-8?q?HBU448gNOetTZZiBVFDZU60/yWtV4G8QSbCWEgPWh4ymZtNNq4y0IuPwn4aTbfZDh?= =?utf-8?q?BrXsqY922zvDBmVwFEXyJ2J1jIibe5JmhpMklJYMxn//T6abH8vdVsUESTpGlQHSZ?= =?utf-8?q?MOd8kBTEtgCGyPozovkr05uRczmZurbUju25kNN6DWynfzF65M6I8t2bHOope5VUu?= =?utf-8?q?P6hKs5Rng3lT4fmNAbejeD5r4TVXVl6rmTdJKBW/gBI79PwjVjyKnhs5KJQqtqD/h?= =?utf-8?q?tTXM1H0jdugrVC1RuhIwrP8J4hpdGm4dfa+1IvRyvVSoyEUTA3bmlkZ1Y6GmFldkf?= =?utf-8?q?oCx7Fgtn1LfqSbzejvLM4J3MQHt3TvPkp+1+rb/IHSx4JLW458gsTqdX2opbjHvFQ?= =?utf-8?q?fyst8F1oRT36uSo+6JErvDB7UZc7oLMj1SuE6K3Zt/rXOEJGOOnPsFq4GEIK08Ix8?= =?utf-8?q?X7HAHZgjXcM37joEOTNcGCj/vpMFBlYSQOQUzMxhSJPHSa7Agp2U36QQsccjswaGL?= =?utf-8?q?mVEPJr2ElyvrvgJBYDjLlFMFxmaqFJMVIk0xXZMpylyoZbK1HJNwqTboxWMrUT50b?= =?utf-8?q?HYxikJ1OJhiW+9/xtKZ90jOyYBNUZH5c7lwm2kbVlNdFnUbbW9NODRMYkwFQmSFYZ?= =?utf-8?q?n3Y0s5kbcjzToLXja1rmeQyQEEKl4wE/H6ILS3nmekPRIasweY2dSsgFzqT4KRPHt?= =?utf-8?q?m3I+e1AZ2jIdm7DHSZJN2H+qsb5rsgvqTTwhvXhjk0W14qIlkac+C2vlwsuXNwMxx?= =?utf-8?q?xMg01Hc/XnC+O2IyYzb/TN/DGErRt5wIHfPOmMyr7CKR3eYC6Dm17gkWRQyAB3FGB?= =?utf-8?q?lyk2ZFta3u1DXmZJo1fk5CN9FnBtpuhBBpkDFuAxzUQaRAAPEWulff4UCpUVyQEb2?= =?utf-8?q?tVIdA6KUNOQW?= MIME-Version: 1.0 X-OriginatorOrg: lenovo.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SEZPR03MB7402.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e87a2e2-7248-4d1f-c4f7-08dca15b5c62 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jul 2024 03:41:34.3352 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5c7d0b28-bdf8-410c-aa93-4df372b16203 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ikDuQEziJ4WwRDa0VGbVKayw7vyC6tTE86G9IIYUa00m0NIUb145w1dtzHcNdbTdQ3qhBotnAxU+Thc1rirDfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR03MB8389 X-Proofpoint-GUID: 9TTElL5H96FOg-5cNarsYRR5HBUOkolK X-Proofpoint-ORIG-GUID: 9TTElL5H96FOg-5cNarsYRR5HBUOkolK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-10_20,2024-07-10_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 phishscore=0 mlxlogscore=999 suspectscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 impostorscore=0 priorityscore=1501 mlxscore=0 adultscore=0 classifier=spam adjust=-20 reason=mlx scancount=1 engine=8.19.0-2406140001 definitions=main-2407110023 X-Content-Filtered-By: Mailman/MimeDel 2.1.30 Subject: [ovs-dev] =?utf-8?b?5Zue5aSNOiBbRXh0ZXJuYWxdIFJlOiAgW1BBVENIIG92?= =?utf-8?b?bl0gbm9ydGhkOiBGaXggaXNzdWVzIGZvciBGb3J3YXJkaW5nX0dyb3Vw?= X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Qiang Qiang45 Zhang via dev From: Qiang Qiang45 Zhang Reply-To: Qiang Qiang45 Zhang Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Test cases have been added. 发件人: Ales Musil 发送时间: 2024年7月10日 15:02 收件人: Qiang Qiang45 Zhang 抄送: dev@openvswitch.org 主题: [External] Re: [ovs-dev] [PATCH ovn] northd: Fix issues for Forwarding_Group On Mon, Jul 8, 2024 at 5:01 PM Qiang Qiang45 Zhang via dev > wrote: When a logical switch has 2 FWGs and each FWG has 3 ports, Logical-Flow only has one fwg_group() action. Submitted-at: northd: Fix issues for Forwarding_Group by ZhangQiang3 * Pull Request #250 * ovn-org/ovn (github.com) From 02186da234426bc361615eb6b5142c76f296202f Mon Sep 17 00:00:00 2001 From: zhangqiang45 zhangqiang45@lenovo.com> Date: Mon, 8 Jul 2024 14:25:04 +0800 Subject: [PATCH ovn] northd: Fix issues for Forwarding_Group The use of variables from the outer loop in the inner loop causes the outer loop to terminate prematurely. eg. LVS are three fwgs, fwg1(p1,p2,p3,p4),fwg2(p11,p22),fwg3(p31,p32),only fwg1 in logical_flows --- Hello, thank you for the fix. The commit message seems to be broken as it includes the email header for some reason. Also could you please add test to ovn-northd.at that ensures this won't happen in future? northd/northd.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) ds_put_format(&group_ports, "\"%s\"", fwd_group->child_port[fwd_group->n_child_port - 1]); -- 2.39.3 diff --git a/northd/northd.c b/northd/northd.c index 6898daa00..21ab0bb91 100644 --- a/northd/northd.c +++ b/northd/northd.c @@ -7929,6 +7929,9 @@ build_fwd_group_lflows(struct ovn_datapath *od, struct lflow_table *lflows, continue; } + ds_clear(&match); + ds_clear(&actions); + /* ARP responder for the forwarding group's virtual IP */ ds_put_format(&match, "arp.tpa == %s && arp.op == 1", fwd_group->vip); @@ -7959,9 +7962,9 @@ build_fwd_group_lflows(struct ovn_datapath *od, struct lflow_table *lflows, ds_put_cstr(&group_ports, "liveness=\"true\","); } ds_put_cstr(&group_ports, "childports="); - for (i = 0; i < (fwd_group->n_child_port - 1); ++i) { + for (int j = 0; j < (fwd_group->n_child_port - 1); ++j) { nit: Please use size_t as the "j" type. ds_put_format(&group_ports, "\"%s\",", - fwd_group->child_port[i]); + fwd_group->child_port[j]); }