| Message ID | 20240812121329.2981992-3-xsimonar@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | ovn-fake-multinode tests. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
Thanks Xavier. Acked-by: Mark Michelson <mmichels@redhat.com> On 8/12/24 08:13, Xavier Simonart wrote: > Test was not properly deleting ports created by previous tests, which > could cause the test to fail. > > Fixes: 8d13579bf5b3 ("Add support for centralize routing for distributed gw ports.") > > Signed-off-by: Xavier Simonart <xsimonar@redhat.com> > --- > tests/multinode.at | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tests/multinode.at b/tests/multinode.at > index a04ce7597..a0eb8fc67 100644 > --- a/tests/multinode.at > +++ b/tests/multinode.at > @@ -1062,6 +1062,10 @@ check_fake_multinode_setup > # Delete the multinode NB and OVS resources before starting the test. > cleanup_multinode_resources > > +m_as ovn-chassis-1 ip link del sw0p1-p > +m_as ovn-chassis-2 ip link del sw0p2-p > +m_as ovn-chassis-2 ip link del sw1p1-p > + > check multinode_nbctl ls-add sw0 > check multinode_nbctl lsp-add sw0 sw0-port1 > check multinode_nbctl lsp-set-addresses sw0-port1 "50:54:00:00:00:03 10.0.0.3 1000::3"
diff --git a/tests/multinode.at b/tests/multinode.at index a04ce7597..a0eb8fc67 100644 --- a/tests/multinode.at +++ b/tests/multinode.at @@ -1062,6 +1062,10 @@ check_fake_multinode_setup # Delete the multinode NB and OVS resources before starting the test. cleanup_multinode_resources +m_as ovn-chassis-1 ip link del sw0p1-p +m_as ovn-chassis-2 ip link del sw0p2-p +m_as ovn-chassis-2 ip link del sw1p1-p + check multinode_nbctl ls-add sw0 check multinode_nbctl lsp-add sw0 sw0-port1 check multinode_nbctl lsp-set-addresses sw0-port1 "50:54:00:00:00:03 10.0.0.3 1000::3"
Test was not properly deleting ports created by previous tests, which could cause the test to fail. Fixes: 8d13579bf5b3 ("Add support for centralize routing for distributed gw ports.") Signed-off-by: Xavier Simonart <xsimonar@redhat.com> --- tests/multinode.at | 4 ++++ 1 file changed, 4 insertions(+)