| Message ID | 20240708203832.1373375-1-numans@ovn.org |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [ovs-dev] Maintainers: Fix the typo in the email id. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | fail | github build: failed |
| ovsrobot/github-robot-_ovn-kubernetes | fail | github build: failed |
On 7/8/24 22:38, numans@ovn.org wrote: > From: Numan Siddique <numans@ovn.org> > > Also added my ovn.org email id to the list. > > Signed-off-by: Numan Siddique <numans@ovn.org> > --- Hi Numan, > MAINTAINERS.rst | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst > index f72c8b5eda..0d70048078 100644 > --- a/MAINTAINERS.rst > +++ b/MAINTAINERS.rst > @@ -54,7 +54,8 @@ This is the current list of active OVN committers: > * - Mark Michelson > - mmichels@redhat.com > * - Numan Siddique > - - nusddiq@redhat.com > + - nusiddiq@redhat.com > + - numans@ovn.org Unfortunately, this breaks the format of the maintainers file because the table only has two columns and this adds 3 values for this row: https://github.com/ovsrobot/ovn/blob/series_414329/MAINTAINERS.rst Maybe you can change it to list both emails, separated by comma? I don't really know much .rst so maybe there are other options too. Regards, Dumitru
On Mon, Jul 8, 2024 at 5:05 PM Dumitru Ceara <dceara@redhat.com> wrote: > > On 7/8/24 22:38, numans@ovn.org wrote: > > From: Numan Siddique <numans@ovn.org> > > > > Also added my ovn.org email id to the list. > > > > Signed-off-by: Numan Siddique <numans@ovn.org> > > --- > > Hi Numan, > > > MAINTAINERS.rst | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst > > index f72c8b5eda..0d70048078 100644 > > --- a/MAINTAINERS.rst > > +++ b/MAINTAINERS.rst > > @@ -54,7 +54,8 @@ This is the current list of active OVN committers: > > * - Mark Michelson > > - mmichels@redhat.com > > * - Numan Siddique > > - - nusddiq@redhat.com > > + - nusiddiq@redhat.com > > + - numans@ovn.org > > Unfortunately, this breaks the format of the maintainers file because > the table only has two columns and this adds 3 values for this row: > > https://github.com/ovsrobot/ovn/blob/series_414329/MAINTAINERS.rst > > Maybe you can change it to list both emails, separated by comma? I Thanks for pointing out this error. Separated by comma seems fine to me. Let me test it out before submitting v2. Thanks Numan > don't really know much .rst so maybe there are other options too. > > Regards, > Dumitru > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst index f72c8b5eda..0d70048078 100644 --- a/MAINTAINERS.rst +++ b/MAINTAINERS.rst @@ -54,7 +54,8 @@ This is the current list of active OVN committers: * - Mark Michelson - mmichels@redhat.com * - Numan Siddique - - nusddiq@redhat.com + - nusiddiq@redhat.com + - numans@ovn.org The project also maintains a list of Emeritus Committers (or Maintainers). More information about Emeritus Committers can be found here: