| Message ID | 20240703053020.177517-1-fnordahl@ubuntu.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] ovn-ctl: Fix incorrect use of `==` operator. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
On Wed, Jul 3, 2024 at 1:30 AM Frode Nordahl <fnordahl@ubuntu.com> wrote: > > The ovn-ctl script uses a POSIX shell in its shebang line, > however commit 12412b13c9e2 added two occurrences of the `==` > operator which is bash specific. > > Symptoms of the issue are failure to start up and the follwing > messages logged: > > ovn-ctl: 287: test: X: unexpected operator > ovn-ctl: 307: test: X: unexpected operator > > Fixes: 12412b13c9e2 ("ovn-ctl: Support for --config-file ovsdb-server option.") > Reported-at: https://launchpad.net/bugs/2071767 > Signed-off-by: Frode Nordahl <fnordahl@ubuntu.com> Thanks for fixing this. Applied to main. Numan > --- > utilities/ovn-ctl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl > index a4f410e4f..d7ca9e758 100755 > --- a/utilities/ovn-ctl > +++ b/utilities/ovn-ctl > @@ -284,7 +284,7 @@ $cluster_remote_port > set ovsdb-server > set "$@" $log --log-file=$logfile > set "$@" --pidfile=$db_pid_file > - if test X"$config_file" == X; then > + if test X"$config_file" = X; then > set "$@" --remote=punix:$sock > else > set "$@" --config-file=$config_file > @@ -304,7 +304,7 @@ $cluster_remote_port > set exec "$@" > fi > > - if test X"$use_remote_in_db" != Xno && test X"$config_file" == X; then > + if test X"$use_remote_in_db" != Xno && test X"$config_file" = X; then > set "$@" --remote=db:$schema_name,$table_name,connections > fi > > -- > 2.45.2 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl index a4f410e4f..d7ca9e758 100755 --- a/utilities/ovn-ctl +++ b/utilities/ovn-ctl @@ -284,7 +284,7 @@ $cluster_remote_port set ovsdb-server set "$@" $log --log-file=$logfile set "$@" --pidfile=$db_pid_file - if test X"$config_file" == X; then + if test X"$config_file" = X; then set "$@" --remote=punix:$sock else set "$@" --config-file=$config_file @@ -304,7 +304,7 @@ $cluster_remote_port set exec "$@" fi - if test X"$use_remote_in_db" != Xno && test X"$config_file" == X; then + if test X"$use_remote_in_db" != Xno && test X"$config_file" = X; then set "$@" --remote=db:$schema_name,$table_name,connections fi
The ovn-ctl script uses a POSIX shell in its shebang line, however commit 12412b13c9e2 added two occurrences of the `==` operator which is bash specific. Symptoms of the issue are failure to start up and the follwing messages logged: ovn-ctl: 287: test: X: unexpected operator ovn-ctl: 307: test: X: unexpected operator Fixes: 12412b13c9e2 ("ovn-ctl: Support for --config-file ovsdb-server option.") Reported-at: https://launchpad.net/bugs/2071767 Signed-off-by: Frode Nordahl <fnordahl@ubuntu.com> --- utilities/ovn-ctl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)