| Message ID | 20240627083815.720370-1-amusil@redhat.com |
|---|---|
| State | Accepted |
| Delegated to: | Dumitru Ceara |
| Headers | show |
| Series | [ovs-dev,v2,1/2] ci: Save some DPDK compilation time. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
| ovsrobot/github-robot-_Build_and_Test | fail | github build: failed |
On Thu, Jun 27, 2024 at 10:38 AM Ales Musil <amusil@redhat.com> wrote: > > Add more options that will shave some compilation time off DPDK by > skipping unused parts of the code. > > Suggested-by: David Marchand <david.marchand@redhat.com> > Signed-off-by: Ales Musil <amusil@redhat.com> Reviewed-by: David Marchand <david.marchand@redhat.com>
On 6/28/24 11:15, David Marchand wrote: > On Thu, Jun 27, 2024 at 10:38 AM Ales Musil <amusil@redhat.com> wrote: >> >> Add more options that will shave some compilation time off DPDK by >> skipping unused parts of the code. >> >> Suggested-by: David Marchand <david.marchand@redhat.com> >> Signed-off-by: Ales Musil <amusil@redhat.com> > > Reviewed-by: David Marchand <david.marchand@redhat.com> > Thanks, Ales and David! Applied to main. Regards, Dumitru
diff --git a/utilities/containers/prepare.sh b/utilities/containers/prepare.sh index 460d34a72..49bb2ac91 100755 --- a/utilities/containers/prepare.sh +++ b/utilities/containers/prepare.sh @@ -54,9 +54,9 @@ function build_dpdk() pushd dpdk-src fi - # Switching to 'default' machine to make the dpdk cache usable on + # Switching to 'generic' platform to make the dpdk cache usable on # different CPUs. We can't be sure that all CI machines are exactly same. - DPDK_OPTS="$DPDK_OPTS -Dmachine=default" + DPDK_OPTS="$DPDK_OPTS -Dplatform=generic" # Disable building DPDK unit tests. Not needed for OVS build or tests. DPDK_OPTS="$DPDK_OPTS -Dtests=false" @@ -67,7 +67,9 @@ function build_dpdk() # OVS compilation and the "ovn-system-dpdk" unit tests (run in the CI) # only depend on virtio/tap drivers. - # We can disable all remaining drivers to save compilation time. + # We can disable all applications and remaining drivers to save + # compilation time. + DPDK_OPTS="$DPDK_OPTS -Ddisable_apps=*" DPDK_OPTS="$DPDK_OPTS -Denable_drivers=net/null,net/tap,net/virtio" # OVS depends on the vhost library (and its dependencies). # net/tap depends on the gso library. @@ -76,7 +78,7 @@ function build_dpdk() # Install DPDK using prefix. DPDK_OPTS="$DPDK_OPTS --prefix=$DPDK_INSTALL_DIR" - meson $DPDK_OPTS build + meson setup $DPDK_OPTS build ninja -C build ninja -C build install popd
Add more options that will shave some compilation time off DPDK by skipping unused parts of the code. Suggested-by: David Marchand <david.marchand@redhat.com> Signed-off-by: Ales Musil <amusil@redhat.com> --- utilities/containers/prepare.sh | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)