From patchwork Tue May 7 20:15:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Michelson X-Patchwork-Id: 1932639 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=A8B9Cjkm; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VYqKk4L1Kz1xnT for ; Wed, 8 May 2024 06:16:10 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 022E860BCB; Tue, 7 May 2024 20:16:04 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id WMoFR2ScKnHA; Tue, 7 May 2024 20:16:02 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 0A93960B78 Authentication-Results: smtp3.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=A8B9Cjkm Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id 0A93960B78; Tue, 7 May 2024 20:16:02 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8C5B7C0DD8; Tue, 7 May 2024 20:16:01 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2B2F5C0DD5 for ; Tue, 7 May 2024 20:15:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id BACF860BA5 for ; Tue, 7 May 2024 20:15:58 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id pbhcopAZFdmC for ; Tue, 7 May 2024 20:15:58 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=mmichels@redhat.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 009A260B77 Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=none dis=none) header.from=redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 009A260B77 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 009A260B77 for ; Tue, 7 May 2024 20:15:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715112957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lsm4r4EL6Qo7u30NKLSqEFdgNHVHizWneWg8npqTbjs=; b=A8B9CjkmZH2z8/vn9+i0NBF3P+kz5lMroCIyg4xrHFWAnBfBYkpOSagrUIQsaRIRTMpO2i mA11Tf5J/zsNXR1ai+O9UAfZm0T60hXb7TMHq+wkDRi1r9znJQNjZK8vuXR0gYdD3Z1cgw KpB7qkM/fn5iDfRt3EW3PXcZO6Q8+aU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-137-L8MSadXbNtC6OBKMmulz8Q-1; Tue, 07 May 2024 16:15:55 -0400 X-MC-Unique: L8MSadXbNtC6OBKMmulz8Q-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 02A26800053 for ; Tue, 7 May 2024 20:15:55 +0000 (UTC) Received: from localhost.redhat.com (ovpn-0-20.rdu2.redhat.com [10.22.0.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id A415A3C25 for ; Tue, 7 May 2024 20:15:54 +0000 (UTC) From: Mark Michelson To: dev@openvswitch.org Date: Tue, 7 May 2024 16:15:44 -0400 Message-ID: <20240507201551.1455437-5-mmichels@redhat.com> In-Reply-To: <20240507201551.1455437-1-mmichels@redhat.com> References: <20240507201551.1455437-1-mmichels@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [ovs-dev] [PATCH ovn 4/4] Inclusive language substitutions: "sanity-check". X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" This change introduces alternatives for "sanity-check" (and its variants) throughout the code. Places where "sanity-check" is not replaced: * Many libtool-related files are auto-generated and contain the phrase. Since these files are auto-generated, I did not update these files. Signed-off-by: Mark Michelson --- lib/inc-proc-eng.h | 2 +- tests/ovn-northd.at | 4 ++-- utilities/ovn-nbctl.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/inc-proc-eng.h b/lib/inc-proc-eng.h index 68bbd8266..5bb3b8f3e 100644 --- a/lib/inc-proc-eng.h +++ b/lib/inc-proc-eng.h @@ -342,7 +342,7 @@ bool engine_canceled(void); */ void *engine_get_data(struct engine_node *node); -/* Return a pointer to node data *without* performing any sanity checks on +/* Return a pointer to node data *without* performing any coherance checks on * the state of the node. This may be used only in specific cases when data * is guaranteed to be valid, e.g., immediately after initialization and * before the first engine_run(). diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at index ec18d2dd4..6a7eb839a 100644 --- a/tests/ovn-northd.at +++ b/tests/ovn-northd.at @@ -7340,7 +7340,7 @@ AT_CHECK([cat log_flows], [0], [dnl rm log_flows -# And just for sanity's sake, let's remove the allow-related ACL and make sure +# And just to verify, let's remove the allow-related ACL and make sure # all the special log messages are gone. check ovn-nbctl acl-del pg2 check ovn-nbctl --wait=sb sync @@ -7445,7 +7445,7 @@ AT_CHECK([cat log_flows], [0], [dnl rm log_flows -# And just for sanity's sake, let's remove the allow-related ACL and make sure +# And just to verify, let's remove the allow-related ACL and make sure # all the special log messages are gone. check ovn-nbctl acl-del pg2 check ovn-nbctl --wait=sb sync diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c index 618f3a18b..99d2cba8c 100644 --- a/utilities/ovn-nbctl.c +++ b/utilities/ovn-nbctl.c @@ -5992,7 +5992,7 @@ nbctl_lrp_add(struct ctl_context *ctx) return; } - /* Special-case sanity-check of peer ports. */ + /* Special-case coherance-check of peer ports. */ const char *peer = NULL; for (int i = 0; i < n_settings; i++) { if (!strncmp(settings[i], "peer=", 5)) {