From patchwork Fri Apr 26 17:54:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ihar Hrachyshka X-Patchwork-Id: 1928290 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=P+51kEhv; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VR0lL14J7z1yP2 for ; Sat, 27 Apr 2024 03:56:14 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 240FA6149D; Fri, 26 Apr 2024 17:56:12 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id CchnuiPusQKx; Fri, 26 Apr 2024 17:56:08 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 3923061494 Authentication-Results: smtp3.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=P+51kEhv Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id 3923061494; Fri, 26 Apr 2024 17:56:07 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 09216C0077; Fri, 26 Apr 2024 17:56:07 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 098F3C0DD2 for ; Fri, 26 Apr 2024 17:56:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 4D1A583B30 for ; Fri, 26 Apr 2024 17:56:04 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id b2dowaaFNFL5 for ; Fri, 26 Apr 2024 17:56:03 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=ihrachys@redhat.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org C14C983B36 Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C14C983B36 Authentication-Results: smtp1.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=P+51kEhv Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id C14C983B36 for ; Fri, 26 Apr 2024 17:56:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714154161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EEp96NRnjtdc8emz3Z46oiDiqZtB+fELBYNcXrqjLjo=; b=P+51kEhvf18/tyWpV/o7qs0L+lDOsnBcN92KEOkf2hUWkVkqqg0t2qEysQ/cSOE0PYVpRi 24m73ehLm7tXlcVh5FYj8aA6JG5Jl91g0Z1d1FjEUdgvNoQ8OVb0An+FtMOKfpaQ/RG0hT XhV8mANJhBawRhqMsdUuK8rpsKEsP/w= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-282-p2rAxKBwPSqWIOV9e1B95g-1; Fri, 26 Apr 2024 13:55:58 -0400 X-MC-Unique: p2rAxKBwPSqWIOV9e1B95g-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6a085b7a6ceso32806366d6.2 for ; Fri, 26 Apr 2024 10:55:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714154157; x=1714758957; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EEp96NRnjtdc8emz3Z46oiDiqZtB+fELBYNcXrqjLjo=; b=d3PExqAu40R0KspNnGcow4P+aQ5lAAolBlqEZxx8v8KF8gb6tOlF+3lTyueNbhSiKP Lr8BciWiPJIuYy0saJ4k/hKSq0T83LjqPtgf5IRmS2Mc/54VqOOzI88cI96PkOOYHFJw uwKnApFtCatVjFP+MFjd2ro/gzpSHcTPxE6C28SluqIXELA0viuSE2gAnYAyYee4Dey2 ygKAyFtoSsqS+SsM8qJntpJA6sw26z9g46YRShANWAVvn2uqd4BMZribDCBxkx69XnXQ OOOsu0ujpbSRfE4zZfFfpaezIB6CxRJA+1xtfKNBCkSG+Jfh+1k/l9O5b76kcMYih+Pl RqPw== X-Gm-Message-State: AOJu0YwPIT6RQlke0P5siPusdlYdrhaE5oYl1WkmT+hLwvSQ7NQEkiSJ zoi/1xXSqexWsBvLwm1s3G3hovo1j56ez4ry32vpxf+PJEBXG/puHKnOXb4aqkMfW6pY7/S7cR6 iyOJ6GWPvfc9ndJ/MkWjZ3fL2cfcYriJFFZvu5UtWyHJik0IyEAcB5stP0HDIPfDhr4vkYakwxO FRiIQpdXxNFi3x5uD2gBRDVtBx0N3MUM3NKA== X-Received: by 2002:a05:6214:f23:b0:6a0:810b:327f with SMTP id iw3-20020a0562140f2300b006a0810b327fmr4370636qvb.41.1714154157373; Fri, 26 Apr 2024 10:55:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGYdlgpQd0tY2jcvNnzd3zkh9jHCYgwFWKUuUcuWMABqPxdVXz+7e4/UGHSRLwOCJkQ4JKpnQ== X-Received: by 2002:a05:6214:f23:b0:6a0:810b:327f with SMTP id iw3-20020a0562140f2300b006a0810b327fmr4370612qvb.41.1714154157090; Fri, 26 Apr 2024 10:55:57 -0700 (PDT) Received: from fedora38.localdomain.com ([172.73.180.250]) by smtp.gmail.com with ESMTPSA id w17-20020a056214013100b0069b57111a98sm7179855qvs.79.2024.04.26.10.55.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 10:55:55 -0700 (PDT) From: Ihar Hrachyshka To: dev@openvswitch.org Date: Fri, 26 Apr 2024 17:54:59 +0000 Message-ID: <20240426175501.858655-6-ihrachys@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240426175501.858655-1-ihrachys@redhat.com> References: <20240426175501.858655-1-ihrachys@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [ovs-dev] [PATCH ovn v7 5/6] northd: Remove unused `sb` arg in ls_port_create. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" It's always NULL. Signed-off-by: Ihar Hrachyshka --- northd/northd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/northd/northd.c b/northd/northd.c index 934c22dac..2fef95f38 100644 --- a/northd/northd.c +++ b/northd/northd.c @@ -4342,7 +4342,7 @@ ls_port_init(struct ovn_port *op, struct ovsdb_idl_txn *ovnsb_txn, static struct ovn_port * ls_port_create(struct ovsdb_idl_txn *ovnsb_txn, struct hmap *ls_ports, const char *key, const struct nbrec_logical_switch_port *nbsp, - struct ovn_datapath *od, const struct sbrec_port_binding *sb, + struct ovn_datapath *od, const struct sbrec_mirror_table *sbrec_mirror_table, const struct sbrec_chassis_table *sbrec_chassis_table, struct ovsdb_idl_index *sbrec_chassis_by_name, @@ -4351,7 +4351,7 @@ ls_port_create(struct ovsdb_idl_txn *ovnsb_txn, struct hmap *ls_ports, struct ovn_port *op = ovn_port_create(ls_ports, key, nbsp, NULL, NULL); hmap_insert(&od->ports, &op->dp_node, hmap_node_hash(&op->key_node)); - if (!ls_port_init(op, ovnsb_txn, od, sb, + if (!ls_port_init(op, ovnsb_txn, od, NULL, sbrec_mirror_table, sbrec_chassis_table, sbrec_chassis_by_name, sbrec_chassis_by_hostname)) { ovn_port_destroy(ls_ports, op); @@ -4520,7 +4520,7 @@ ls_handle_lsp_changes(struct ovsdb_idl_txn *ovnsb_idl_txn, goto fail; } op = ls_port_create(ovnsb_idl_txn, &nd->ls_ports, - new_nbsp->name, new_nbsp, od, NULL, + new_nbsp->name, new_nbsp, od, ni->sbrec_mirror_table, ni->sbrec_chassis_table, ni->sbrec_chassis_by_name,