From patchwork Thu Apr 4 21:43:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ihar Hrachyshka X-Patchwork-Id: 1919968 X-Patchwork-Delegate: dceara@redhat.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Zc10JIIx; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V9Zr91PVhz1yYf for ; Fri, 5 Apr 2024 08:43:53 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 1AC6241939; Thu, 4 Apr 2024 21:43:51 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id oHjzHt6KkVwS; Thu, 4 Apr 2024 21:43:49 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.9.56; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org A894A40504 Authentication-Results: smtp4.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Zc10JIIx Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id A894A40504; Thu, 4 Apr 2024 21:43:49 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7B8A3C0072; Thu, 4 Apr 2024 21:43:49 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id A98AFC0037 for ; Thu, 4 Apr 2024 21:43:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 97BA840664 for ; Thu, 4 Apr 2024 21:43:48 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 8HQ6ti2YwOpn for ; Thu, 4 Apr 2024 21:43:47 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=ihrachys@redhat.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org AE39540504 Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org AE39540504 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id AE39540504 for ; Thu, 4 Apr 2024 21:43:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712267026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Tzf4bte5kHUTPiSYg+7XJNQN6/NHYx8rl0wsFIVL7Y8=; b=Zc10JIIxeNQXkDK9Jkvw14CYYkn2xFePB1Wc5u1Zwyj0/0pa5J3mnpNJ8zttp9NiowX+SV i0YiJgZJYNwLer7IqXTzoEwY+Agc8SDKr8yvORoQWHdsVhsdBvL6obUdk1GigEG2F8ilgZ LVyfi3Q/OZvXMijf7kA6MVVl65sV+aQ= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-468-1WYsymQxPJaJxdWoyWAssg-1; Thu, 04 Apr 2024 17:43:45 -0400 X-MC-Unique: 1WYsymQxPJaJxdWoyWAssg-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-78c6a3ff9bcso256776785a.0 for ; Thu, 04 Apr 2024 14:43:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712267024; x=1712871824; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Tzf4bte5kHUTPiSYg+7XJNQN6/NHYx8rl0wsFIVL7Y8=; b=epMAXGuz/aCltUBgFIQSjOvqpaRGi8yIyQqO65S391hEc0W8fjsDlhrJT+x16+g6+L meF6o2TRmXTEaCTXrZUIFCZ/2e3Pb9exEn+7mlLXNFFNt9bT0q14Z8DvG95d7/3uxNx7 8aCVFVXrmZLkSTxqtWxUkZUYJdWj9JdeN830G9qyYbOs1EbYzMEGpcGU2m9vVPgCYgtZ +OzAPFDDRPj61gU49qMxNnfCTQ1HmlirImAwLAY4xiTzvQyyENUGFQts94JEzZf3RqNJ vtWFvF3x7aHAUx1vdSIDC8cwWzVJAU/I2gMqREA0t6jtd503UyAEJQISYt2EW31JQLTX JIQA== X-Gm-Message-State: AOJu0YzKxvYPULRPdx/Pb0bE0IgR/vcVZLul+EwQoq3HkTty+DLcTchG kDCsoClskQ/zDw8SFoxBMiBKnNQaB5nZH468eo0LBG7QiQO6fqNafTcybs/8nIH473wLt3vwkyU Ei96rYXsZHN7BpUO+IyBNUxiRjGJCvwyOQba9lXC0yjjbPRiV7P8MAeFicw/S8FygBCP64oKXR+ Ov5UaBmVUtVfdwbgBZSWainS1KxCg9z7a+sA== X-Received: by 2002:a05:620a:3b83:b0:78d:489c:d24 with SMTP id ye3-20020a05620a3b8300b0078d489c0d24mr539754qkn.7.1712267024346; Thu, 04 Apr 2024 14:43:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHta6f0G38rTuuuHirq7DYbZJCwjnYoLlA3cvf9fbx20ki7GFfUEAqdGYtdK5lgqa10k1dY/w== X-Received: by 2002:a05:620a:3b83:b0:78d:489c:d24 with SMTP id ye3-20020a05620a3b8300b0078d489c0d24mr539739qkn.7.1712267024000; Thu, 04 Apr 2024 14:43:44 -0700 (PDT) Received: from fedora38.localdomain.com (172-073-180-250.res.spectrum.com. [172.73.180.250]) by smtp.gmail.com with ESMTPSA id c6-20020a05620a0ce600b0078bcffed4acsm108209qkj.19.2024.04.04.14.43.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 14:43:43 -0700 (PDT) From: Ihar Hrachyshka To: dev@openvswitch.org Date: Thu, 4 Apr 2024 21:43:39 +0000 Message-ID: <20240404214339.594051-1-ihrachys@redhat.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [ovs-dev] [PATCH ovn] Start mcast id allocations from OVN_MIN_IP_MULTICAST. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Strictly speaking, this is not *essential* to start from MIN and not MIN+1 (once the hint reaches max, it will wrap back to MIN anyway), but this is inconsistent with how we handle datapath and port keys (we start with hint = 0 there). Signed-off-by: Ihar Hrachyshka Acked-by: Ales Musil --- northd/northd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/northd/northd.c b/northd/northd.c index c568f6360..4baff408d 100644 --- a/northd/northd.c +++ b/northd/northd.c @@ -641,7 +641,8 @@ init_mcast_info_for_datapath(struct ovn_datapath *od) } hmap_init(&od->mcast_info.group_tnlids); - od->mcast_info.group_tnlid_hint = OVN_MIN_IP_MULTICAST; + /* allocations start from hint + 1 */ + od->mcast_info.group_tnlid_hint = OVN_MIN_IP_MULTICAST - 1; ovs_list_init(&od->mcast_info.groups); if (od->nbs) {