| Message ID | 20231124110039.2189954-1-dceara@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] northd: Add missing stopwatch initialization. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
| ovsrobot/github-robot-_Build_and_Test | fail | github build: failed |
Thank you Dumitru. Acked-by: Mark Michelson <mmichels@redhat.com> I've merged this to main and branch-23.09. On 11/24/23 06:00, Dumitru Ceara wrote: > We forgot to register the port group and meter stopwatches. Without > that no data is actually collected. > > Fixes: 2225c0755540 ("northd: Move port group processing to its own I-P node.") > Fixes: 46564e6904a6 ("northd: Add a separate I-P node for handling meters.") > Signed-off-by: Dumitru Ceara <dceara@redhat.com> > --- > northd/ovn-northd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c > index 3ce7378214..f3868068d3 100644 > --- a/northd/ovn-northd.c > +++ b/northd/ovn-northd.c > @@ -868,6 +868,8 @@ main(int argc, char *argv[]) > stopwatch_create(LFLOWS_IGMP_STOPWATCH_NAME, SW_MS); > stopwatch_create(LFLOWS_DP_GROUPS_STOPWATCH_NAME, SW_MS); > stopwatch_create(LFLOWS_TO_SB_STOPWATCH_NAME, SW_MS); > + stopwatch_create(PORT_GROUP_RUN_STOPWATCH_NAME, SW_MS); > + stopwatch_create(SYNC_METERS_RUN_STOPWATCH_NAME, SW_MS); > > /* Initialize incremental processing engine for ovn-northd */ > inc_proc_northd_init(&ovnnb_idl_loop, &ovnsb_idl_loop);
diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index 3ce7378214..f3868068d3 100644 --- a/northd/ovn-northd.c +++ b/northd/ovn-northd.c @@ -868,6 +868,8 @@ main(int argc, char *argv[]) stopwatch_create(LFLOWS_IGMP_STOPWATCH_NAME, SW_MS); stopwatch_create(LFLOWS_DP_GROUPS_STOPWATCH_NAME, SW_MS); stopwatch_create(LFLOWS_TO_SB_STOPWATCH_NAME, SW_MS); + stopwatch_create(PORT_GROUP_RUN_STOPWATCH_NAME, SW_MS); + stopwatch_create(SYNC_METERS_RUN_STOPWATCH_NAME, SW_MS); /* Initialize incremental processing engine for ovn-northd */ inc_proc_northd_init(&ovnnb_idl_loop, &ovnsb_idl_loop);
We forgot to register the port group and meter stopwatches. Without that no data is actually collected. Fixes: 2225c0755540 ("northd: Move port group processing to its own I-P node.") Fixes: 46564e6904a6 ("northd: Add a separate I-P node for handling meters.") Signed-off-by: Dumitru Ceara <dceara@redhat.com> --- northd/ovn-northd.c | 2 ++ 1 file changed, 2 insertions(+)