| Message ID | 20231122132847.118673-2-amusil@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Allow to use different container images per branch | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
On 11/22/23 14:28, Ales Musil wrote: > Switch the Cirrus CI to use the Ubuntu image, > so it is unified with the GH actions. That is > useful for various dependency pinnings. > > Signed-off-by: Ales Musil <amusil@redhat.com> > --- Hi Ales, I think I'd just remove this patch. We don't use the container image in the same way starting with patch 2/3. Regards, Dumitru > .cirrus.yml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/.cirrus.yml b/.cirrus.yml > index 2d3824972..71e9afbb6 100644 > --- a/.cirrus.yml > +++ b/.cirrus.yml > @@ -1,7 +1,7 @@ > arm_unit_tests_task: > > arm_container: > - image: ghcr.io/ovn-org/ovn-tests:fedora > + image: ghcr.io/ovn-org/ovn-tests:ubuntu > memory: 4G > cpu: 2 > > @@ -10,6 +10,7 @@ arm_unit_tests_task: > CIRRUS_CLONE_SUBMODULES: true > PATH: ${HOME}/bin:${HOME}/.local/bin:${PATH} > RECHECK: yes > + LANG: C > matrix: > - CC: gcc > TESTSUITE: test
On Thu, Nov 23, 2023 at 11:11 AM Dumitru Ceara <dceara@redhat.com> wrote: > On 11/22/23 14:28, Ales Musil wrote: > > Switch the Cirrus CI to use the Ubuntu image, > > so it is unified with the GH actions. That is > > useful for various dependency pinnings. > > > > Signed-off-by: Ales Musil <amusil@redhat.com> > > --- > > Hi Ales, Hi Dumitru, thank you for the review. > I think I'd just remove this patch. We don't use the container image in > the same way starting with patch 2/3. > Done in v3. > Regards, > Dumitru > > > .cirrus.yml | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/.cirrus.yml b/.cirrus.yml > > index 2d3824972..71e9afbb6 100644 > > --- a/.cirrus.yml > > +++ b/.cirrus.yml > > @@ -1,7 +1,7 @@ > > arm_unit_tests_task: > > > > arm_container: > > - image: ghcr.io/ovn-org/ovn-tests:fedora > > + image: ghcr.io/ovn-org/ovn-tests:ubuntu > > memory: 4G > > cpu: 2 > > > > @@ -10,6 +10,7 @@ arm_unit_tests_task: > > CIRRUS_CLONE_SUBMODULES: true > > PATH: ${HOME}/bin:${HOME}/.local/bin:${PATH} > > RECHECK: yes > > + LANG: C > > matrix: > > - CC: gcc > > TESTSUITE: test > > Thanks, Ales
diff --git a/.cirrus.yml b/.cirrus.yml index 2d3824972..71e9afbb6 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -1,7 +1,7 @@ arm_unit_tests_task: arm_container: - image: ghcr.io/ovn-org/ovn-tests:fedora + image: ghcr.io/ovn-org/ovn-tests:ubuntu memory: 4G cpu: 2 @@ -10,6 +10,7 @@ arm_unit_tests_task: CIRRUS_CLONE_SUBMODULES: true PATH: ${HOME}/bin:${HOME}/.local/bin:${PATH} RECHECK: yes + LANG: C matrix: - CC: gcc TESTSUITE: test
Switch the Cirrus CI to use the Ubuntu image, so it is unified with the GH actions. That is useful for various dependency pinnings. Signed-off-by: Ales Musil <amusil@redhat.com> --- .cirrus.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)