| Message ID | 20231120194522.1818750-1-dceara@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] pinctrl: Fix up comments about sending RST packets for healthcheck. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
On Mon, Nov 20, 2023 at 8:45 PM Dumitru Ceara <dceara@redhat.com> wrote: > We're sending TCP RST not RST-ACK as the comment suggests. > > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-dev/2023-November/409288.html > Reported-by: Mark Michelson <mmichels@redhat.com> > Fixes: a35725a7a24b ("pinctrl: send RST instead of RST_ACK bit for lb hc") > Signed-off-by: Dumitru Ceara <dceara@redhat.com> > --- > controller/pinctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/controller/pinctrl.c b/controller/pinctrl.c > index 62cf4da324..1b176490ea 100644 > --- a/controller/pinctrl.c > +++ b/controller/pinctrl.c > @@ -7887,7 +7887,7 @@ pinctrl_handle_tcp_svc_check(struct rconn *swconn, > svc_mon->n_success++; > svc_mon->state = SVC_MON_S_ONLINE; > > - /* Send RST-ACK packet. */ > + /* Send RST packet. */ > svc_monitor_send_tcp_health_check__(swconn, svc_mon, TCP_RST, > htonl(tcp_ack), > htonl(0), th->tcp_dst); > -- > 2.39.3 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > Looks good to me, thanks. Acked-by: Ales Musil <amusil@redhat.com>
On 11/23/23 15:36, Ales Musil wrote: > > > On Mon, Nov 20, 2023 at 8:45 PM Dumitru Ceara <dceara@redhat.com > <mailto:dceara@redhat.com>> wrote: > > We're sending TCP RST not RST-ACK as the comment suggests. > > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-dev/2023-November/409288.html <https://mail.openvswitch.org/pipermail/ovs-dev/2023-November/409288.html> > Reported-by: Mark Michelson <mmichels@redhat.com > <mailto:mmichels@redhat.com>> > Fixes: a35725a7a24b ("pinctrl: send RST instead of RST_ACK bit for > lb hc") > Signed-off-by: Dumitru Ceara <dceara@redhat.com > <mailto:dceara@redhat.com>> > --- > controller/pinctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/controller/pinctrl.c b/controller/pinctrl.c > index 62cf4da324..1b176490ea 100644 > --- a/controller/pinctrl.c > +++ b/controller/pinctrl.c > @@ -7887,7 +7887,7 @@ pinctrl_handle_tcp_svc_check(struct rconn *swconn, > svc_mon->n_success++; > svc_mon->state = SVC_MON_S_ONLINE; > > - /* Send RST-ACK packet. */ > + /* Send RST packet. */ > svc_monitor_send_tcp_health_check__(swconn, svc_mon, TCP_RST, > htonl(tcp_ack), > htonl(0), th->tcp_dst); > -- > 2.39.3 > > _______________________________________________ > dev mailing list > dev@openvswitch.org <mailto:dev@openvswitch.org> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > <https://mail.openvswitch.org/mailman/listinfo/ovs-dev> > > > Looks good to me, thanks. > > Acked-by: Ales Musil <amusil@redhat.com <mailto:amusil@redhat.com>> > Thanks, Ales! Applied to main and backported down to 22.03. Regards, Dumitru
diff --git a/controller/pinctrl.c b/controller/pinctrl.c index 62cf4da324..1b176490ea 100644 --- a/controller/pinctrl.c +++ b/controller/pinctrl.c @@ -7887,7 +7887,7 @@ pinctrl_handle_tcp_svc_check(struct rconn *swconn, svc_mon->n_success++; svc_mon->state = SVC_MON_S_ONLINE; - /* Send RST-ACK packet. */ + /* Send RST packet. */ svc_monitor_send_tcp_health_check__(swconn, svc_mon, TCP_RST, htonl(tcp_ack), htonl(0), th->tcp_dst);
We're sending TCP RST not RST-ACK as the comment suggests. Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2023-November/409288.html Reported-by: Mark Michelson <mmichels@redhat.com> Fixes: a35725a7a24b ("pinctrl: send RST instead of RST_ACK bit for lb hc") Signed-off-by: Dumitru Ceara <dceara@redhat.com> --- controller/pinctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)