diff mbox series

[ovs-dev] ovn-northd: Remove dumping unknown table "port_group_set".

Message ID 20230915150253.889897-1-numans@ovn.org
State Accepted
Headers show
Series [ovs-dev] ovn-northd: Remove dumping unknown table "port_group_set". | expand

Checks

Context Check Description
ovsrobot/apply-robot warning apply and check: warning
ovsrobot/github-robot-_Build_and_Test fail github build: failed
ovsrobot/github-robot-_ovn-kubernetes fail github build: failed

Commit Message

Numan Siddique Sept. 15, 2023, 3:02 p.m. UTC 
From: Numan Siddique <numans@ovn.org>

_DUMP_DB_TABLES macro dumps this unknown table in SB DB.

Fixes: 5b6a7adbf353("northd: Add incremental processing for NB port groups.")

Signed-off-by: Numan Siddique <numans@ovn.org>
---
 tests/ovn-northd.at | 1 -
 1 file changed, 1 deletion(-)

Comments

Dumitru Ceara Sept. 15, 2023, 4:12 p.m. UTC | #1 
On 9/15/23 17:02, numans@ovn.org wrote:
> From: Numan Siddique <numans@ovn.org>
> 
> _DUMP_DB_TABLES macro dumps this unknown table in SB DB.
> 
> Fixes: 5b6a7adbf353("northd: Add incremental processing for NB port groups.")

Nit, the correct format is:

Fixes: 5b6a7adbf353 ("northd: Add incremental processing for NB port groups.")

> 
> Signed-off-by: Numan Siddique <numans@ovn.org>
> ---
>  tests/ovn-northd.at | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at
> index 8ffd111af6..7f584ef705 100644
> --- a/tests/ovn-northd.at
> +++ b/tests/ovn-northd.at
> @@ -11,7 +11,6 @@ m4_define([_DUMP_DB_TABLES], [
>      ovn-sbctl list address_set >> $1
>      ovn-sbctl list meter >> $1
>      ovn-sbctl list meter_band >> $1
> -    ovn-sbctl list port_group_set >> $1

Oops, I really meant "port_group" here, sorry about that.  Could you
please change it to "ovn-sbctl list port_group >> $1" instead?  I
didn't test this thoroughly but I'm guessing it should work.

With that addressed:

Acked-by: Dumitru Ceara <dceara@redhat.com>

Thanks,
Dumitru
Numan Siddique Sept. 15, 2023, 4:49 p.m. UTC | #2 
On Fri, Sep 15, 2023 at 12:13 PM Dumitru Ceara <dceara@redhat.com> wrote:
>
> On 9/15/23 17:02, numans@ovn.org wrote:
> > From: Numan Siddique <numans@ovn.org>
> >
> > _DUMP_DB_TABLES macro dumps this unknown table in SB DB.
> >
> > Fixes: 5b6a7adbf353("northd: Add incremental processing for NB port groups.")
>
> Nit, the correct format is:
>
> Fixes: 5b6a7adbf353 ("northd: Add incremental processing for NB port groups.")
>
> >
> > Signed-off-by: Numan Siddique <numans@ovn.org>
> > ---
> >  tests/ovn-northd.at | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at
> > index 8ffd111af6..7f584ef705 100644
> > --- a/tests/ovn-northd.at
> > +++ b/tests/ovn-northd.at
> > @@ -11,7 +11,6 @@ m4_define([_DUMP_DB_TABLES], [
> >      ovn-sbctl list address_set >> $1
> >      ovn-sbctl list meter >> $1
> >      ovn-sbctl list meter_band >> $1
> > -    ovn-sbctl list port_group_set >> $1
>
> Oops, I really meant "port_group" here, sorry about that.  Could you
> please change it to "ovn-sbctl list port_group >> $1" instead?  I
> didn't test this thoroughly but I'm guessing it should work.
>
> With that addressed:
>
> Acked-by: Dumitru Ceara <dceara@redhat.com>

Thanks.  I applied this patch to main and branch-23.09 after fixing
the warning and changing the table to "port_group".

Numan

>
> Thanks,
> Dumitru
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
diff mbox series

Patch

diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at
index 8ffd111af6..7f584ef705 100644
--- a/tests/ovn-northd.at
+++ b/tests/ovn-northd.at
@@ -11,7 +11,6 @@  m4_define([_DUMP_DB_TABLES], [
     ovn-sbctl list address_set >> $1
     ovn-sbctl list meter >> $1
     ovn-sbctl list meter_band >> $1
-    ovn-sbctl list port_group_set >> $1
 ])
 
 # CHECK_NO_CHANGE_AFTER_RECOMPUTE