From patchwork Wed Aug 16 22:26:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 1822059 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RR2lx2Nb6z1yfk for ; Thu, 17 Aug 2023 08:26:05 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0E706837B6; Wed, 16 Aug 2023 22:26:03 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0E706837B6 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xdmad95QifaR; Wed, 16 Aug 2023 22:26:02 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id 4557A83976; Wed, 16 Aug 2023 22:26:01 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4557A83976 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1C9F6C0088; Wed, 16 Aug 2023 22:26:01 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id D1459C0DD9 for ; Wed, 16 Aug 2023 22:25:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 9F81A6142A for ; Wed, 16 Aug 2023 22:25:58 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 9F81A6142A X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7Z9fyUeb16ZU for ; Wed, 16 Aug 2023 22:25:57 +0000 (UTC) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::221]) by smtp3.osuosl.org (Postfix) with ESMTPS id 45DEC6141F for ; Wed, 16 Aug 2023 22:25:57 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 45DEC6141F Received: by mail.gandi.net (Postfix) with ESMTPSA id 597AC240005; Wed, 16 Aug 2023 22:25:55 +0000 (UTC) From: Ilya Maximets To: ovs-dev@openvswitch.org Date: Thu, 17 Aug 2023 00:26:26 +0200 Message-Id: <20230816222627.3873712-3-i.maximets@ovn.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230816222627.3873712-1-i.maximets@ovn.org> References: <20230816222627.3873712-1-i.maximets@ovn.org> MIME-Version: 1.0 X-GND-Sasl: i.maximets@ovn.org Cc: Ilya Maximets Subject: [ovs-dev] [PATCH ovn 2/3] m4: Replace obsolete AC_ERROR with AC_MSG_ERROR. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" AC_ERROR is triggering a warning on systems with autoconf 2.70+: $ ./boot.sh ... configure.ac:174: warning: The macro `AC_ERROR' is obsolete. configure.ac:174: You should run autoupdate. ... Replace with AC_MSG_ERROR that is supported in all versions of autoconf that we care about (2.63+). Signed-off-by: Ilya Maximets --- acinclude.m4 | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 4198120bc..ad3ee9fdf 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -412,7 +412,7 @@ AC_DEFUN([OVN_CHECK_OVS], [ fi OVSDIR=$(cd "$(eval echo "$with_ovs_source")"; pwd) if test ! -f "$OVSDIR/vswitchd/bridge.c"; then - AC_ERROR([$OVSDIR is not an OVS source directory]) + AC_MSG_ERROR([$OVSDIR is not an OVS source directory]) fi AC_MSG_RESULT([$OVSDIR]) @@ -426,13 +426,16 @@ AC_DEFUN([OVN_CHECK_OVS], [ *) OVSBUILDDIR=`pwd`/$OVSBUILDDIR ;; esac if test ! -f "$OVSBUILDDIR/config.h"; then - AC_ERROR([$OVSBUILDDIR is not a configured OVS build directory]) + AC_MSG_ERROR([$OVSBUILDDIR is not a configured OVS build directory]) fi elif test -f "$OVSDIR/config.h"; then # If separate build dir is not specified, use src dir. OVSBUILDDIR=$OVSDIR else - AC_ERROR([OVS source dir $OVSDIR is not configured as a build directory (either run configure there or use --with-ovs-build to point to the build directory)]) + AC_MSG_ERROR(m4_normalize([ + OVS source dir $OVSDIR is not configured as a build directory + (either run configure there or use --with-ovs-build to point + to the build directory)])) fi AC_MSG_RESULT([$OVSBUILDDIR]) AC_SUBST(OVSBUILDDIR)