From patchwork Tue Jan 24 15:16:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Adri=C3=A1n_Moreno?= X-Patchwork-Id: 1731268 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CkTwPtju; dkim-atps=neutral Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4P1Vvn3zshz23hW for ; Wed, 25 Jan 2023 02:17:41 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id A3E04820EC; Tue, 24 Jan 2023 15:17:38 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org A3E04820EC Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CkTwPtju X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W7HHd2aJvDhl; Tue, 24 Jan 2023 15:17:37 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id 9732B822D6; Tue, 24 Jan 2023 15:17:36 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9732B822D6 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id ED326C007E; Tue, 24 Jan 2023 15:17:33 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7CD58C002D for ; Tue, 24 Jan 2023 15:17:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 442B141970 for ; Tue, 24 Jan 2023 15:17:29 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 442B141970 Authentication-Results: smtp4.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CkTwPtju X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HoY4KOEIOVdu for ; Tue, 24 Jan 2023 15:17:28 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org E2A4F41925 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id E2A4F41925 for ; Tue, 24 Jan 2023 15:17:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674573446; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VbLFnJb7tnpmu3NMIdd1QSkjYJ+Q8RE71aqsM6/mpLk=; b=CkTwPtjuU01Gy4UW69f9KIgHBp5bh+CxYy3kbHiS6LxYqza7xxtScskj1XB1AUj6FHqgit 7U6C/wIjQJsntdahGXMtTpADdy48VWHfMF9lHX5b+HpiYkHhIDSLYaCHSC33IW4UrlHsmP jNgklGLbjnMjbTn+OjK6K0Z31kc24Dw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-398-P8JVfPd_PJKzYioaosZ8NA-1; Tue, 24 Jan 2023 10:17:19 -0500 X-MC-Unique: P8JVfPd_PJKzYioaosZ8NA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C1327181761E for ; Tue, 24 Jan 2023 15:16:36 +0000 (UTC) Received: from antares.redhat.com (unknown [10.39.194.157]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9DBD2492B00; Tue, 24 Jan 2023 15:16:35 +0000 (UTC) From: =?utf-8?q?Adri=C3=A1n_Moreno?= To: dev@openvswitch.org Date: Tue, 24 Jan 2023 16:16:27 +0100 Message-Id: <20230124151632.695912-2-amorenoz@redhat.com> In-Reply-To: <20230124151632.695912-1-amorenoz@redhat.com> References: <20230124151632.695912-1-amorenoz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [ovs-dev] [PATCH ovn v1 1/6] controller: fix recompute pflows if sampling changes X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" From: Adrian Moreno The engine handler needs to return "false" in order to trigger a full recompute of the physical flows. Fixes: a42c808f30b4 ("northd: add drop sampling") Signed-off-by: Adrian Moreno --- controller/ovn-controller.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/controller/ovn-controller.c b/controller/ovn-controller.c index 265740cab..f20972c76 100644 --- a/controller/ovn-controller.c +++ b/controller/ovn-controller.c @@ -3839,10 +3839,11 @@ pflow_output_sb_sb_global_handler(struct engine_node *node, void *data) if (pfo->debug.collector_set_id != collector_set_id || pfo->debug.obs_domain_id != obs_domain_id) { - engine_set_node_state(node, EN_UPDATED); pfo->debug.collector_set_id = collector_set_id; pfo->debug.obs_domain_id = obs_domain_id; + return false; } + engine_set_node_state(node, EN_UPDATED); return true; }