diff mbox series

[ovs-dev,2/2] northd: fix typo in consider_l3d{wg, gw}... function

Message ID 20221222174309.3141692-2-odivlad@gmail.com
State Superseded, archived
Headers show
Series [ovs-dev,1/2] northd: make traffic routed to vtep lport distributed | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_ovn-kubernetes fail github build: failed

Commit Message

Vladislav Odintsov Dec. 22, 2022, 5:43 p.m. UTC 
Signed-off-by: Vladislav Odintsov <odivlad@gmail.com>
---
 northd/northd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Horman Jan. 18, 2023, 12:49 p.m. UTC | #1 
On Thu, Dec 22, 2022 at 08:43:09PM +0300, Vladislav Odintsov wrote:

A patch description would be nice here.

> Signed-off-by: Vladislav Odintsov <odivlad@gmail.com>

That not withstanding,

Reviewed-by: Simon Horman <simon.horman@corigine.com>

> ---
>  northd/northd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/northd/northd.c b/northd/northd.c
> index 07fb0ab9a..9ee9b590d 100644
> --- a/northd/northd.c
> +++ b/northd/northd.c
> @@ -11612,7 +11612,7 @@ build_gateway_mtu_flow(struct hmap *lflows, struct ovn_port *op,
>  }
>  
>  static bool
> -consider_l3dwg_port_is_centralized(struct ovn_port *op)
> +consider_l3dgw_port_is_centralized(struct ovn_port *op)
>  {
>      if (op->peer && op->peer->od->has_vtep_lports) {
>          return false;
> @@ -11663,7 +11663,7 @@ build_adm_ctrl_flows_for_lrouter_port(
>          ds_clear(match);
>          ds_put_format(match, "eth.dst == %s && inport == %s",
>                        op->lrp_networks.ea_s, op->json_key);
> -        if (consider_l3dwg_port_is_centralized(op)) {
> +        if (consider_l3dgw_port_is_centralized(op)) {
>              ds_put_format(match, " && is_chassis_resident(%s)",
>                            op->cr_port->json_key);
>          }
> -- 
> 2.36.1
> 
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
diff mbox series

Patch

diff --git a/northd/northd.c b/northd/northd.c
index 07fb0ab9a..9ee9b590d 100644
--- a/northd/northd.c
+++ b/northd/northd.c
@@ -11612,7 +11612,7 @@  build_gateway_mtu_flow(struct hmap *lflows, struct ovn_port *op,
 }
 
 static bool
-consider_l3dwg_port_is_centralized(struct ovn_port *op)
+consider_l3dgw_port_is_centralized(struct ovn_port *op)
 {
     if (op->peer && op->peer->od->has_vtep_lports) {
         return false;
@@ -11663,7 +11663,7 @@  build_adm_ctrl_flows_for_lrouter_port(
         ds_clear(match);
         ds_put_format(match, "eth.dst == %s && inport == %s",
                       op->lrp_networks.ea_s, op->json_key);
-        if (consider_l3dwg_port_is_centralized(op)) {
+        if (consider_l3dgw_port_is_centralized(op)) {
             ds_put_format(match, " && is_chassis_resident(%s)",
                           op->cr_port->json_key);
         }