From patchwork Mon Dec 19 16:18:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Adri=C3=A1n_Moreno?= X-Patchwork-Id: 1717471 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BzL10NsA; dkim-atps=neutral Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NbPym0csTz1ydb for ; Tue, 20 Dec 2022 03:18:40 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 8AF7A60BFC; Mon, 19 Dec 2022 16:18:37 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8AF7A60BFC Authentication-Results: smtp3.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BzL10NsA X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OqOEY4de8BC5; Mon, 19 Dec 2022 16:18:36 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 81C2660E45; Mon, 19 Dec 2022 16:18:35 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 81C2660E45 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 859FEC007B; Mon, 19 Dec 2022 16:18:33 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id E96DDC002D for ; Mon, 19 Dec 2022 16:18:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id C4BCD608B7 for ; Mon, 19 Dec 2022 16:18:30 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org C4BCD608B7 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j2z-kC__fAdL for ; Mon, 19 Dec 2022 16:18:30 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 12F8E60585 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 12F8E60585 for ; Mon, 19 Dec 2022 16:18:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671466709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vqa2bB1mBs6PRyKhoLXANg4oYIVw7L7Gv95rTFBCiPA=; b=BzL10NsA0LgWvnQfZSwcuK4OpXAW7e2B1FeX9BT/8pIVaVhid8vGF9Tj6tnPtWZXLGm5Z5 cQSs49LIvOXoPYfTjXo5NIOKFzVxCKGxwwhoF0X57HkyBT4tibnr0XQTQoj8JBbJ9aXDZq YIMReUFl9LdrsOSx+UjPHk4rNoqtrKY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-378-XmHtDygYO2Ox9qoNZfLOGw-1; Mon, 19 Dec 2022 11:18:27 -0500 X-MC-Unique: XmHtDygYO2Ox9qoNZfLOGw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4A0BD85C06C for ; Mon, 19 Dec 2022 16:18:27 +0000 (UTC) Received: from antares.redhat.com (unknown [10.39.192.43]) by smtp.corp.redhat.com (Postfix) with ESMTP id A74732026D4B; Mon, 19 Dec 2022 16:18:26 +0000 (UTC) From: Adrian Moreno To: dev@openvswitch.org Date: Mon, 19 Dec 2022 17:18:12 +0100 Message-Id: <20221219161814.55422-5-amorenoz@redhat.com> In-Reply-To: <20221219161814.55422-1-amorenoz@redhat.com> References: <20221219161814.55422-1-amorenoz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [ovs-dev] [PATCH ovn 4/6] controller: set sampling port to OFP_NONE for drops X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" The default zero value can lead to sampling errors if the pipeline sets an the input port to OFP_NONE during flow processing. Fixes: a42c808f30b4 ("northd: add drop sampling") Signed-off-by: Adrian Moreno Acked-by: Mark Michelson --- controller/physical.c | 1 + 1 file changed, 1 insertion(+) diff --git a/controller/physical.c b/controller/physical.c index 2444d3ebd..d715c2bfa 100644 --- a/controller/physical.c +++ b/controller/physical.c @@ -843,6 +843,7 @@ put_drop(const struct physical_debug *debug, uint8_t table_id, os->collector_set_id = debug->collector_set_id; os->obs_domain_id = (debug->obs_domain_id << 24); os->obs_point_id = table_id; + os->sampling_port = OFPP_NONE; } }