diff mbox series

[ovs-dev] run CI for every commit when merging several commits, not for the latest.

Message ID 20220804145543.8294-1-fsb4000@yandex.ru
State Accepted
Headers show
Series [ovs-dev] run CI for every commit when merging several commits, not for the latest. | expand

Checks

Context Check Description
ovsrobot/apply-robot warning apply and check: warning
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_ovn-kubernetes success github build: passed

Commit Message

Igor Zhukov Aug. 4, 2022, 2:55 p.m. UTC
From: Igor Zhukov <ivzhukov@sbercloud.ru>

Docs: https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-a-fallback-value

Test: https://github.com/fsb4000/ovn/actions and https://imgur.com/a/mUBQWSO

Signed-off-by: Igor Zhukov <ivzhukov@sbercloud.ru>
---
 .github/workflows/ovn-kubernetes.yml | 2 +-
 .github/workflows/test.yml           | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

0-day Robot Aug. 4, 2022, 3:19 p.m. UTC | #1
Bleep bloop.  Greetings Igor Zhukov, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 88 characters long (recommended limit is 79)
#25 FILE: .github/workflows/ovn-kubernetes.yml:12:
  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}

WARNING: Line is 88 characters long (recommended limit is 79)
#38 FILE: .github/workflows/test.yml:11:
  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}

Lines checked: 44, Warnings: 2, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
Numan Siddique Aug. 8, 2022, 12:56 a.m. UTC | #2
On Fri, Aug 5, 2022 at 1:05 AM Igor Zhukov <fsb4000@yandex.ru> wrote:
>
> From: Igor Zhukov <ivzhukov@sbercloud.ru>
>
> Docs: https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-a-fallback-value
>
> Test: https://github.com/fsb4000/ovn/actions and https://imgur.com/a/mUBQWSO
>
> Signed-off-by: Igor Zhukov <ivzhukov@sbercloud.ru>

Thanks.  I applied this patch to the main branch.

Numan

> ---
>  .github/workflows/ovn-kubernetes.yml | 2 +-
>  .github/workflows/test.yml           | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.github/workflows/ovn-kubernetes.yml b/.github/workflows/ovn-kubernetes.yml
> index 03f35d7a3..32eb2350b 100644
> --- a/.github/workflows/ovn-kubernetes.yml
> +++ b/.github/workflows/ovn-kubernetes.yml
> @@ -9,7 +9,7 @@ on:
>    - cron: '0 0 * * 0'
>
>  concurrency:
> -  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
> +  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
>    cancel-in-progress: true
>
>  env:
> diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
> index 3b7283229..76a7ce090 100644
> --- a/.github/workflows/test.yml
> +++ b/.github/workflows/test.yml
> @@ -8,7 +8,7 @@ on:
>      - cron: '0 0 * * 0'
>
>  concurrency:
> -  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
> +  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
>    cancel-in-progress: true
>
>  jobs:
> --
> 2.30.2
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
Igor Zhukov Aug. 8, 2022, 3:39 a.m. UTC | #3
Great!
I see it works: https://github.com/ovn-org/ovn/commits/main 

> On Fri, Aug 5, 2022 at 1:05 AM Igor Zhukov <fsb4000@yandex.ru> wrote:
> 
>> From: Igor Zhukov <ivzhukov@sbercloud.ru>
>>
>> Docs: https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-a-fallback-value
>>
>> Test: https://github.com/fsb4000/ovn/actions and https://imgur.com/a/mUBQWSO
>>
>> Signed-off-by: Igor Zhukov <ivzhukov@sbercloud.ru>
> 
> Thanks. I applied this patch to the main branch.
> 
> Numan
> 
>> ---
>> .github/workflows/ovn-kubernetes.yml | 2 +-
>> .github/workflows/test.yml | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/.github/workflows/ovn-kubernetes.yml b/.github/workflows/ovn-kubernetes.yml
>> index 03f35d7a3..32eb2350b 100644
>> --- a/.github/workflows/ovn-kubernetes.yml
>> +++ b/.github/workflows/ovn-kubernetes.yml
>> @@ -9,7 +9,7 @@ on:
>> - cron: '0 0 * * 0'
>>
>> concurrency:
>> - group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
>> + group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
>> cancel-in-progress: true
>>
>> env:
>> diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
>> index 3b7283229..76a7ce090 100644
>> --- a/.github/workflows/test.yml
>> +++ b/.github/workflows/test.yml
>> @@ -8,7 +8,7 @@ on:
>> - cron: '0 0 * * 0'
>>
>> concurrency:
>> - group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
>> + group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
>> cancel-in-progress: true
>>
>> jobs:
>> --
>> 2.30.2
>>
>> _______________________________________________
>> dev mailing list
>> dev@openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
diff mbox series

Patch

diff --git a/.github/workflows/ovn-kubernetes.yml b/.github/workflows/ovn-kubernetes.yml
index 03f35d7a3..32eb2350b 100644
--- a/.github/workflows/ovn-kubernetes.yml
+++ b/.github/workflows/ovn-kubernetes.yml
@@ -9,7 +9,7 @@  on:
   - cron: '0 0 * * 0'
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
   cancel-in-progress: true
 
 env:
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 3b7283229..76a7ce090 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -8,7 +8,7 @@  on:
     - cron: '0 0 * * 0'
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
   cancel-in-progress: true
 
 jobs: