diff mbox series

[ovs-dev] ovn-northd: Doc: Update OVN tables number

Message ID 20211011165212.263177-1-mheib@redhat.com
State Accepted
Headers show
Series [ovs-dev] ovn-northd: Doc: Update OVN tables number | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_ovn-kubernetes fail github build: failed

Commit Message

Mohammad Heib Oct. 11, 2021, 4:52 p.m. UTC 
From: Mohammad Heib <mheib@redhat.com>

Update old OVN tables numbers to match the correct tables number

Signed-off-by: Mohammad Heib <mheib@redhat.com>
---
 northd/northd.c         | 6 +++---
 northd/ovn-northd.8.xml | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

Comments

Mark Gray Oct. 15, 2021, 2:43 p.m. UTC | #1 
On 11/10/2021 17:52, mheib@redhat.com wrote:
> From: Mohammad Heib <mheib@redhat.com>
> 
> Update old OVN tables numbers to match the correct tables number
> 
> Signed-off-by: Mohammad Heib <mheib@redhat.com>
> ---
>  northd/northd.c         | 6 +++---
>  northd/ovn-northd.8.xml | 4 ++--
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/northd/northd.c b/northd/northd.c
> index 32ab3baf3..0bf66e0b2 100644
> --- a/northd/northd.c
> +++ b/northd/northd.c
> @@ -7440,7 +7440,7 @@ build_lswitch_lflows_admission_control(struct ovn_datapath *od,
>      }
>  }
>  
> -/* Ingress table 13: ARP/ND responder, skip requests coming from localnet
> +/* Ingress table 16: ARP/ND responder, skip requests coming from localnet
>   * and vtep ports. (priority 100); see ovn-northd.8.xml for the
>   * rationale. */
>  
> @@ -7682,7 +7682,7 @@ build_lswitch_arp_nd_responder_known_ips(struct ovn_port *op,
>      }
>  }
>  
> -/* Ingress table 13: ARP/ND responder, by default goto next.
> +/* Ingress table 16: ARP/ND responder, by default goto next.
>   * (priority 0)*/
>  static void
>  build_lswitch_arp_nd_responder_default(struct ovn_datapath *od,
> @@ -7693,7 +7693,7 @@ build_lswitch_arp_nd_responder_default(struct ovn_datapath *od,
>      }
>  }
>  
> -/* Ingress table 13: ARP/ND responder for service monitor source ip.
> +/* Ingress table 16: ARP/ND responder for service monitor source ip.
>   * (priority 110)*/
>  static void
>  build_lswitch_arp_nd_service_monitor(struct ovn_northd_lb *lb,
> diff --git a/northd/ovn-northd.8.xml b/northd/ovn-northd.8.xml
> index 39f4eaa0c..d219c5618 100644
> --- a/northd/ovn-northd.8.xml
> +++ b/northd/ovn-northd.8.xml
> @@ -1870,14 +1870,14 @@ output;
>          A priority 34000 logical flow is added for each logical port which
>          has DHCPv4 options defined to allow the DHCPv4 reply packet and which has
>          DHCPv6 options defined to allow the DHCPv6 reply packet from the
> -        <code>Ingress Table 16: DHCP responses</code>.
> +        <code>Ingress Table 18: DHCP responses</code>.
>        </li>
>  
>        <li>
>          A priority 34000 logical flow is added for each logical switch datapath
>          configured with DNS records with the match <code>udp.dst = 53</code>
>          to allow the DNS reply packet from the
> -        <code>Ingress Table 18: DNS responses</code>.
> +        <code>Ingress Table 20: DNS responses</code>.
>        </li>
>  
>        <li>
> 
Acked-by: Mark D. Gray <mark.d.gray@redhat.com>
Numan Siddique Oct. 20, 2021, 2:59 p.m. UTC | #2 
On Fri, Oct 15, 2021 at 10:43 AM Mark Gray <mark.d.gray@redhat.com> wrote:
>
> On 11/10/2021 17:52, mheib@redhat.com wrote:
> > From: Mohammad Heib <mheib@redhat.com>
> >
> > Update old OVN tables numbers to match the correct tables number
> >
> > Signed-off-by: Mohammad Heib <mheib@redhat.com>
> > ---
> >  northd/northd.c         | 6 +++---
> >  northd/ovn-northd.8.xml | 4 ++--
> >  2 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/northd/northd.c b/northd/northd.c
> > index 32ab3baf3..0bf66e0b2 100644
> > --- a/northd/northd.c
> > +++ b/northd/northd.c
> > @@ -7440,7 +7440,7 @@ build_lswitch_lflows_admission_control(struct ovn_datapath *od,
> >      }
> >  }
> >
> > -/* Ingress table 13: ARP/ND responder, skip requests coming from localnet
> > +/* Ingress table 16: ARP/ND responder, skip requests coming from localnet
> >   * and vtep ports. (priority 100); see ovn-northd.8.xml for the
> >   * rationale. */
> >
> > @@ -7682,7 +7682,7 @@ build_lswitch_arp_nd_responder_known_ips(struct ovn_port *op,
> >      }
> >  }
> >
> > -/* Ingress table 13: ARP/ND responder, by default goto next.
> > +/* Ingress table 16: ARP/ND responder, by default goto next.
> >   * (priority 0)*/
> >  static void
> >  build_lswitch_arp_nd_responder_default(struct ovn_datapath *od,
> > @@ -7693,7 +7693,7 @@ build_lswitch_arp_nd_responder_default(struct ovn_datapath *od,
> >      }
> >  }
> >
> > -/* Ingress table 13: ARP/ND responder for service monitor source ip.
> > +/* Ingress table 16: ARP/ND responder for service monitor source ip.
> >   * (priority 110)*/
> >  static void
> >  build_lswitch_arp_nd_service_monitor(struct ovn_northd_lb *lb,
> > diff --git a/northd/ovn-northd.8.xml b/northd/ovn-northd.8.xml
> > index 39f4eaa0c..d219c5618 100644
> > --- a/northd/ovn-northd.8.xml
> > +++ b/northd/ovn-northd.8.xml
> > @@ -1870,14 +1870,14 @@ output;
> >          A priority 34000 logical flow is added for each logical port which
> >          has DHCPv4 options defined to allow the DHCPv4 reply packet and which has
> >          DHCPv6 options defined to allow the DHCPv6 reply packet from the
> > -        <code>Ingress Table 16: DHCP responses</code>.
> > +        <code>Ingress Table 18: DHCP responses</code>.
> >        </li>
> >
> >        <li>
> >          A priority 34000 logical flow is added for each logical switch datapath
> >          configured with DNS records with the match <code>udp.dst = 53</code>
> >          to allow the DNS reply packet from the
> > -        <code>Ingress Table 18: DNS responses</code>.
> > +        <code>Ingress Table 20: DNS responses</code>.
> >        </li>
> >
> >        <li>
> >
> Acked-by: Mark D. Gray <mark.d.gray@redhat.com>

Thanks.  I applied to the main branch.

Numan

>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
Mohammad Heib Oct. 20, 2021, 3:04 p.m. UTC | #3 
Thank you :)

On Wed, Oct 20, 2021 at 5:59 PM Numan Siddique <numans@ovn.org> wrote:

> On Fri, Oct 15, 2021 at 10:43 AM Mark Gray <mark.d.gray@redhat.com> wrote:
> >
> > On 11/10/2021 17:52, mheib@redhat.com wrote:
> > > From: Mohammad Heib <mheib@redhat.com>
> > >
> > > Update old OVN tables numbers to match the correct tables number
> > >
> > > Signed-off-by: Mohammad Heib <mheib@redhat.com>
> > > ---
> > >  northd/northd.c         | 6 +++---
> > >  northd/ovn-northd.8.xml | 4 ++--
> > >  2 files changed, 5 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/northd/northd.c b/northd/northd.c
> > > index 32ab3baf3..0bf66e0b2 100644
> > > --- a/northd/northd.c
> > > +++ b/northd/northd.c
> > > @@ -7440,7 +7440,7 @@ build_lswitch_lflows_admission_control(struct
> ovn_datapath *od,
> > >      }
> > >  }
> > >
> > > -/* Ingress table 13: ARP/ND responder, skip requests coming from
> localnet
> > > +/* Ingress table 16: ARP/ND responder, skip requests coming from
> localnet
> > >   * and vtep ports. (priority 100); see ovn-northd.8.xml for the
> > >   * rationale. */
> > >
> > > @@ -7682,7 +7682,7 @@ build_lswitch_arp_nd_responder_known_ips(struct
> ovn_port *op,
> > >      }
> > >  }
> > >
> > > -/* Ingress table 13: ARP/ND responder, by default goto next.
> > > +/* Ingress table 16: ARP/ND responder, by default goto next.
> > >   * (priority 0)*/
> > >  static void
> > >  build_lswitch_arp_nd_responder_default(struct ovn_datapath *od,
> > > @@ -7693,7 +7693,7 @@ build_lswitch_arp_nd_responder_default(struct
> ovn_datapath *od,
> > >      }
> > >  }
> > >
> > > -/* Ingress table 13: ARP/ND responder for service monitor source ip.
> > > +/* Ingress table 16: ARP/ND responder for service monitor source ip.
> > >   * (priority 110)*/
> > >  static void
> > >  build_lswitch_arp_nd_service_monitor(struct ovn_northd_lb *lb,
> > > diff --git a/northd/ovn-northd.8.xml b/northd/ovn-northd.8.xml
> > > index 39f4eaa0c..d219c5618 100644
> > > --- a/northd/ovn-northd.8.xml
> > > +++ b/northd/ovn-northd.8.xml
> > > @@ -1870,14 +1870,14 @@ output;
> > >          A priority 34000 logical flow is added for each logical port
> which
> > >          has DHCPv4 options defined to allow the DHCPv4 reply packet
> and which has
> > >          DHCPv6 options defined to allow the DHCPv6 reply packet from
> the
> > > -        <code>Ingress Table 16: DHCP responses</code>.
> > > +        <code>Ingress Table 18: DHCP responses</code>.
> > >        </li>
> > >
> > >        <li>
> > >          A priority 34000 logical flow is added for each logical
> switch datapath
> > >          configured with DNS records with the match <code>udp.dst =
> 53</code>
> > >          to allow the DNS reply packet from the
> > > -        <code>Ingress Table 18: DNS responses</code>.
> > > +        <code>Ingress Table 20: DNS responses</code>.
> > >        </li>
> > >
> > >        <li>
> > >
> > Acked-by: Mark D. Gray <mark.d.gray@redhat.com>
>
> Thanks.  I applied to the main branch.
>
> Numan
>
> >
> > _______________________________________________
> > dev mailing list
> > dev@openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> >
>
>
diff mbox series

Patch

diff --git a/northd/northd.c b/northd/northd.c
index 32ab3baf3..0bf66e0b2 100644
--- a/northd/northd.c
+++ b/northd/northd.c
@@ -7440,7 +7440,7 @@  build_lswitch_lflows_admission_control(struct ovn_datapath *od,
     }
 }
 
-/* Ingress table 13: ARP/ND responder, skip requests coming from localnet
+/* Ingress table 16: ARP/ND responder, skip requests coming from localnet
  * and vtep ports. (priority 100); see ovn-northd.8.xml for the
  * rationale. */
 
@@ -7682,7 +7682,7 @@  build_lswitch_arp_nd_responder_known_ips(struct ovn_port *op,
     }
 }
 
-/* Ingress table 13: ARP/ND responder, by default goto next.
+/* Ingress table 16: ARP/ND responder, by default goto next.
  * (priority 0)*/
 static void
 build_lswitch_arp_nd_responder_default(struct ovn_datapath *od,
@@ -7693,7 +7693,7 @@  build_lswitch_arp_nd_responder_default(struct ovn_datapath *od,
     }
 }
 
-/* Ingress table 13: ARP/ND responder for service monitor source ip.
+/* Ingress table 16: ARP/ND responder for service monitor source ip.
  * (priority 110)*/
 static void
 build_lswitch_arp_nd_service_monitor(struct ovn_northd_lb *lb,
diff --git a/northd/ovn-northd.8.xml b/northd/ovn-northd.8.xml
index 39f4eaa0c..d219c5618 100644
--- a/northd/ovn-northd.8.xml
+++ b/northd/ovn-northd.8.xml
@@ -1870,14 +1870,14 @@  output;
         A priority 34000 logical flow is added for each logical port which
         has DHCPv4 options defined to allow the DHCPv4 reply packet and which has
         DHCPv6 options defined to allow the DHCPv6 reply packet from the
-        <code>Ingress Table 16: DHCP responses</code>.
+        <code>Ingress Table 18: DHCP responses</code>.
       </li>
 
       <li>
         A priority 34000 logical flow is added for each logical switch datapath
         configured with DNS records with the match <code>udp.dst = 53</code>
         to allow the DNS reply packet from the
-        <code>Ingress Table 18: DNS responses</code>.
+        <code>Ingress Table 20: DNS responses</code>.
       </li>
 
       <li>