From patchwork Sat Sep 18 13:53:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladislav Odintsov X-Patchwork-Id: 1529678 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=i0f+NvOt; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4HBXNw6SqWz9sPf for ; Sat, 18 Sep 2021 23:54:07 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id DD06C42575; Sat, 18 Sep 2021 13:54:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FVuNYSU60bTx; Sat, 18 Sep 2021 13:54:03 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 1483142564; Sat, 18 Sep 2021 13:54:02 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id CD368C000F; Sat, 18 Sep 2021 13:54:01 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6AEEBC000D for ; Sat, 18 Sep 2021 13:54:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 5B30781D47 for ; Sat, 18 Sep 2021 13:54:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V3ZEBb9WcKKi for ; Sat, 18 Sep 2021 13:53:59 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by smtp1.osuosl.org (Postfix) with ESMTPS id 94FC781BD4 for ; Sat, 18 Sep 2021 13:53:59 +0000 (UTC) Received: by mail-lf1-x12d.google.com with SMTP id p29so44488577lfa.11 for ; Sat, 18 Sep 2021 06:53:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BmDkgpK1OK29OqN3nJiB3F0EWD65KDVve9MCFEcD4ZE=; b=i0f+NvOt9ZIomT9wDJDhhaTp0/gI7g4Cd0S2Iv3R0cZqWc8XdoFAnWN3kt4zvc6UUG Uge8wVMzFGSLDJLyizAC5vMA1YeWmuni3taGXrNbGbNdZuLNT5n3K3FmwlWtQZW/9ydr TPpXLtzGU+D2khhUvm9mWuv6rilE9OkgTk3fSdLhoi1ctJoFhdHFzDhNqXPAQkLxHlf2 uGJvNGbkTukNP1gv4ZjCnoHJgcFy1umlo6ss0AKXjXi/631K3Gf5LTJFn57wrn9vORqt iMgInhwu4d47JfXMdMIA6MxuP+mq8IA3lYV5P4853FSKWM/utIv5KW8ao25dO/i8CbBz V0PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BmDkgpK1OK29OqN3nJiB3F0EWD65KDVve9MCFEcD4ZE=; b=drpvXZLlK/UaiT63GhLKuLRb39LbsDrBL2ZW9SAt961N6T2EfaBuK2u6VEWlvJWSN/ XiiARD+RQqgV76WO3XG6ftconbSnBvpl7/JzxuA1oXiKAs/YEYj9ESnqzo/6zjf3puoZ 25OY0w/JdcaYeWqMH4SHhUcTDmWyt4cBP/pZWh/0owc9pcINAbVtG1C/VWKyUPP+GqLx 9U2VWCxKqK51CwJLPtnGvgku8TKNMv1nOgeAau0kDRcoYQy8AeIqyK4MJwkhaj3nv7ra NjJa0swaHR26FJH+rg2Le21rZ8/dO1MwUOMkYiwtvKO663X1SIg9L/5RvAcVJybVB0bh 8HPw== X-Gm-Message-State: AOAM532zvwRA6tfjmXVucgTB19J0zQi3NzVNTapRabjv1lbWOHEdZBoz ESKCK9eh227k+RR0e6l+dvLHRkTJ29E= X-Google-Smtp-Source: ABdhPJywuHwgvI+IhVjx1F5mC4Wr46AoVgL7iL5E/GNmXFveKiuzrmcP8ptXueZCDwwVrf4WeIcImA== X-Received: by 2002:a2e:b6c2:: with SMTP id m2mr2487991ljo.4.1631973237233; Sat, 18 Sep 2021 06:53:57 -0700 (PDT) Received: from localhost.localdomain (109-252-131-59.dynamic.spd-mgts.ru. [109.252.131.59]) by smtp.gmail.com with ESMTPSA id v10sm182580lfd.241.2021.09.18.06.53.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 Sep 2021 06:53:57 -0700 (PDT) From: Vladislav Odintsov To: dev@openvswitch.org Date: Sat, 18 Sep 2021 16:53:55 +0300 Message-Id: <20210918135355.13017-1-odivlad@gmail.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Cc: Vladislav Odintsov Subject: [ovs-dev] [PATCH ovn] spec: add tcpdump to BuildRequires X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" tcpdump is used in tests. When RPM package is built it appropriate test fails if tcpdump package is not installed. This commit fixes this issue by adding a new conditional BuildRequires: tcpdump to specfile. Signed-off-by: Vladislav Odintsov --- rhel/ovn-fedora.spec.in | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/rhel/ovn-fedora.spec.in b/rhel/ovn-fedora.spec.in index 5fe0f990f..1b1ffdd24 100644 --- a/rhel/ovn-fedora.spec.in +++ b/rhel/ovn-fedora.spec.in @@ -36,6 +36,9 @@ Provides: openvswitch-ovn-common = %{?epoch:%{epoch}:}%{version}-%{release} %define ovsver @OVSVERSION@ %define ovsdir openvswitch-%{ovsver} +# to skip running checks, pass --without check +%bcond_without check + # Nearly all of openvswitch is ASL 2.0. The bugtool is LGPLv2+, and the # lib/sflow*.[ch] files are SISSL License: ASL 2.0 and LGPLv2+ and SISSL @@ -56,6 +59,9 @@ BuildRequires: procps-ng %if %{with libcapng} BuildRequires: libcap-ng libcap-ng-devel %endif +%if %{with check} +BuildRequires: tcpdump +%endif BuildRequires: unbound unbound-devel Requires: openssl hostname iproute module-init-tools openvswitch @@ -64,9 +70,6 @@ Requires(post): systemd-units Requires(preun): systemd-units Requires(postun): systemd-units -# to skip running checks, pass --without check -%bcond_without check - %description OVN, the Open Virtual Network, is a system to support virtual network abstraction. OVN complements the existing capabilities of OVS to add