| Message ID | 20210608175232.3019726-1-i.maximets@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] if-status: Fix logging of interface creation. | expand |
On 6/8/21 7:52 PM, Ilya Maximets wrote: > 'iface->id' is NULL at this point, so the message is always the same: > > "Interface (null) create." Oops, thanks for fixing this! > > Fixes: 5c3371922994 ("if-status: Add OVS interface status management module.") > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> > --- Acked-by: Dumitru Ceara <dceara@redhat.com> Regards, Dumitru
On 6/9/21 3:57 AM, Dumitru Ceara wrote: > On 6/8/21 7:52 PM, Ilya Maximets wrote: >> 'iface->id' is NULL at this point, so the message is always the same: >> >> "Interface (null) create." > > Oops, thanks for fixing this! > >> >> Fixes: 5c3371922994 ("if-status: Add OVS interface status management module.") >> Signed-off-by: Ilya Maximets <i.maximets@ovn.org> >> --- > > Acked-by: Dumitru Ceara <dceara@redhat.com> I pushed this to the main branch and branch-21.06 > > Regards, > Dumitru > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
diff --git a/controller/if-status.c b/controller/if-status.c index 8d8c8d436..08fb50b87 100644 --- a/controller/if-status.c +++ b/controller/if-status.c @@ -341,7 +341,7 @@ ovs_iface_create(struct if_status_mgr *mgr, const char *iface_id, { struct ovs_iface *iface = xzalloc(sizeof *iface); - VLOG_DBG("Interface %s create.", iface->id); + VLOG_DBG("Interface %s create.", iface_id); iface->id = xstrdup(iface_id); shash_add(&mgr->ifaces, iface_id, iface); ovs_iface_set_state(mgr, iface, state);
'iface->id' is NULL at this point, so the message is always the same: "Interface (null) create." Fixes: 5c3371922994 ("if-status: Add OVS interface status management module.") Signed-off-by: Ilya Maximets <i.maximets@ovn.org> --- controller/if-status.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)