From patchwork Thu Jan 7 14:19:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Ivanov X-Patchwork-Id: 1423325 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=cambridgegreys.com Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DBSzv5JWfz9sVt for ; Fri, 8 Jan 2021 01:19:55 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id CBCA586AAC; Thu, 7 Jan 2021 14:19:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N7GFZVVufq-t; Thu, 7 Jan 2021 14:19:44 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id BC3AC86A27; Thu, 7 Jan 2021 14:19:36 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A26ABC1DA7; Thu, 7 Jan 2021 14:19:36 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 758A4C013A for ; Thu, 7 Jan 2021 14:19:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 5E570864DF for ; Thu, 7 Jan 2021 14:19:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x+rO+0vC6ak8 for ; Thu, 7 Jan 2021 14:19:33 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from www.kot-begemot.co.uk (ivanoab7.miniserver.com [37.128.132.42]) by whitealder.osuosl.org (Postfix) with ESMTPS id CFD1D86397 for ; Thu, 7 Jan 2021 14:19:32 +0000 (UTC) Received: from tun252.jain.kot-begemot.co.uk ([192.168.18.6] helo=jain.kot-begemot.co.uk) by www.kot-begemot.co.uk with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxW8R-0006l9-F9; Thu, 07 Jan 2021 14:19:31 +0000 Received: from jain.kot-begemot.co.uk ([192.168.3.3]) by jain.kot-begemot.co.uk with esmtp (Exim 4.92) (envelope-from ) id 1kxW8O-0000Qg-Ia; Thu, 07 Jan 2021 14:19:30 +0000 From: anton.ivanov@cambridgegreys.com To: ovs-dev@openvswitch.org Date: Thu, 7 Jan 2021 14:19:21 +0000 Message-Id: <20210107141921.1577-3-anton.ivanov@cambridgegreys.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210107141921.1577-1-anton.ivanov@cambridgegreys.com> References: <20210107141921.1577-1-anton.ivanov@cambridgegreys.com> MIME-Version: 1.0 X-Clacks-Overhead: GNU Terry Pratchett Cc: Anton Ivanov Subject: [ovs-dev] [OVN Patch v9 3/3] ovn-northd: Add configuration option for parallel lflow build X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" From: Anton Ivanov Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 4 +++- ovn-nb.xml | 13 +++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index 8a35ac65d..88f487db7 100644 --- a/northd/ovn-northd.c +++ b/northd/ovn-northd.c @@ -11531,7 +11531,7 @@ noop_callback(struct worker_pool *pool OVS_UNUSED, } -static bool use_parallel_build = true; +static bool use_parallel_build = false; static void build_lswitch_and_lrouter_flows(struct hmap *datapaths, struct hmap *ports, @@ -12748,6 +12748,8 @@ ovnnb_db_run(struct northd_context *ctx, northd_probe_interval_nb = get_probe_interval(ovnnb_db, nb); northd_probe_interval_sb = get_probe_interval(ovnsb_db, nb); + use_parallel_build = smap_get_bool(&nb->options, + "use_parallel_build", false); use_logical_dp_groups = smap_get_bool(&nb->options, "use_logical_dp_groups", false); controller_event_en = smap_get_bool(&nb->options, diff --git a/ovn-nb.xml b/ovn-nb.xml index ec6405ff5..e2f5f6cd1 100644 --- a/ovn-nb.xml +++ b/ovn-nb.xml @@ -212,6 +212,19 @@ The default value is false.

+ +

+ If set to true, ovn-northd will attempt + to compute logical flows in parallel. +

+

+ Parallel computation is enabled only if the system has 4 or more + cores/threads available to be used by ovn-northd. +

+

+ The default value is false. +

+