diff mbox series

[ovs-dev] ovn-trace: Fix the typo from 'lookback' to 'loopback'.

Message ID 20201020061202.1051704-1-numans@ovn.org
State Accepted
Headers show
Series [ovs-dev] ovn-trace: Fix the typo from 'lookback' to 'loopback'. | expand

Commit Message

Numan Siddique Oct. 20, 2020, 6:12 a.m. UTC 
From: Numan Siddique <numans@ovn.org>

Fixes: a60b9a12709b("ovn-trace: Handle IPv6 packets for tcp_reset action.")
Signed-off-by: Numan Siddique <numans@ovn.org>
---
 utilities/ovn-trace.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Dumitru Ceara Oct. 20, 2020, 7:51 a.m. UTC | #1 
On 10/20/20 8:12 AM, numans@ovn.org wrote:
> From: Numan Siddique <numans@ovn.org>
> 
> Fixes: a60b9a12709b("ovn-trace: Handle IPv6 packets for tcp_reset action.")
> Signed-off-by: Numan Siddique <numans@ovn.org>
> ---

Acked-by: Dumitru Ceara <dceara@redhat.com>

Thanks,
Dumitru
Numan Siddique Oct. 20, 2020, 8:32 a.m. UTC | #2 
On Tue, Oct 20, 2020 at 1:21 PM Dumitru Ceara <dceara@redhat.com> wrote:
>
> On 10/20/20 8:12 AM, numans@ovn.org wrote:
> > From: Numan Siddique <numans@ovn.org>
> >
> > Fixes: a60b9a12709b("ovn-trace: Handle IPv6 packets for tcp_reset action.")
> > Signed-off-by: Numan Siddique <numans@ovn.org>
> > ---
>
> Acked-by: Dumitru Ceara <dceara@redhat.com>

Thanks Dumitru. I applied this patch to master.

Numan

>
> Thanks,
> Dumitru
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
diff mbox series

Patch

diff --git a/utilities/ovn-trace.c b/utilities/ovn-trace.c
index 5d54c0fd8b..db5bb301e8 100644
--- a/utilities/ovn-trace.c
+++ b/utilities/ovn-trace.c
@@ -1737,13 +1737,13 @@  static void
 execute_tcp6_reset(const struct ovnact_nest *on,
                    const struct ovntrace_datapath *dp,
                    const struct flow *uflow, uint8_t table_id,
-                   bool lookback, enum ovnact_pipeline pipeline,
+                   bool loopback, enum ovnact_pipeline pipeline,
                    struct ovs_list *super)
 {
     struct flow tcp_flow = *uflow;
 
     /* Update fields for TCP segment. */
-    if (lookback) {
+    if (loopback) {
         tcp_flow.dl_dst = uflow->dl_src;
         tcp_flow.dl_src = uflow->dl_dst;
         tcp_flow.ipv6_dst = uflow->ipv6_src;
@@ -1771,13 +1771,13 @@  static void
 execute_tcp_reset(const struct ovnact_nest *on,
                   const struct ovntrace_datapath *dp,
                   const struct flow *uflow, uint8_t table_id,
-                  bool lookback, enum ovnact_pipeline pipeline,
+                  bool loopback, enum ovnact_pipeline pipeline,
                   struct ovs_list *super)
 {
     if (get_dl_type(uflow) == htons(ETH_TYPE_IP)) {
-        execute_tcp4_reset(on, dp, uflow, table_id, lookback, pipeline, super);
+        execute_tcp4_reset(on, dp, uflow, table_id, loopback, pipeline, super);
     } else {
-        execute_tcp6_reset(on, dp, uflow, table_id, lookback, pipeline, super);
+        execute_tcp6_reset(on, dp, uflow, table_id, loopback, pipeline, super);
     }
 }
 static void