From patchwork Thu Aug 22 14:29:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Bianconi X-Patchwork-Id: 1975576 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=aDGIRWOK; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::133; helo=smtp2.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WqQbL4pWTz1yYZ for ; Fri, 23 Aug 2024 00:30:22 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id D057240EA2; Thu, 22 Aug 2024 14:30:19 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id WjNMCrizUtt0; Thu, 22 Aug 2024 14:30:18 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.9.56; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 02C1B40E89 Authentication-Results: smtp2.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=aDGIRWOK Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id 02C1B40E89; Thu, 22 Aug 2024 14:30:18 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C469AC07E7; Thu, 22 Aug 2024 14:30:17 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 400D9C07E6 for ; Thu, 22 Aug 2024 14:30:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 2E507409EF for ; Thu, 22 Aug 2024 14:30:16 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id bTGp_yEvN0Gh for ; Thu, 22 Aug 2024 14:30:14 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=lorenzo.bianconi@redhat.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org A3A5140789 Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org A3A5140789 Authentication-Results: smtp4.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=aDGIRWOK Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id A3A5140789 for ; Thu, 22 Aug 2024 14:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724337011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hEla98mnYwlUBAzuJ2vcSR7udVd9K5eI1gogRyGerYI=; b=aDGIRWOKYi0PHvFhR7d6/AcJDMw5WAjVETN4IISCRlJkT8U+UKVSctF76wgytkXhWx31I6 L9ZsWhDyu8nTFawKOgGyanLZGHITwPmb4rb8lF5vWXQNLKKfOPL28JTboAk/ltqyX76T7f UjxQRiKaZrCxAv20hNAGYgwu0puGzl0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-563-JJGRLhmuOBKqoXMVTDb04g-1; Thu, 22 Aug 2024 10:30:11 -0400 X-MC-Unique: JJGRLhmuOBKqoXMVTDb04g-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4280cf2be19so6563825e9.3 for ; Thu, 22 Aug 2024 07:30:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724337009; x=1724941809; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hEla98mnYwlUBAzuJ2vcSR7udVd9K5eI1gogRyGerYI=; b=JjE06GMKbf2oeDLVsEKKhgPGHUgvOKVAg0nfQlWREjumBbssOBHRJR7+UFzoVMyvju sWFmCDUtHy3XwGs+CnoqCRcm9k63b5JwLm0gpKy1HeWoIFoI6zp33j4VUUB+iE1W0qyh AybuvTNTIq7Bw3WXCfRHHphP1lFJg4bhmx4NaOUx9GvBxNWLGFWN5xKa0jQd5263vc3v er3iRqJmTipPbn+qhgSHC8zMD3DvoTQEWsGDrM6Yuf13u6WVRLCl2oTxq4qzt5+75Gor ad9sPHqnbq/5Cw4woHezw69YdxkyAEIQPbiO+1P4gSn9t2pJjwiYODc2Ma9S8ZFNXy7R vDcQ== X-Gm-Message-State: AOJu0Yx+69jMUxeza7ReHEr2a68447u45BGUBx6+8WoICd/M8YsFZOA5 N1JzbtkffEyIqSzCoKltWG4aq1DT+PrbsuLJKsu3+g3mb9MtJU0rvrAQmu1go1lKk179eYTG44k fELMNFrmuwVgP5mwuEhDyC11oDbgZ0KZHFXWntUHqiuzagmS+rzEzTacBqXTA2NNNHySfM1sVHp +jKn4o48BdzU9MHoO/qYeWicmlm9tiHTqJEIXzfYdhm8DBqLg2rw== X-Received: by 2002:a05:600c:1c26:b0:426:67ad:38e3 with SMTP id 5b1f17b1804b1-42abd21f62bmr41037865e9.3.1724337009147; Thu, 22 Aug 2024 07:30:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG7vvLFM5NubsMDRBkgJSPabiAg4azidnxHmqPsEhJG65hbO6QW8OI4bRWvhE/TMv61rBQpeA== X-Received: by 2002:a05:600c:1c26:b0:426:67ad:38e3 with SMTP id 5b1f17b1804b1-42abd21f62bmr41037565e9.3.1724337008569; Thu, 22 Aug 2024 07:30:08 -0700 (PDT) Received: from localhost (net-188-152-77-192.cust.dsl.teletu.it. [188.152.77.192]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42abee86df3sm63144445e9.14.2024.08.22.07.30.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2024 07:30:08 -0700 (PDT) From: Lorenzo Bianconi To: ovs-dev@openvswitch.org Date: Thu, 22 Aug 2024 16:29:59 +0200 Message-ID: X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [ovs-dev] [PATCH ovn 0/3] Revert ECMP_Nexthop monitor support X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dceara@redhat.com Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Revert current implementation of ECMP_Nexthop monitor feature since it can trigger over-flush of CT entries committed by incoming traffic. In particular, at the moment there is no way to link the next-hop IP address (so the ct-entry ID) to the incoming traffic identified by the ethernet source mac address and so to the ct_lablel committed by the following logical flow: table=10(lr_in_ecmp_stateful), priority=100 , match=(inport == "R1_ext" && ip4.dst == 10.0.0.0/24 && (ct.new || ct.est)), action=(ct_commit { ct_label.ecmp_reply_eth = eth.src; ct_mark.ecmp_reply_port = 2; ct_label.label = 1; }; next;) Remove the feature while working on an improved approach. Lorenzo Bianconi (3): Revert "ofctrl: Introduce ecmp_nexthop_monitor." Revert "northd: Add nexhop id in ct_label.label." Revert "northd: Introduce ECMP_Nexthop table in SB db." controller/ofctrl.c | 54 ------------------- controller/ofctrl.h | 2 - controller/ovn-controller.c | 2 - lib/ovn-util.h | 2 - northd/en-lflow.c | 3 -- northd/en-northd.c | 35 ------------ northd/en-northd.h | 4 -- northd/inc-proc-northd.c | 8 +-- northd/northd.c | 105 ++++-------------------------------- northd/northd.h | 11 ---- ovn-sb.ovsschema | 18 +------ ovn-sb.xml | 31 ----------- tests/ovn-northd.at | 4 -- tests/ovn.at | 4 +- tests/system-ovn.at | 79 ++++++++++----------------- 15 files changed, 44 insertions(+), 318 deletions(-)