mbox series

[ovs-dev,0/8] Flaky tests fixes and tests cleanup.

Message ID 20240604131042.825909-1-xsimonar@redhat.com
Headers show
Series Flaky tests fixes and tests cleanup. | expand

Message

Xavier Simonart June 4, 2024, 1:10 p.m. UTC 
Xavier Simonart (8):
  tests: Cleanup on_exit commands.
  tests: Fixed "lflow cache operations".
  tests: Fixed flaky "Logical router IP for NAT".
  tests: Fixed flaky "NB_Global and SB_Global I+P".
  tests: Fixed multiple flaky tests.
  tests: Wait for controller exit before restart.
  tests: Fixed flaky "ovn-ic -- AZ register".
  tests: Fix flaky "ovn-controller - restart ...".

 tests/ofproto-macros.at     |  2 +-
 tests/ovn-controller.at     | 51 ++++++++++++++-------------
 tests/ovn-ic.at             |  2 ++
 tests/ovn-macros.at         |  9 +++++
 tests/ovn-northd.at         |  5 +--
 tests/ovn.at                | 70 ++++++++++++++++---------------------
 tests/system-kmod-macros.at |  4 +--
 7 files changed, 74 insertions(+), 69 deletions(-)

Comments

Ales Musil June 10, 2024, 7:03 a.m. UTC | #1 
On Tue, Jun 4, 2024 at 3:11 PM Xavier Simonart <xsimonar@redhat.com> wrote:

> Xavier Simonart (8):
>   tests: Cleanup on_exit commands.
>   tests: Fixed "lflow cache operations".
>   tests: Fixed flaky "Logical router IP for NAT".
>   tests: Fixed flaky "NB_Global and SB_Global I+P".
>   tests: Fixed multiple flaky tests.
>   tests: Wait for controller exit before restart.
>   tests: Fixed flaky "ovn-ic -- AZ register".
>   tests: Fix flaky "ovn-controller - restart ...".
>
>  tests/ofproto-macros.at     |  2 +-
>  tests/ovn-controller.at     | 51 ++++++++++++++-------------
>  tests/ovn-ic.at             |  2 ++
>  tests/ovn-macros.at         |  9 +++++
>  tests/ovn-northd.at         |  5 +--
>  tests/ovn.at                | 70 ++++++++++++++++---------------------
>  tests/system-kmod-macros.at |  4 +--
>  7 files changed, 74 insertions(+), 69 deletions(-)
>
> --
> 2.31.1
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
Looks good to me, thanks.

Acked-by: Ales Musil <amusil@redhat.com>
Numan Siddique June 12, 2024, 2:23 p.m. UTC | #2 
On Mon, Jun 10, 2024 at 3:04 AM Ales Musil <amusil@redhat.com> wrote:
>
> On Tue, Jun 4, 2024 at 3:11 PM Xavier Simonart <xsimonar@redhat.com> wrote:
>
> > Xavier Simonart (8):
> >   tests: Cleanup on_exit commands.
> >   tests: Fixed "lflow cache operations".
> >   tests: Fixed flaky "Logical router IP for NAT".
> >   tests: Fixed flaky "NB_Global and SB_Global I+P".
> >   tests: Fixed multiple flaky tests.
> >   tests: Wait for controller exit before restart.
> >   tests: Fixed flaky "ovn-ic -- AZ register".
> >   tests: Fix flaky "ovn-controller - restart ...".
> >
> >  tests/ofproto-macros.at     |  2 +-
> >  tests/ovn-controller.at     | 51 ++++++++++++++-------------
> >  tests/ovn-ic.at             |  2 ++
> >  tests/ovn-macros.at         |  9 +++++
> >  tests/ovn-northd.at         |  5 +--
> >  tests/ovn.at                | 70 ++++++++++++++++---------------------
> >  tests/system-kmod-macros.at |  4 +--
> >  7 files changed, 74 insertions(+), 69 deletions(-)
> >
> > --
> > 2.31.1
> >
> > _______________________________________________
> > dev mailing list
> > dev@openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> >
> >
> Looks good to me, thanks.
>
> Acked-by: Ales Musil <amusil@redhat.com>

Thanks for fixing the flakes.  I applied all the patches in this
series to main except the patch 6.
Mark has some comments in that patch.

Numan

>
> --
>
> Ales Musil
>
> Senior Software Engineer - OVN Core
>
> Red Hat EMEA <https://www.redhat.com>
>
> amusil@redhat.com
> <https://red.ht/sig>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev