mbox series

[ovs-dev,v2,0/2] FDB entries for localnet should not overwrite entries for vifs

Message ID 20231107080641.2174415-1-xsimonar@redhat.com
Headers show
Series FDB entries for localnet should not overwrite entries for vifs | expand

Message

Xavier Simonart Nov. 7, 2023, 8:06 a.m. UTC 
*** BLURB HERE ***

Xavier Simonart (2):
  controller: FDB entries for localnet should not overwrite entries for
    vifs
  controller: avoid extra flows if localnet_learn_fdb is disabled

 controller/binding.c         |  12 ++
 controller/binding.h         |   3 +
 controller/lflow.c           |  51 +++++-
 controller/lflow.h           |   3 +
 controller/lport.c           |  22 ++-
 controller/lport.h           |   4 +
 controller/ovn-controller.c  |  16 ++
 controller/pinctrl.c         |  31 +++-
 include/ovn/logical-fields.h |   5 +
 lib/logical-fields.c         |   4 +
 northd/northd.c              |   3 +
 northd/ovn-northd.8.xml      |  37 ++++-
 ovn-sb.xml                   |   7 +-
 tests/ovn-northd.at          |   2 +-
 tests/ovn.at                 | 300 +++++++++++++++++++++++++++++++++++
 15 files changed, 473 insertions(+), 27 deletions(-)

Comments

Ales Musil Nov. 21, 2023, 8:49 a.m. UTC | #1 
On Tue, Nov 7, 2023 at 9:07 AM Xavier Simonart <xsimonar@redhat.com> wrote:

> *** BLURB HERE ***
>
> Xavier Simonart (2):
>   controller: FDB entries for localnet should not overwrite entries for
>     vifs
>   controller: avoid extra flows if localnet_learn_fdb is disabled
>
>  controller/binding.c         |  12 ++
>  controller/binding.h         |   3 +
>  controller/lflow.c           |  51 +++++-
>  controller/lflow.h           |   3 +
>  controller/lport.c           |  22 ++-
>  controller/lport.h           |   4 +
>  controller/ovn-controller.c  |  16 ++
>  controller/pinctrl.c         |  31 +++-
>  include/ovn/logical-fields.h |   5 +
>  lib/logical-fields.c         |   4 +
>  northd/northd.c              |   3 +
>  northd/ovn-northd.8.xml      |  37 ++++-
>  ovn-sb.xml                   |   7 +-
>  tests/ovn-northd.at          |   2 +-
>  tests/ovn.at                 | 300 +++++++++++++++++++++++++++++++++++
>  15 files changed, 473 insertions(+), 27 deletions(-)
>
> --
> 2.31.1
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
The series looks good to me, thanks.

Reviewed-by: Ales Musil <amusil@redhat.com>
Dumitru Ceara Nov. 24, 2023, 4:05 p.m. UTC | #2 
On 11/21/23 09:49, Ales Musil wrote:
> On Tue, Nov 7, 2023 at 9:07 AM Xavier Simonart <xsimonar@redhat.com> wrote:
> 
>> *** BLURB HERE ***
>>
>> Xavier Simonart (2):
>>   controller: FDB entries for localnet should not overwrite entries for
>>     vifs
>>   controller: avoid extra flows if localnet_learn_fdb is disabled
>>
>>  controller/binding.c         |  12 ++
>>  controller/binding.h         |   3 +
>>  controller/lflow.c           |  51 +++++-
>>  controller/lflow.h           |   3 +
>>  controller/lport.c           |  22 ++-
>>  controller/lport.h           |   4 +
>>  controller/ovn-controller.c  |  16 ++
>>  controller/pinctrl.c         |  31 +++-
>>  include/ovn/logical-fields.h |   5 +
>>  lib/logical-fields.c         |   4 +
>>  northd/northd.c              |   3 +
>>  northd/ovn-northd.8.xml      |  37 ++++-
>>  ovn-sb.xml                   |   7 +-
>>  tests/ovn-northd.at          |   2 +-
>>  tests/ovn.at                 | 300 +++++++++++++++++++++++++++++++++++
>>  15 files changed, 473 insertions(+), 27 deletions(-)
>>
>> --
>> 2.31.1
>>
>> _______________________________________________
>> dev mailing list
>> dev@openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>>
>>
> The series looks good to me, thanks.
> 
> Reviewed-by: Ales Musil <amusil@redhat.com>
> 

Thanks, Xavier and Ales!  I applied this to main and backported it to
all stable branches down to (and including) 22.09.

Regards,
Dumitru