From patchwork Mon Oct 19 07:26:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Numan Siddique X-Patchwork-Id: 1384014 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ovn.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CF7cC1qXzz9sS8 for ; Mon, 19 Oct 2020 18:26:50 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id EEE4D271D7; Mon, 19 Oct 2020 07:26:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZslrSDM11ayZ; Mon, 19 Oct 2020 07:26:45 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 0158C2001C; Mon, 19 Oct 2020 07:26:44 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id D5C39C0891; Mon, 19 Oct 2020 07:26:44 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 75964C0052 for ; Mon, 19 Oct 2020 07:26:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 5860320357 for ; Mon, 19 Oct 2020 07:26:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WX0ECBvoodyT for ; Mon, 19 Oct 2020 07:26:42 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by silver.osuosl.org (Postfix) with ESMTPS id 8C9082001C for ; Mon, 19 Oct 2020 07:26:40 +0000 (UTC) X-Originating-IP: 27.7.102.201 Received: from nusiddiq.home.org.com (unknown [27.7.102.201]) (Authenticated sender: numans@ovn.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id AAB85E0010; Mon, 19 Oct 2020 07:26:36 +0000 (UTC) From: numans@ovn.org To: dev@openvswitch.org Date: Mon, 19 Oct 2020 12:56:27 +0530 Message-Id: <20201019072627.279917-1-numans@ovn.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Subject: [ovs-dev] [PATCH ovn v3 0/3] Optimize logical flow generation for reject ACLs. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" From: Numan Siddique This patch series improves the reject ACL logical flow generation by reducing the number of logical flows for the reject ACL. A new OVN action - reject is added for this. Now only 1 lflow is added per each reject ACL. v2 -> v3 ---- * Dropped the patch 2 of v2 from the series as per the review comments and discussions. Patch 1 of v3 now swaps the IP src with IP dst and Eth src with Eth destination in the reject action itself. * Added a new patch 'p3' to the series which adds IPv6 support to execute_tcp_reset() in ovn-trace which was missing earlier as reported by Dumitru. v1 -> v2 ------ * Patch 1 and 2 of v1 are merged. * Adddressed the review comment from Mark in patch 2 to return if there is any parse error while parsing OVN fields. Numan Siddique (3): actions: Add a new OVN action - reject {}. ovn-northd: Optimize logical flow generation for reject ACLs. ovn-trace: Handle IPv6 packets for tcp_reset action. controller/pinctrl.c | 64 +++++++++---- include/ovn/actions.h | 9 +- lib/actions.c | 22 +++++ northd/ovn-northd.c | 50 +--------- ovn-sb.xml | 16 ++++ tests/ovn-northd.at | 214 +++++++----------------------------------- tests/ovn.at | 12 +++ tests/system-ovn.at | 46 ++++++++- utilities/ovn-trace.c | 141 +++++++++++++++++++++++----- 9 files changed, 303 insertions(+), 271 deletions(-)