diff mbox series

[2/2] ramips: mt7621-dts: we420223-99: mux phy0->gmac1

Message ID mailman.7995.1660559797.4154159.openwrt-devel@lists.openwrt.org
State New
Headers show
Series [1/2] ramips: mt7621: Add Arcadyan WE420223-99 support | expand

Commit Message

Harm Berntsen Aug. 15, 2022, 10:30 a.m. UTC
The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.

To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.
This gives each port an individual link to the CPU. The advantage of
this is that it can now route packets faster between the ports (before
the CPU only had a single 1Gb link to the switch that has to be shared
between both ports. Another advantage is that in Linux 5.10 you can now
bridge a VLAN to a non-vlan port. Without this patch, you're not getting
any data across the bridge. That is fixed in Linux 5.15 but is still
handled by the CPU in any case. So therefore this patch is advantageous
in all cases except for when you need the device as a simple switch
without VLANs. For that case it's better to revert this and the switch
hardware will forward traffic without bothering the CPU.

Signed-off-by: Harm Berntsen <git@harmberntsen.nl>
---
 .../ramips/dts/mt7621_arcadyan_we420223-99.dts   | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

Comments

Thibaut VARÈNE Aug. 15, 2022, 12:24 p.m. UTC | #1
Hi,

> Le 15 août 2022 à 12:30, Harm Berntsen via openwrt-devel <openwrt-devel@lists.openwrt.org> a écrit :
> 
> The sender domain has a DMARC Reject/Quarantine policy which disallows
> sending mailing list messages using the original "From" header.
> 
> To mitigate this problem, the original message has been wrapped
> automatically by the mailing list software.
> De: Harm Berntsen <git@harmberntsen.nl>
> Objet: [PATCH 2/2] ramips: mt7621-dts: we420223-99: mux phy0->gmac1
> Date: 15 août 2022 à 12:30:39 UTC+2
> À: openwrt-devel@lists.openwrt.org
> Cc: Harm Berntsen <git@harmberntsen.nl>
> 
> 
> This gives each port an individual link to the CPU. The advantage of
> this is that it can now route packets faster between the ports (before
> the CPU only had a single 1Gb link to the switch that has to be shared
> between both ports. Another advantage is that in Linux 5.10 you can now
> bridge a VLAN to a non-vlan port. Without this patch, you're not getting
> any data across the bridge. That is fixed in Linux 5.15 but is still
> handled by the CPU in any case. So therefore this patch is advantageous
> in all cases except for when you need the device as a simple switch
> without VLANs. For that case it's better to revert this and the switch
> hardware will forward traffic without bothering the CPU.

FYI there’s currently an ongoing PR that aims to do this on a broader scale:
https://github.com/openwrt/openwrt/pull/10238

HTH
diff mbox series

Patch

diff --git a/target/linux/ramips/dts/mt7621_arcadyan_we420223-99.dts b/target/linux/ramips/dts/mt7621_arcadyan_we420223-99.dts
index f68d79af15..88e823e382 100644
--- a/target/linux/ramips/dts/mt7621_arcadyan_we420223-99.dts
+++ b/target/linux/ramips/dts/mt7621_arcadyan_we420223-99.dts
@@ -188,16 +188,24 @@ 
 
 &switch0 {
 	ports {
-		port@0 {
-			status = "okay";
-		};
-
 		port@1 {
 			status = "okay";
 		};
 	};
 };
 
+&gmac1 {
+	status = "okay";
+	label = "lan0";
+	phy-handle = <&ethphy0>;
+};
+
+&mdio {
+	ethphy0: ethernet-phy@0 {
+		reg = <0>;
+	};
+};
+
 &pcie {
 	status = "okay";
 };