diff mbox series

[2/2] scripts/feeds: force kernel package scan after a target installation

Message ID mailman.115095.1726741692.1280.openwrt-devel@lists.openwrt.org
State Superseded
Delegated to: Hauke Mehrtens
Headers show
Series Fix the installation of linux kernel module packages from a feed | expand

Commit Message

Thomas Richard Sept. 19, 2024, 10:27 a.m. UTC
The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.

To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.
When a target is installed from a feed, the linux kernel package is scanned
before the installation of this target.
If some kernel module packages are defined in this feeds at the target
level, there were not parsed during the scan of linux kernel package, as
the target didn't exist yet. So these kernel module packages don't exist.

Once the target is installed, clean the linux kernel packageinfo to force
the scan of the linux kernel package next time this script (or the make
command) is called.

Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
---
 scripts/feeds | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Andrey Jr. Melnikov Sept. 19, 2024, 11:01 a.m. UTC | #1
Thomas Richard via openwrt-devel <openwrt-devel@lists.openwrt.org> wrote:

[...]

> diff --git a/scripts/feeds b/scripts/feeds
> index 7cbe07f58e..a48be670f0 100755
> --- a/scripts/feeds
> +++ b/scripts/feeds
> @@ -461,6 +461,11 @@ sub do_install_target($) {
>                 return 1;
>         }
>  
> +       # Clean packageinfo of linux kernel to force the scan.
> +       # Otherwise kernel modules defined at target level are not scanned, as the
> +       # linux kernel package was scanned before the installation of the target.
> +	  system("rm tmp/info/.packageinfo-kernel_linux");
Why spawn shell with rm? Use 'unlink "tmp/info/.packageinfo-kernel_linux";' here.
diff mbox series

Patch

diff --git a/scripts/feeds b/scripts/feeds
index 7cbe07f58e..a48be670f0 100755
--- a/scripts/feeds
+++ b/scripts/feeds
@@ -461,6 +461,11 @@  sub do_install_target($) {
 		return 1;
 	}
 
+	# Clean packageinfo of linux kernel to force the scan.
+	# Otherwise kernel modules defined at target level are not scanned, as the
+	# linux kernel package was scanned before the installation of the target.
+	system("rm tmp/info/.packageinfo-kernel_linux");
+
 	return 0;
 }