From patchwork Thu Oct 6 20:56:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sander Vanheule X-Patchwork-Id: 1687195 X-Patchwork-Delegate: sander@svanheule.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=NK9CM3Xf; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=svanheule.net header.i=@svanheule.net header.a=rsa-sha256 header.s=mail1707 header.b=FuUAiCws; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Mk3lL3d7pz1yqk for ; Fri, 7 Oct 2022 08:01:34 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8dazyNFojALpDxFMDJZBCxqhTSO5/4usQvhQrRVS4+w=; b=NK9CM3XfxCfkD0 Q4+AlOApPtI8JTW47P32t3irstgY8CkXvVJpsS7RxLWQFliUxEG3td8kBKeUKr6z3RtjbIIq+bAMR dLBtn83VyjvgMxt/2HxU1tsuNlQTRjfA9lFDJh2BQLl/pEQ3h2R4Ur3GHX/fSIA5v2Y+0tL6XO1Y1 0Q8gqnWfh12eszqSqzs6KAdhTbXxoTmdbF6Pti/8p4tJuMWwPz1ToUmH5kCk8wq+mYWia2xbcqRS4 LdGvMFNFL5usqMK5e+TNQCBNcEJGMbJa8VEgRCnsWAu0tSAwlkhdRf66I7DFCTqCBAAFcl7P6swA/ esuD256nNM2umkufjy2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ogXxR-005BhN-GL; Thu, 06 Oct 2022 20:59:06 +0000 Received: from polaris.svanheule.net ([84.16.241.116]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ogXvL-005Avw-Lj for openwrt-devel@lists.openwrt.org; Thu, 06 Oct 2022 20:56:57 +0000 Received: from terra.. (247.72-129-109.adsl-dyn.isp.belgacom.be [109.129.72.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sander@svanheule.net) by polaris.svanheule.net (Postfix) with ESMTPSA id 30F3232CD29; Thu, 6 Oct 2022 22:56:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svanheule.net; s=mail1707; t=1665089801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ltpw4v/CvUeb0LzreWe03XyQkxfhj5Em+BArkxy2rmU=; b=FuUAiCws1jKEZgvKfluuQe/txqBKrUJ6Guiaf8oTki0s+L2USqrly1uYWIqXpzRA8kHKr5 XE1wPr/n3+LBNaeNZOTJwmIayA+eVL6ruZ/A2j7bLlPMtrtYRrqWh7PS198ly9uYRVtTyp UAEWMCnlIL50uh0S+6Ggixr2WkYIAxyCWsazIZJkZJNFoOvbRQsUCcVaYhRcKXN4TRGoCH gM3VBqosyA8XpsYzGkrYlPII15RZVmIIRXXsGaQcj3DERgAdDt5MFUQrcrffFhqjgzM8KZ TXBYS1YnMy/+v6Z3GfHvs94Tb5u/zMN+06wLimqpwCBvlHmal2l0wjxaqQcgTA== From: Sander Vanheule To: openwrt-devel@lists.openwrt.org Cc: Sander Vanheule , INAGAKI Hiroshi Subject: [PATCH 6/8] realtek: fix place of fdb/mdb info messages Date: Thu, 6 Oct 2022 22:56:31 +0200 Message-Id: X-Mailer: git-send-email 2.37.3 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221006_135655_901876_860D455C X-CRM114-Status: UNSURE ( 8.12 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.5 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: INAGAKI Hiroshi Those messages should be printed when entry was found (idx >= 0). Move them to the right place to not print invalid entry indices. Signed-off-by: INAGAKI Hiroshi [amden commit message] Signed-off-by: Sander Vanheule --- target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/dsa.c [...] Content analysis details: (-2.5 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [84.16.241.116 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org From: INAGAKI Hiroshi Those messages should be printed when entry was found (idx >= 0). Move them to the right place to not print invalid entry indices. Signed-off-by: INAGAKI Hiroshi [amden commit message] Signed-off-by: Sander Vanheule --- target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/dsa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/dsa.c b/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/dsa.c index f54fdd298ac4..f08ede730b83 100644 --- a/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/dsa.c +++ b/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/dsa.c @@ -1689,8 +1689,8 @@ static int rtl83xx_port_fdb_del(struct dsa_switch *ds, int port, idx = rtl83xx_find_l2_hash_entry(priv, seed, true, &e); - pr_info("Found entry index %d, key %d and bucket %d\n", idx, idx >> 2, idx & 3); if (idx >= 0) { + pr_info("Found entry index %d, key %d and bucket %d\n", idx, idx >> 2, idx & 3); e.valid = false; dump_l2_entry(&e); priv->r->write_l2_entry_using_hash(idx >> 2, idx & 0x3, &e); @@ -1870,8 +1870,8 @@ int rtl83xx_port_mdb_del(struct dsa_switch *ds, int port, idx = rtl83xx_find_l2_hash_entry(priv, seed, true, &e); - pr_debug("Found entry index %d, key %d and bucket %d\n", idx, idx >> 2, idx & 3); if (idx >= 0) { + pr_debug("Found entry index %d, key %d and bucket %d\n", idx, idx >> 2, idx & 3); portmask = rtl83xx_mc_group_del_port(priv, e.mc_portmask_index, port); if (!portmask) { e.valid = false;