From patchwork Sat Jan 13 10:28:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: e9hack X-Patchwork-Id: 1886339 X-Patchwork-Delegate: ynezz@true.cz Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=aOMAD4Wx; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=JGQnWj5C; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TBw6s4Zgnz1yP3 for ; Sat, 13 Jan 2024 21:45:55 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:From:MIME-Version:Date:Message-ID: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=xJz2Qb0WuxmhkOFPaw6mbDwpLYzTudKibR2dMpYkM94=; b=aOMAD4WxIpKLsf lC8kU4C5mcwgcV5qFYA83TvFpkfkm7T0gvY1terAM8BdrNf9NiHbbdWUFBeS49/mOjrXWdXsRmZIS Vcey+hXeHdCOLPan0vIZukUY0ilQI5QLDvV4Et5BvSiltPagOvDN/RiBN6wggmGFrZdxIjpv/hnxG krZU6AXoMR1xFodS3Y6vDuYt75nPS0EO27Q7aIPasgBftzlIaC4uxLWopKEiMmpwTfuLnEVul27A0 ypVX7U7t8Jpe6+hWb/12VwEt6KkVz4LOexVJicBlLgNR0ybSExlMRxOeAIK5Fz0qHe3mm9009TZT7 3ynUI9NoS3LUBeUF7dgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rObGB-004uJf-2V; Sat, 13 Jan 2024 10:29:03 +0000 Received: from mail-io1-xd34.google.com ([2607:f8b0:4864:20::d34]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rObG7-004uIP-2o for openwrt-devel@lists.openwrt.org; Sat, 13 Jan 2024 10:29:01 +0000 Received: by mail-io1-xd34.google.com with SMTP id ca18e2360f4ac-7bed8faf6ebso199932539f.2 for ; Sat, 13 Jan 2024 02:28:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705141737; x=1705746537; darn=lists.openwrt.org; h=content-transfer-encoding:to:subject:from:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=sark8H6EZWPaJfd52BQVFbjNE9hSSYVW4Dr7xDZBk+k=; b=JGQnWj5CU71gp+SDMeuoT6txdmMHTZEGedOhr36xbA1Ksf6DuhmYYB/Lyfrt5A/X3z Xj3KF8+Y1Nco7Y2iY+j/MzuCjTmqbSqP6PJJTqw9Od6DlZ2ouoA6ocZhSjBccwiGfjdR JEBXEcw85HTTv9DNSOrpkowxMGyo0y8LDf1X/GUYXuu3IMdatjXtpYWF7Y/ecRsW7kCi vpxKgOrsVLhkxGV2M77xg8+INMYoMxWmfeJ/xVSzy/MM7HIJFdeQN153/VGeeqzZb3Lp Ec6zFJi8gACgoh9h9Q1R4N3K67O873vId2euyVZWF3dKfCqyRHe5AIyQkcf8Ca6f+Mzq dFdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705141737; x=1705746537; h=content-transfer-encoding:to:subject:from:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sark8H6EZWPaJfd52BQVFbjNE9hSSYVW4Dr7xDZBk+k=; b=lDulvL96rnrFDFvOLRDhseeqo0C8O2FO2JuHr3+UfvueKxZ49ofWjoqqfpqWxWcCJf 83sorauiU89Md1RJ3wCqEWEWM1wrcD6CF/wRZAO0HZwji4jwCDCTXHS8/+rX331gBxTq 3ZQTaJHp4x55/zwQvtcIZRSlhUQNFtV1/OTAeLSKEybzhtQdv+Ge0lgXIdFLndS5hgcx 90e+Ee+E2xZ66/CwJnS1ksd4IWkOVLXsJWY5UcElJc9iH2jQH3j5BijU+PF9iw61Oasm Engug1W2RUugI33GD/MNuMWjXCUUdv+Vf8Ugeq55tOXx331JWs0Z1zLFgOsN5lMS5Plg dgBQ== X-Gm-Message-State: AOJu0YzcgMKlo67an8ughf55jlKnD2FJ0UVLIDzQ7T95jIlm8ESn0zkx VWwbQpWbPZcrsM368BBUGYFqRoHWTUM= X-Google-Smtp-Source: AGHT+IFp4wpPKIk1ODluf4gYO+0+orclEXMyzQkAWm1pS1AAMPeU8ELxQdxo7BjvhzWMKlrhvt7HqQ== X-Received: by 2002:a5e:cb0d:0:b0:7bb:a5e9:472d with SMTP id p13-20020a5ecb0d000000b007bba5e9472dmr3178247iom.1.1705141736771; Sat, 13 Jan 2024 02:28:56 -0800 (PST) Received: from localhost (p200300f6670aaeac8424168c9f6a10b3.dip0.t-ipconnect.de. [2003:f6:670a:aeac:8424:168c:9f6a:10b3]) by smtp.gmail.com with ESMTPSA id ku15-20020a170903288f00b001d3b258e04bsm4588398plb.248.2024.01.13.02.28.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Jan 2024 02:28:55 -0800 (PST) Message-ID: Date: Sat, 13 Jan 2024 11:28:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB, de-DE From: e9hack Subject: hostapd crash To: openwrt-devel@lists.openwrt.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240113_022859_942384_8CCCEC74 X-CRM114-Status: UNSURE ( 7.27 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, I did add one more AP to my wifi config for testing. This results in hostapd not starting for this device: Thu Jan 11 13:59:12 2024 daemon.notice hostapd: Exception in ubus function: left-hand side expression is null In __iface_pending_next(), file /usr/share/hostap/hostapd.uc, line 165, byte 73: called fr [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:d34 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [e9hack[at]gmail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Hi, I did add one more AP to my wifi config for testing. This results in hostapd not starting for this device: Thu Jan 11 13:59:12 2024 daemon.notice hostapd: Exception in ubus function: left-hand side expression is null In __iface_pending_next(), file /usr/share/hostap/hostapd.uc, line 165, byte 73: called from function iface_pending_next (/usr/share/hostap/hostapd.uc:181:73) called from function iface_pending_init (/usr/share/hostap/hostapd.uc:222:15) called from function iface_restart (/usr/share/hostap/hostapd.uc:249:35) called from function iface_set_config (/usr/share/hostap/hostapd.uc:620:52) called from function [anonymous function] (/usr/share/hostap/hostapd.uc:827:32) called from anonymous function (/usr/share/hostap/hostapd.uc:710:22) ` hostapd.printf(`hostapd.add_iface failed for phy ${phy} ifname=${bss.ifname}`);` Near here -----------------------------------------------------------------------^ Thu Jan 11 13:59:12 2024 daemon.notice netifd: radio1 (405): Command failed: ubus call hostapd config_set { "phy": "phy1", "config":"/var/run/hostapd-phy1.conf", "prev_config": "/var/run/hostapd-phy1.conf.prev"} (Unknown error) My hostapd.uc is modified. The affected line number does have an offset by 1 related to the original file: The error doesn't appear when I remove a AP. It doesn't matter which one I remove. Is there somewhere a buffer to small? Regards, Hartmut diff --git a/package/network/services/hostapd/files/hostapd.uc b/package/network/services/hostapd/files/hostapd.uc index 0c89cd71cc..66e4e2353e 100644 --- a/package/network/services/hostapd/files/hostapd.uc +++ b/package/network/services/hostapd/files/hostapd.uc @@ -20,6 +20,7 @@ hostapd.data.file_fields = { private_key2: true, dh_file: true, eap_sim_db: true, + crl_file: true, }; function iface_remove(cfg)