From patchwork Tue Jul 7 19:04:45 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aleksandr Kolesnik X-Patchwork-Id: 492574 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from arrakis.dune.hu (arrakis.dune.hu [78.24.191.176]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 27ACB1402B4 for ; Wed, 8 Jul 2015 05:05:08 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=Bc7s4XHB; dkim-atps=neutral Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 7E77428AE04; Tue, 7 Jul 2015 21:04:40 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on arrakis.dune.hu X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id E790828BDF9 for ; Tue, 7 Jul 2015 21:04:28 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 CL_IP_EQ_HELO_IP=-2 (check from: .gmail. - helo: .mail-wi0-f177.google. - helo-domain: .google.) FROM/MX_MATCHES_HELO(DOMAIN)=-2; rate: -8.5 Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by arrakis.dune.hu (Postfix) with ESMTPS for ; Tue, 7 Jul 2015 21:04:28 +0200 (CEST) Received: by wiga1 with SMTP id a1so265330839wig.0 for ; Tue, 07 Jul 2015 12:04:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=uxBfPI2nd7mw8qIija8xjmI9kKZz3HXIpaIP7NrNw7o=; b=Bc7s4XHBuivoqy148VGA3poRjR4uBjSTmDXDEh/GiUUOobucvIw1K9ooNtoWCuxMEc NLFxIty+m+RqyBSICwxcAM3greRAJE+XMxmVKkT1L9q7GNmge5qNGDElVygixM0u5bZk HZkq1XM5kjcmYMUE6FwlYKx1BH2au71LWipi+lLT3z6Wi8ShS2XMRW2bLT/1ABc/DYj9 yDXFV4EYF4mVs9BviIdIN8sd5Sbgm8U7XqudKhWFP1h/nZxZ71gPLXmyePWGsj8yYzxa 6LjIRXVeA7zZaFJPWfxLhcOzKNMBRVySPLtHvgZQvTUEXqgJwckA+M+GALldRIhEBdUI ylhw== MIME-Version: 1.0 X-Received: by 10.180.73.145 with SMTP id l17mr68444452wiv.39.1436295885480; Tue, 07 Jul 2015 12:04:45 -0700 (PDT) Received: by 10.28.171.86 with HTTP; Tue, 7 Jul 2015 12:04:45 -0700 (PDT) In-Reply-To: <559BC00F.6010904@openwrt.org> References: <559BC00F.6010904@openwrt.org> Date: Tue, 7 Jul 2015 22:04:45 +0300 Message-ID: From: Aleksandr Kolesnik To: John Crispin Cc: OpenWrt Development List Subject: Re: [OpenWrt-Devel] [PATCH v2] ncm: add support to run via proto wwan X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openwrt-devel-bounces@lists.openwrt.org Sender: "openwrt-devel" Hi, Is it OK now? Signed-off-by: Aleksandr Kolesnik 2015-07-07 15:03 GMT+03:00 John Crispin : > Hi, > > patch is generated against the wrong root folder. also your mail client > replaced tabs with spaces. please fix and resend the patch > > John > > On 22/04/2015 15:26, Aleksandr Kolesnik wrote: > > Signed-off-by: Aleksandr Kolesnik > > > > > > --- package/network/utils/comgt/files/ncm.sh > > +++ package/network/utils/comgt/files/ncm.sh > > @@ -27,6 +27,8 @@ proto_ncm_setup() { > > local device apn auth username password pincode delay mode > > json_get_vars device apn auth username password pincode delay mode > > > > +[ -n "$ctl_device" ] && device=$ctl_device > > + > > [ -n "$device" ] || { > > echo "No control device specified" > > proto_notify_error "$interface" NO_DEVICE > > > > > > _______________________________________________ > > openwrt-devel mailing list > > openwrt-devel@lists.openwrt.org > > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel > > > --- a/package/network/utils/comgt/files/ncm.sh +++ b/package/network/utils/comgt/files/ncm.sh @@ -27,6 +27,8 @@ proto_ncm_setup() { local device apn auth username password pincode delay mode json_get_vars device apn auth username password pincode delay mode + [ -n "$ctl_device" ] && device=$ctl_device + [ -n "$device" ] || { echo "No control device specified" proto_notify_error "$interface" NO_DEVICE