From patchwork Fri Nov 10 13:28:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Catrinel Catrinescu X-Patchwork-Id: 1862411 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=vG6x2W3Y; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=catrinescu.onmicrosoft.com header.i=@catrinescu.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-catrinescu-onmicrosoft-com header.b=V1asccC5; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SRfpZ52jsz1yQl for ; Sat, 11 Nov 2023 00:30:46 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yK+W5fW/Cw1ylYBiO18iR28NIfMqeLqFuq7KmQ+EFvY=; b=vG6x2W3YfWasXR 0vbiS5/kc7h0BjX7cbkfEcfLI0ndfHocqhNkLVm4RyR0zh51MIvLnR7EWRuCDfNYFPnTRs/HdWNLb lLjJYmLf+z58ClkYY6UmpkXO4ZPfcAWwYsZapQzRayY7tL94A4FnyudoHalLNdFGnGd3WZnCVsnhn /IX8mx3I1tfz6qOMbsYZtXx+CI4b6YGDb7yIYo5aKUbEARvD/XbTaV1rAmDB044vuYr5HLfpg3nxL iUs/pPPoYuzxPRIozs1ES/yI9FPYw49Be2BqtdsJC8e0BFscnBbBeVZw4Vl+dBhdeE/OSi/EB725T 3YO1vd8FvXBOO195zq+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r1RZA-008qnJ-2M; Fri, 10 Nov 2023 13:28:56 +0000 Received: from mail-dbaeur03on20609.outbound.protection.outlook.com ([2a01:111:f400:fe1a::609] helo=EUR03-DBA-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r1RZ6-008qmF-24 for openwrt-devel@lists.openwrt.org; Fri, 10 Nov 2023 13:28:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ez+w6Q0VPRO669HIlrhMT/huLmWjLxOGEDnMTsd5fytpu/i//JXuCICyxcd+i0qxGfnu6YaXO17A+zoJN6X9TWnSfXmOoNva2qZYTYLsmmKyJrL7hB8pL1kIiIshhNsDSNUXIW1tj2sMKmbBpYon/5UeR6H/tCekizi6HUbjJy8cYPdpL96UI2hLYS++frv1PpvmGKpbhB2HqiYwBHpqMgKCQZPadu8Xf1BXlhFjRFiC6bomqvtu0dcFJPWTllmSaVBonbdoUBeSdhhGL08bhgAmL48QqII8PxxDiE10UIAE5chCrfs4OoKzLz2rdC6VMAqjNOYU2GyEMb1tfnG0DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B8KMCX6AM3s4cZYDsleqMKxJUtidMSW0yNIDL0dDROs=; b=EQfWOlCqerrkfP8+dcmt2DkIeY7y9QriDa5Onh0ioshAA99oVEROF+4T3sM4LUZ1fzMDXUTVZo1Vhx9SUtf1ac+NyHxIGDbMqwc3Z0LcZNa5jTRlwdNZumIAkUV8mKjZVFoHGWabyewMIM3LCZ0fXFXIWfCJpoOuCvkVs79eDofxn+1rf3EjDRQ3qVvrRfI/Xeo+qGFulmbAlwPF1aGsHtV1uTvvuy8cVUUk+E+rE3fP8pcRb8EGonPRlE5s3BhvdK7CvySjfnz0+TfE94sirRwKuQxNlavgpwvAIGzWlnyajZG9y8Ip8HB3u9FImpqNI/fSSa+IgpaI51mpek7RqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=80211.de; dmarc=pass action=none header.from=80211.de; dkim=pass header.d=80211.de; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catrinescu.onmicrosoft.com; s=selector2-catrinescu-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B8KMCX6AM3s4cZYDsleqMKxJUtidMSW0yNIDL0dDROs=; b=V1asccC548ivd6K5sUOJKjsmEZL6iQjAdAJorKK24GQrWtYR3RcoXU3L+vVlmxbpQTvkJm6LPYtERuN7JmhBMwWZBWtQ8Pu3cLMaGva67X+MBhGAzTxj1y5pXGAMxqNZ3kCc8i96PwxN1stjLSXQdXnQ+IzWmnf/DRB0EdT++Cs= Received: from AM6PR03MB3832.eurprd03.prod.outlook.com (2603:10a6:20b:18::33) by AS8PR03MB8926.eurprd03.prod.outlook.com (2603:10a6:20b:5c2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.29; Fri, 10 Nov 2023 13:28:44 +0000 Received: from AM6PR03MB3832.eurprd03.prod.outlook.com ([fe80::88b7:2595:28d8:d992]) by AM6PR03MB3832.eurprd03.prod.outlook.com ([fe80::88b7:2595:28d8:d992%2]) with mapi id 15.20.6954.029; Fri, 10 Nov 2023 13:28:44 +0000 From: Catrinel Catrinescu To: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , "openwrt-devel@lists.openwrt.org" CC: "yangshiji66@outlook.com" , Hauke Mehrtens , =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , Ansuel Smith , Felix Fietkau , Reiner Rusnak Subject: Approved RE: [PATCH] ath79: use "fixed-layout" for Embedded Wireless devices Thread-Topic: Approved RE: [PATCH] ath79: use "fixed-layout" for Embedded Wireless devices Thread-Index: AQHaE8AxjaadpEn5hEyNs1FNL7b/rrBzjCUQ Date: Fri, 10 Nov 2023 13:28:44 +0000 Message-ID: References: <20231110102505.24322-1-zajec5@gmail.com> In-Reply-To: <20231110102505.24322-1-zajec5@gmail.com> Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=80211.de; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM6PR03MB3832:EE_|AS8PR03MB8926:EE_ x-ms-office365-filtering-correlation-id: 5f42ae0b-a476-4eb1-f4ac-08dbe1f0f65e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iVHIcd3fEyHIEPCUmYZupaA+65Icz6iD6QQd2MK39mjYW9yPMiSx6YU65QiF4Cyumdm8IH3Z/hHRmMy1LZH4zHySf0fEfbQHWfEOKj/J7/3U54OBVWZsJmKhfgcY6pVaI29/Em6zB+RhxDY765rcuImUtUXE6KtiezPW3yjBJIoY8BldPIxp+bbqdtvThqIfBxH65KDXwVq6ODuGCuOzMM2YljF7etteYX3+YxcCApBKpje64kB5ThKrjiGB2vgiXgRYqtUSpHH9fp1XntI8bnhN6nngNYvueXL7rMyg3Qg+DPsvZH7PUO0AwSk3qywboQLdJp00/mqs3Z1BS7dVMyMOTDJYc3rQE9v2iIFt6+/Dmf4S8EKb+jXObT47+0ONvx3DoN/OuOLF4wYcMe7pBGVe7a6d0rsC+3Pxyrl/nU4p5E6wPHzLsC9btR5gfvP628s3zTCTWGjJbQNgsBphGnndhPKotbx1icWrxO8inyNxtUxwVIKTWC7Nn+atLTnhi6Y+rQCSTCQUokRL9E+KTPfQUnNQiyyHyl6wWrxcdM22/HrA+tMD1xgvCf9YB3IkxWalhRNTKXkKRKBA0UqkkCJf5+iqxw8P23ha8s3oq0WekmyUhdS/73SGwMvVCqHv x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR03MB3832.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(39830400003)(136003)(376002)(346002)(396003)(230922051799003)(64100799003)(451199024)(186009)(1800799009)(55016003)(71200400001)(478600001)(2906002)(38070700009)(122000001)(86362001)(83380400001)(38100700002)(64756008)(66946007)(66476007)(9686003)(8936002)(316002)(4326008)(54906003)(107886003)(53546011)(7696005)(66446008)(76116006)(66556008)(110136005)(41300700001)(5660300002)(33656002)(45080400002)(6506007)(52536014)(8676002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?r2R13vMv3QjSAPF/Be3ccvJzujBR?= =?utf-8?q?1NImGkrel4XVAsfLowR9MgH7zEs6eszEkv0iS/Mw7g8x3x5djAVi6ack/CLzP4wMb?= =?utf-8?q?+atJ63WEBhoWmjI1exKbUXe462aoMDVGmIheSE8/+kSullim3BJwZRv8f4+jiP2wh?= =?utf-8?q?DxYHJipXu5X98h/f58dGrK8oEjMJh3NS6hBFio9yv27J7K8Ceky1LJkhLP4pspLlY?= =?utf-8?q?GKzkAsyrCHWLQoT3F1yeIxauJVdvHfexAFmvDp8wu3OKOva+mJRmEqwfM05rxX0N4?= =?utf-8?q?QdKnynBz5bphfmD5gpCfXLYa9CW0SIMOOPIerU8UPuUz9DTvHN+Vbgg0vQQ+gk2ai?= =?utf-8?q?BQiNjLKjpOqZ0IJIHWH+FrM4JDYyhn6jw5nf/oxViDFdsjYxoWJEXrBaOKEOrBSww?= =?utf-8?q?2549ufnmchhitbQv+Jq0VMa8LMJOu80SCpXao77T8FTgWkeJfTmblJ/88AOuChzpg?= =?utf-8?q?5RiB/zymiv+kdQOkrPQpJTBjLwNc2lZj+DKdRrCM9VMZmrvPaLOr+p4HT4RcVZhgr?= =?utf-8?q?a/O2ceb83f73vdxynqnDg0KEOzLhmJJ460jgmxwlMAkgUfFPG9CT2JjQuJfcGlFXG?= =?utf-8?q?G8pF1MBOHn2OxDCh55F6/HmaO1U8ijPEhdY53GvyxGI9EuBuChhNt2eU/VyN8stT9?= =?utf-8?q?dqcCwyK0/l9vxsb6WHxLVT+MoQygMsxV3vf9Qgqkb3bMuxltXWrtrg63pink8xbWn?= =?utf-8?q?dVqwDEjX35ROhfwFDUss3/cOJ4MYdbC7EVSDKvdczPxIl+BceAzgUjpQjA4fRG6WD?= =?utf-8?q?OkvVo8h6C4qu9myu7tGOYdo9yZdeuJBvtJnjD0WNUaK8S4B1ObFeOeSmkDQbpstAc?= =?utf-8?q?LEalIkoZzGWOHx8eQbDvTAf91h7JI9e1eRFnukU5VBwxPwV8ZeBIDNJMLs6Jxae7X?= =?utf-8?q?yzi+KUQntV5hvlbPO9YL4Z7o6XhM/AqCZR95sekoI4fVUGDJuzWjW0Ay5wwzZ+dPu?= =?utf-8?q?EC1bPYrlCXh0BaihLVHE7gvQMG3W8d66qNb/UjAkNzL1CbAK3FihJZD71kVQNhc9m?= =?utf-8?q?8z3ixDcSv7FsZTTvYklCJE4hs6v1w896go4nx79FSwNYg2JbctsDwG1xQpoKa1gqh?= =?utf-8?q?X7N3EZ50ds+m8wzm397j8BtxzFTclcyGagq60tfny/S7xWOIcqotxmjTqpI2pHTqV?= =?utf-8?q?mQ0lyCPMadClLfgI837AIeXfnM7NVF3WqigZmv2Sz7yIaxKkonmfvRZaCxGiDyKWc?= =?utf-8?q?Ndo2+ivM4DG5AuuhVydxeZMl/DdSq6Z4C7/7RzIUIHRSVe5lbxgOXT3Ni+2xct3ya?= =?utf-8?q?Ys8UxZ6ENjeskHbhjO8GIqzpg9zND3zNRdMmb/QehOEmSnCZopfGr4ReWaabWApKO?= =?utf-8?q?wgpQlOfjDWsRbKBqXVjblIqseHBuT+Y0Jya5iMuHv2dWk4C/CLgDqnFZA5tk7BsPj?= =?utf-8?q?cINaC7a0ePLoKEu4Lc7WEPoGtGmewhc98+O6LYw4t5k5WnT/I/hl3FBKVC3iTZFcx?= =?utf-8?q?xWGhCcxs2s34c3Q9dHe3hMMr1m0qKYdXS09R6lsl5IePgJYC7QM3QkKOlzlIZUShz?= =?utf-8?q?wkycbF0L+4BC3VGqIpcSvw+EPwD6sScFUcWVKWM+WkwJkPoE6cl6oF4=3D?= MIME-Version: 1.0 X-OriginatorOrg: 80211.de X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR03MB3832.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f42ae0b-a476-4eb1-f4ac-08dbe1f0f65e X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2023 13:28:44.4604 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72175547-ec04-4fa6-8f9d-95719e86a428 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oOGR83a3dQypvd9ZKLVTlRZqrEfcH6VbO+LgTBwYSCW3JjqFGbKqITUTIUE17VUR X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB8926 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231110_052852_846780_3F23998E X-CRM114-Status: GOOD ( 13.10 ) X-Spam-Score: 0.0 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Rafal Your patches for our Dorin & Balin modules are good, many thanks. You can push the patches upstream. Best regards & have a nice weekend Catrinel Content analysis details: (0.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Hi Rafal Your patches for our Dorin & Balin modules are good, many thanks. You can push the patches upstream. Best regards & have a nice weekend Catrinel -----Original Message----- From: Rafał Miłecki Sent: Friday, 10 November 2023 11:25 To: openwrt-devel@lists.openwrt.org Cc: yangshiji66@outlook.com; Hauke Mehrtens ; Rafał Miłecki ; Ansuel Smith ; Catrinel Catrinescu ; Felix Fietkau Subject: [PATCH] ath79: use "fixed-layout" for Embedded Wireless devices From: Rafał Miłecki Those devices have Ethernet interfaces using base MAC address increased by 0x40 in the 3rd indexed byte (00:00:00:FF:00:00). To describe that we were using a custom (downstream) "mac-address-increment-byte" property. The same result can be achieved by using "mac-base" with a properly adjusted offset value (0x40 << 16). It may be not pretty but it should work without custom property or downstream kernel patch to support it. Cc: Ansuel Smith Cc: Catrinel Catrinescu Cc: Felix Fietkau Signed-off-by: Rafał Miłecki --- .../dts/ar9331_embeddedwireless_dorin.dts | 26 ++++++++-------- .../dts/ar9344_embeddedwireless_balin.dts | 30 ++++++++++--------- 2 files changed, 29 insertions(+), 27 deletions(-) diff --git a/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts b/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts index de6b709b5c..6286f203ef 100644 --- a/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts +++ b/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts @@ -85,6 +85,18 @@ label = "art"; reg = <0xff0000 0x010000>; read-only; + + nvmem-layout { + compatible = "fixed-layout"; + #address-cells = <1>; + #size-cells = <1>; + + macaddr_art_1002: macaddr@1002 { + compatible = "mac-base"; + reg = <0x1002 0x6>; + #nvmem-cell-cells = <1>; + }; + }; }; }; }; @@ -93,10 +105,8 @@ ð1 { status = "okay"; - nvmem-cells = <&macaddr_art_1002>; + nvmem-cells = <&macaddr_art_1002 0x400000>; nvmem-cell-names = "mac-address"; - mac-address-increment-byte = <3>; - mac-address-increment = <0x40>; }; &mdio1 { @@ -108,13 +118,3 @@ mtd-cal-data = <&art 0x1000>; }; - -&art { - compatible = "nvmem-cells"; - #address-cells = <1>; - #size-cells = <1>; - - macaddr_art_1002: macaddr@1002 { - reg = <0x1002 0x6>; - }; -}; diff --git a/target/linux/ath79/dts/ar9344_embeddedwireless_balin.dts b/target/linux/ath79/dts/ar9344_embeddedwireless_balin.dts index a84c273f86..de13865818 100644 --- a/target/linux/ath79/dts/ar9344_embeddedwireless_balin.dts +++ b/target/linux/ath79/dts/ar9344_embeddedwireless_balin.dts @@ -83,16 +83,20 @@ reg = <0xff0000 0x010000>; read-only; - compatible = "nvmem-cells"; - #address-cells = <1>; - #size-cells = <1>; - - calibration_art_1000: calibration_data@1000 { - reg = <0x1000 0x440>; - }; - - macaddr_art_1002: macaddr@1002 { - reg = <0x1002 0x6>; + nvmem-layout { + compatible = "fixed-layout"; + #address-cells = <1>; + #size-cells = <1>; + + calibration_art_1000: calibration_data@1000 { + reg = <0x1000 0x440>; + }; + + macaddr_art_1002: macaddr@1002 { + compatible = "mac-base"; + reg = <0x1002 0x6>; + #nvmem-cell-cells = <1>; + }; }; }; }; @@ -106,10 +110,8 @@ ð1 { status = "okay"; - nvmem-cells = <&macaddr_art_1002>; + nvmem-cells = <&macaddr_art_1002 0x400000>; nvmem-cell-names = "mac-address"; - mac-address-increment-byte = <3>; - mac-address-increment = <0x40>; gmac-config { device = <&gmac>; @@ -121,7 +123,7 @@ &wmac { status = "okay"; - nvmem-cells = <&macaddr_art_1002>, <&calibration_art_1000>; + nvmem-cells = <&macaddr_art_1002 0>, <&calibration_art_1000>; nvmem-cell-names = "mac-address", "calibration"; }; -- 2.35.3