From patchwork Mon Apr 1 04:28:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: e9hack X-Patchwork-Id: 1918400 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=sJrZUmaE; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=K7n4By/z; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V7J3J5rSnz1yY3 for ; Mon, 1 Apr 2024 15:30:34 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:From:MIME-Version:Date:Message-ID: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=k7bVFbKj20I1Nuw20wV6GAYg4JfoZbb1BzzEPq2iXjM=; b=sJrZUmaEhdkfsa mdtYmAvmxoZlyYGzr6a6jCLbUju1fRp1J0gL6+XT6qOIl+5GoPjR6vU9LmWknvPdaa0ItveC7333B aJkabWK57jVaoviXRaqKbsYt9KS79JURSo3hNpiEutbWdTOXeIYOJpqLrTIH1CmR3bxH/hkYClXox cFJSW1SXoWi9E3TlnBDQqGrkba0mKs53a3kKku5ekfLUFo3FDLoX+2Na3+XAOt4EY7XOAVjvrQHPd Ah0kQYb+R2xmElOPrK3ESnPb/ed5t8HnvImoeumpvcz7vrcgsKzW5m4eNodgsmCAb54YVbH5m4kwm W6JQrWO3blg3XYOdSgfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rr9Hr-00000006tGY-0whQ; Mon, 01 Apr 2024 04:28:47 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rr9Ho-00000006tG1-03yN for openwrt-devel@lists.openwrt.org; Mon, 01 Apr 2024 04:28:45 +0000 Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-515a81928a1so5841385e87.3 for ; Sun, 31 Mar 2024 21:28:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711945721; x=1712550521; darn=lists.openwrt.org; h=content-transfer-encoding:to:subject:from:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=mnuFpVQCcaasry0teVPMIoqHMwPQmzBprMdP0wrGGQ4=; b=K7n4By/z/NEoBcVuq5vsP9tLK1S9NnKAyyEQNQ2jUOJmcS85gsATucioOah1p1xmOX BpGYHdMRLNHz9eb/YkRA7arm+8LFifpn6YDK2fcBvHQ0wWpkdS5t5dJ1sTmHCXS2swuK J2JgtGHzOvRk6FlkHNxu7bqWucO85fHIPBNhuXa/YkkYdJ3iEYKWOUlP1GnU6JsY2EyO +2TJJm4vEHQ3GAfTMTIxX2gFMWyTiA9EslaSSvZMlkBCs0SBDONecKjaLMt3hHy4mDnQ B9AraMLv48GniH5+kUGWaTuetiVWSH87m0xpyqe2iiOcC/vbNVQxLDprEUrEg8rUuauf 08dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711945721; x=1712550521; h=content-transfer-encoding:to:subject:from:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=mnuFpVQCcaasry0teVPMIoqHMwPQmzBprMdP0wrGGQ4=; b=VC3Hjppqjg+ERSmVOwJqAA1MqC3714eY4FsLRCcRyd6o1dxwJKztGzOQagFm2bHqNF gScTylpViwFWWWDhC6n6eYvn6Xza0xBvZOFSlTC6Ukm1GnWVMHZjod3p+mbHq9BHJeyS wlNafIVLnKkisbeouU/LodZ6NEFE97Y4hACEMPjs5sihoKd8MN8axv0qbpdbz8DixDVK ma14PUQFxVD26HLrhdMkM3RHbeMIqM78gqrUt0kDzT+vdrVKDBgCaYwUPn1sCnwSxtbS 2QmhE3EpTvE2nqD1Go20LSDSQrIhfMluLQULY47bUdUehqG9pSSj76YyffGYiHFLOb4M fYfQ== X-Gm-Message-State: AOJu0YyKGy+sDS+Ky8I3vl19sPFPmQRXywt4SZAyBdklYlNbiKtcGE/F yHiP93ikuXcI/RtQnCcXeXEvoGIcvsq8nwjEl28/LkoDWh3GfXsSkqhYqlH6 X-Google-Smtp-Source: AGHT+IHY18mQSTkYFAVAA42Xp4h0Uqe5+dMxwJMYImwTVa4YWKTDQgX3wYtuRsiyzBP4PWdudaBcvA== X-Received: by 2002:a05:6512:714:b0:516:82c3:d7c0 with SMTP id b20-20020a056512071400b0051682c3d7c0mr3649935lfs.49.1711945721007; Sun, 31 Mar 2024 21:28:41 -0700 (PDT) Received: from localhost (p200300f6673d1dac21ab9af5336df6d3.dip0.t-ipconnect.de. [2003:f6:673d:1dac:21ab:9af5:336d:f6d3]) by smtp.gmail.com with ESMTPSA id h23-20020a0565123c9700b00515cc918069sm1154625lfv.150.2024.03.31.21.28.40 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 31 Mar 2024 21:28:40 -0700 (PDT) Message-ID: <65ece051-1d8e-4d36-958a-e560a93f5244@gmail.com> Date: Mon, 1 Apr 2024 06:28:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB, de-DE From: e9hack Subject: Definition for flash w25q128 is wrong To: openwrt-devel@lists.openwrt.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240331_212844_099033_1298B6F4 X-CRM114-Status: GOOD ( 10.73 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, I'm using a TP-LINK WDR3600 with a bigger flash. Since some time the router hangs in an endless boot loop. I see the following message: ... [ 0.402716] spi-nor spi0.0: BFPT parsing failed. Please consider using SPI_NOR_SKIP_SFDP when declaring the flash [ 0.413217] spi-nor: probe of spi0.0 failed with error -22 ... [ 0.926180] /dev/ro [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [e9hack(at)gmail.com] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:12f listed in] [list.dnswl.org] X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Hi, I'm using a TP-LINK WDR3600 with a bigger flash. Since some time the router hangs in an endless boot loop. I see the following message: ... [ 0.402716] spi-nor spi0.0: BFPT parsing failed. Please consider using SPI_NOR_SKIP_SFDP when declaring the flash [ 0.413217] spi-nor: probe of spi0.0 failed with error -22 ... [ 0.926180] /dev/root: Can't open blockdev [ 0.930427] VFS: Cannot open root device "(null)" or unknown-block(0,0): error -6 [ 0.938037] Please append a correct "root=" boot option; here are the available partitions: [ 0.946520] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0) [ 0.954914] Rebooting in 1 seconds.. It looks like the definition for the flash is wrong: With these changes, the flash will be detected properly. Regards, Hartmut --- a/drivers/mtd/spi-nor/winbond.c 2024-03-15 19:27:50.000000000 +0100 +++ b/drivers/mtd/spi-nor/winbond.c 2024-04-01 05:59:17.166780732 +0200 @@ -120,8 +120,8 @@ static const struct flash_info winbond_n NO_SFDP_FLAGS(SECT_4K) }, { "w25q80bl", INFO(0xef4014, 0, 64 * 1024, 16) NO_SFDP_FLAGS(SECT_4K) }, - { "w25q128", INFO(0xef4018, 0, 0, 0) - PARSE_SFDP + { "w25q128", INFO(0xef4018, 0, 64 * 1024, 256) + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) }, { "w25q256", INFO(0xef4019, 0, 64 * 1024, 512) NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)