From patchwork Thu Nov 7 11:23:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nils Hendrik Rottgardt X-Patchwork-Id: 2007969 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=L/WDspo1; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XkfvC0dyHz1xyj for ; Thu, 7 Nov 2024 22:27:51 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=outxlL6zTvBL3Y0FVuNbiN5/q4VfKE2yXrYjJANouO0=; b=L/WDspo1meURm5 hGN1VEReHUd512BcrW0allVr1VvfpskZNjey382/2z2oFs0d9poWGcp0BmDD5AyeyG0D+9UlNx6e6 UQIUo2k21M2nq9ZGrlfM0fpRg+1CNhp1+T3dhnH29b6WeP2peNquaMEG7Ph9lUCoiqsNg29lmmOxQ eIG0H9CLo2PyI0Rxrf873l+lyl/uZVeLnB/CrNu82jBtI817WZdcsnpRvJMf98OX3xJC3O7Vs6enJ cUSCA08ISZL2U/OALBbgIDJOI3JaKxDMDVCFIiKAU3zaUsREN0oByJjRdoqzcOXtROJ11juPdhAM5 +SrNfMXh4QRbSe9ush8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t90eO-00000006h3d-2Ct9; Thu, 07 Nov 2024 11:26:08 +0000 Received: from mail-smtp-out-02-pmx.wtnet.de ([84.46.103.118]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t90eF-00000006gzZ-19Z9 for openwrt-devel@lists.openwrt.org; Thu, 07 Nov 2024 11:26:01 +0000 Received: from mail-cust-in-02-pmx.wtnet.de (mail-cust-in-02-pmx.wtnet.de [84.46.103.102]) by mail-smtp-out-02-pmx.wtnet.de (8.15.2/8.15.2/Debian-15~mysql) with ESMTP id 4A7BPfDP025837; Thu, 7 Nov 2024 12:25:41 +0100 X-WT-Originating-IP: 149.233.242.136 X-WT-Authenticated-As: ellerau@wtnet.de Received: from viserver1.ham.lan (149.233.242.136.dynamic-pppoe.dt.ipv4.wtnet.de [149.233.242.136]) (authenticated bits=0) by mail-cust-in-02-pmx.wtnet.de (8.15.2/8.15.2/Debian-15~mysql) with ESMTPA id 4A7BPfc0010520; Thu, 7 Nov 2024 12:25:41 +0100 Received: from Dell-7706.ham.lan (Dell-7706.ham.lan [192.168.178.135]) by viserver1.ham.lan (Postfix) with ESMTP id 8E0725F116; Thu, 7 Nov 2024 12:25:41 +0100 (CET) From: Nils Hendrik Rottgardt To: openwrt-devel@lists.openwrt.org Cc: Nils Hendrik Rottgardt , mail@david-bauer.net Subject: [PATCH usteer v3 7/9] ubus: Corrected transition request interface for disassociation timer Date: Thu, 7 Nov 2024 12:23:11 +0100 Message-Id: <20241107112313.507-8-n.rottgardt@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241107112313.507-1-n.rottgardt@gmail.com> References: <20241107112313.507-1-n.rottgardt@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241107_032559_739791_D24C1B15 X-CRM114-Status: UNSURE ( 8.61 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.4 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: - ubus: uint32_t has to be used instead of uint8_t Signed-off-by: Nils Hendrik Rottgardt --- ubus.c | 8 ++++---- usteer.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/ubus.c b/ubus.c index bcd0ef1..c72f8f7 100644 --- a/ubus.c +++ b/ubus.c @@ -673,7 +673,7 @@ usteer_ubus_disassoc_add_neighbors(struct sta_info *si) int usteer_ubus_bss_transition_request( [...] Content analysis details: (-0.4 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [84.46.103.118 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [84.46.103.118 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [84.46.103.118 listed in sa-accredit.habeas.com] 0.0 DKIM_ADSP_CUSTOM_MED No valid author signature, adsp_override is CUSTOM_MED -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [n.rottgardt(at)gmail.com] 1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received' headers 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [84.46.103.118 listed in bl.score.senderscore.com] 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 0.9 NML_ADSP_CUSTOM_MED ADSP custom_med hit, and not from a mailing list X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org - ubus: uint32_t has to be used instead of uint8_t Signed-off-by: Nils Hendrik Rottgardt --- ubus.c | 8 ++++---- usteer.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/ubus.c b/ubus.c index bcd0ef1..c72f8f7 100644 --- a/ubus.c +++ b/ubus.c @@ -673,7 +673,7 @@ usteer_ubus_disassoc_add_neighbors(struct sta_info *si) int usteer_ubus_bss_transition_request(struct sta_info *si, uint8_t dialog_token, bool disassoc_imminent, - uint8_t disassoc_timer, + uint32_t disassoc_timer, bool abridged, uint8_t validity_period, struct usteer_node *target_node) @@ -697,7 +697,7 @@ int usteer_ubus_bss_transition_request(struct sta_info *si, MSG(VERBOSE, "ROAMING requested for sta=" MAC_ADDR_FMT " without target\n", MAC_ADDR_DATA(si->sta->addr)); usteer_ubus_disassoc_add_neighbors(si); } else { - MSG(VERBOSE, "ROAMING requested for sta=" MAC_ADDR_FMT " to %s with disassociation timer %i\n", MAC_ADDR_DATA(si->sta->addr), usteer_node_name(target_node), disassoc_timer); + MSG(VERBOSE, "ROAMING requested for sta=" MAC_ADDR_FMT " to %s with disassociation timer %u\n", MAC_ADDR_DATA(si->sta->addr), usteer_node_name(target_node), disassoc_timer); usteer_ubus_disassoc_add_neighbor(si, target_node); } return ubus_invoke(ubus_ctx, ln->obj_id, "bss_transition_request", b.head, NULL, 0, 100); @@ -706,7 +706,7 @@ int usteer_ubus_bss_transition_request(struct sta_info *si, int usteer_ubus_band_steering_request(struct sta_info *si, uint8_t dialog_token, bool disassoc_imminent, - uint8_t disassoc_timer, + uint32_t disassoc_timer, bool abridged, uint8_t validity_period) { @@ -735,7 +735,7 @@ int usteer_ubus_band_steering_request(struct sta_info *si, } blobmsg_close_array(&b, c); if (sizeof(si->node) > 0) { - MSG(VERBOSE, "BAND STEERING requested for sta=" MAC_ADDR_FMT " with disassociation timer %i\n", MAC_ADDR_DATA(si->sta->addr), disassoc_timer); + MSG(VERBOSE, "BAND STEERING requested for sta=" MAC_ADDR_FMT " with disassociation timer %u\n", MAC_ADDR_DATA(si->sta->addr), disassoc_timer); return ubus_invoke(ubus_ctx, ln->obj_id, "bss_transition_request", b.head, NULL, 0, 100); } else MSG(VERBOSE, "BAND STEERING no targets found for sta=" MAC_ADDR_FMT "\n", MAC_ADDR_DATA(si->sta->addr)); diff --git a/usteer.h b/usteer.h index c9391bb..15e3911 100644 --- a/usteer.h +++ b/usteer.h @@ -347,13 +347,13 @@ int usteer_ubus_trigger_client_scan(struct sta_info *si); int usteer_ubus_band_steering_request(struct sta_info *si, uint8_t dialog_token, bool disassoc_imminent, - uint8_t disassoc_timer, + uint32_t disassoc_timer, bool abridged, uint8_t validity_period); int usteer_ubus_bss_transition_request(struct sta_info *si, uint8_t dialog_token, bool disassoc_imminent, - uint8_t disassoc_timer, + uint32_t disassoc_timer, bool abridged, uint8_t validity_period, struct usteer_node *target_node);