From patchwork Fri Jun 28 09:01:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qingfang Deng X-Patchwork-Id: 1953844 X-Patchwork-Delegate: gch981213@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=IPPK0sMx; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=LLwQyUqy; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4W9TwN4RqRz1yhT for ; Fri, 28 Jun 2024 19:02:28 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=vCPoV7cG0aSSnquUi/GGq7v4IxUTUyUJ27kBJnThfT4=; b=IPPK0sMxQ1iHSB UN1rnaj+mPM4vtzSh964G/UAuYPGO5cTkLeyhTPduvCvF659mwRnYvwRlLx4lyYxhCvdO4Xz8MNE6 HC8OpH++s1FWvHxYx6wyTjI8ddX6cnTTaRTdgDHEhc0uX4UH755vPxhdqjqZ9RnPVLy7793AN7DUu w2Q20aUn/IyQ8qFMNIYSRRjZ1VLdJ9Bxlmv4hlxMJR7hOa0ph7CFJkRlOd+14UCsrMpau+UVU6CLF 49iy5mkzGNGZwGWMQ4JI0etgefD6QzZz6tmiMXhlcu1pdRNPnjNKofHqxCf5/8XR8muaxZy5aiFZl wpFwhI/ellVacE8itmBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sN7Tk-0000000DAVY-3ljw; Fri, 28 Jun 2024 09:01:12 +0000 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sN7Th-0000000DAUt-38r0 for openwrt-devel@lists.openwrt.org; Fri, 28 Jun 2024 09:01:11 +0000 Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-706683e5249so259169b3a.2 for ; Fri, 28 Jun 2024 02:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719565269; x=1720170069; darn=lists.openwrt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YlMmTei5z2SLIcP+7pSWj3PuRp2Lp6EhApFsGTTtNfo=; b=LLwQyUqyZor4/mlsD3vI2uXPqsNpu180avIyVFlFT/XRu5X6EC1IyD7UrOxQ/AoMCR zx+MD4WA49AuIN7i8N9qaMYGsykitXMKnnqgDhpoKlA9IDIq6xrRpK5Ylqnz+Wx5rCuU 8w5vLfSSYOs7eGCKGIwSQRakw1HjjDlGiObRTzobQ+8yQMraCd/bUjRB5+zjDDraaxyO bhBXulZEvXJhE7TtbTCI+h7dagti+wI329eF3L5WhUW2c/YB9uaxn4rbSePd1nkUczy8 pggA8qfIZaUx/TjRvdCZLFroZT3DUiayLIh9S738m/rdnGzvp/cKruFvmTUv7S0evwib J96w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719565269; x=1720170069; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YlMmTei5z2SLIcP+7pSWj3PuRp2Lp6EhApFsGTTtNfo=; b=FDMUCNUQjyrj1IaSud7jmjZM4/b7oDeELRGqQtsE1bfmSsi2VHwmkCZiD3PJDLD6sn RC8A3tz/qSBEkKEkJ2FN9eV/F/+4VdH+GeGvU+XeFTT2dRr5EUnSDVOdlUxEzGORy1xJ /B2JeCz2vQdqKvok1F6uccWVoA36ABVNihSqFqwXmUSOSqBp8bEQnVTvmjXbh7EhNVRT EGaG84umFk2j4t1oK5RrJP9nOsSUJsSJ0KUiK08xw8wpF0rDTGZTj/6bPTPwNrUnmaqC /BU56rwbX0PXTg6faMan/sAjd0Jd5GkomY5GpJFagOxunEWHdlqp1XeZg7mgkn7jxapw +oyA== X-Gm-Message-State: AOJu0Yw1PF2UsOx4799egurT7rm0JDuRcxcf6Uj+WFx8DhW56HVODmNI HMn/ppNf0HkS4L0Q8wlXc/NC7ABnY4EKS17RLUCct7tZVWLq28MASpLCX47r X-Google-Smtp-Source: AGHT+IHQmvlQ5iqqaKmKVsAeSTUEY+6sk2ghtpAmIH3oRAnApfJ/QqxIzYdiVXiWQPLxWBeLeybhSg== X-Received: by 2002:aa7:8d02:0:b0:706:62d9:a4f1 with SMTP id d2e1a72fcca58-706746b5ddemr14964879b3a.31.1719565268316; Fri, 28 Jun 2024 02:01:08 -0700 (PDT) Received: from gmail.com ([2a09:bac5:80c9:183c::26a:88]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-72c69b53bf2sm782738a12.2.2024.06.28.02.01.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jun 2024 02:01:07 -0700 (PDT) From: Qingfang Deng To: openwrt-devel@lists.openwrt.org Cc: Qingfang Deng Subject: [PATCH] mediatek: fit: fix use of uninitialized variable Date: Fri, 28 Jun 2024 17:01:00 +0800 Message-Id: <20240628090100.3303-1-dqfext@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240628_020109_816746_AD8DE887 X-CRM114-Status: GOOD ( 11.64 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Qingfang Deng When building the kernel with -Wmaybe-uninitialized, GCC reports this warning: block/partitions/fit.c: In function 'parse_fit_partitions': block/partitions/fit.c:164:3: warning: 'images' may be used uninitialized in this function [-Wmaybe-uninitialized] 164 | printk(KERN_ERR "FI [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:429 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [dqfext(at)gmail.com] X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org From: Qingfang Deng When building the kernel with -Wmaybe-uninitialized, GCC reports this warning: block/partitions/fit.c: In function 'parse_fit_partitions': block/partitions/fit.c:164:3: warning: 'images' may be used uninitialized in this function [-Wmaybe-uninitialized] 164 | printk(KERN_ERR "FIT: Cannot find %s node: %d\n", FIT_CONFS_PATH, images); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ It appears to be a copy paste error. It's the "config" variable that is supposed to be printed. Fixes: e6aac8d98f56 ("image: add support for building FIT image with filesystem") Signed-off-by: Qingfang Deng --- target/linux/mediatek/files/block/partitions/fit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/mediatek/files/block/partitions/fit.c b/target/linux/mediatek/files/block/partitions/fit.c index 463cd4e9ab..01b0f42c7c 100644 --- a/target/linux/mediatek/files/block/partitions/fit.c +++ b/target/linux/mediatek/files/block/partitions/fit.c @@ -161,7 +161,7 @@ int parse_fit_partitions(struct parsed_partitions *state, u64 fit_start_sector, config = fdt_path_offset(fit, FIT_CONFS_PATH); if (config < 0) { - printk(KERN_ERR "FIT: Cannot find %s node: %d\n", FIT_CONFS_PATH, images); + printk(KERN_ERR "FIT: Cannot find %s node: %d\n", FIT_CONFS_PATH, config); ret = -ENOENT; goto ret_out; }