Message ID | 20240223061839.21956-1-zajec5@gmail.com |
---|---|
State | Accepted |
Delegated to: | Rafał Miłecki |
Headers | show
Return-Path: <openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Dm7ByY65; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=nIpOAIWS; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Th0NF4SZJz23d2 for <incoming@patchwork.ozlabs.org>; Fri, 23 Feb 2024 17:24:29 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=8sE/1drS0Q51BMjJJwyokHiX9Cxh4GcRGvsJTiydek4=; b=Dm7ByY65Vp0ULl QPYAWKQdLlEAfEnvzNs0DZh2WCeSBaaGRgryvWklbi3j/rEX5A1EPKHt7/5QtJcUz5R0Pk+Ig1Jkv YSE6cMOpi+3PttAGWwH5EhnDmOb03DVqG9tREFqFVFDIgdSlCiDZoFTbErNb2s2uZEMgJnbEnExnx WB+cj+nGt4pU6yfZACPAA3eQEbeTYtPQXBBjneR/zXTdLPK70JCWA/ZWHNuSsP0WYNmr7rrWJzTY6 dyRWwOtWpiV24lOiwHp6qTPcsyKjgDt/Nv6WGRAbFjhVRStcdbzDUASSnRGWQ8EwLPL5e0MSmb5VW COEk8oz7qUzX05xGdhGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdOuJ-000000087Ja-0qdZ; Fri, 23 Feb 2024 06:19:42 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdOta-000000087Fw-0ESZ for openwrt-devel@lists.openwrt.org; Fri, 23 Feb 2024 06:18:58 +0000 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-512b13bf764so753998e87.0 for <openwrt-devel@lists.openwrt.org>; Thu, 22 Feb 2024 22:18:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708669126; x=1709273926; darn=lists.openwrt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KEt6zMNyiyv/CskD7+INM5RgiJKWt1uIkqJLIqgfZBc=; b=nIpOAIWSka6Iy1j8kmUO6Le1mfZDKQO6/SwvgZYMLUMpHDNgnh94WkuhKLosUCqvt8 4sCZEsUvHMu1ue8ZneOAAn4p9cIg2hndK/zkN9fB3+HxFoqA5wuKD2u8hKs6UPA/d7IH GV2BgEW4u3LUigujQRxtqE+oyarjNFKe2N+YTJP41oINJLrU6za4rN58cJ1zPc1AoET2 dSVQE1DKMdZ4jZpnAnyRctOY4FJZ8C1h0EO9IufgKzswLEYI1K3DT0fpPI8TMYiJjCu1 0/EOz0JBCI/HxZp6/ecgZ8iaoIBqGab/hElcFvVsYUZOEgy7SZSRPPBtL/tN11blIWAo P+aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708669126; x=1709273926; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KEt6zMNyiyv/CskD7+INM5RgiJKWt1uIkqJLIqgfZBc=; b=wMKRqD2yS++9CHjt1P0BxjgSAfV5eA8Inxd7DqA1cGTlu/YO9GN+j1Z5u4tq79smj3 o1vNqj40NoeXwrjkQFODp5G91EQfdwq5b5QAvSEyPjBdcW7J9hxygTjQc3uziX9yvmnI si984aIFXzlkQizVyw6ZIbixiFFcpa+PmzxtLkFnneObZQ57TmrdNsEYZ/oLEkgqiika RsA51DhFKlPYdBCWuN885FoV8xdodYHceZutv8Ak07SMpxjExlUcnhXy4TSZHJj44afi saEhbjzyrZbAdd0QDL7njOytbCRK/wDvaLFgwAHhe+BBO/GQcOe2F2c23KrQ0H4P45xY 9UiA== X-Gm-Message-State: AOJu0YywWOnpXcIUfBmdGXLiLnfWU1PyzWpa4z1uUf+NG1AZxBKFY5VJ 7pEgDIRDR/TWZEu74hdHcZyU0Xx/tMuXBqRaDx2fjWuqE3+IU9uEF+XCYDYh X-Google-Smtp-Source: AGHT+IHuhaMORvflXOP/Fd95d25wwLscdJEXiBByDZb83RRIZk63lRnozPjCaNSLEPzd5sT/2bjE1Q== X-Received: by 2002:a05:6512:902:b0:512:b318:c1fd with SMTP id e2-20020a056512090200b00512b318c1fdmr701558lft.54.1708669125522; Thu, 22 Feb 2024 22:18:45 -0800 (PST) Received: from localhost.lan (031011218106.poznan.vectranet.pl. [31.11.218.106]) by smtp.gmail.com with ESMTPSA id gs8-20020a1709072d0800b00a3dab486a19sm6522201ejc.118.2024.02.22.22.18.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 22:18:44 -0800 (PST) From: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com> To: openwrt-devel@lists.openwrt.org Cc: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl> Subject: [PATCH firmware-utils 1/4] srec2bin: drop unused "dum" variable Date: Fri, 23 Feb 2024 07:18:36 +0100 Message-Id: <20240223061839.21956-1-zajec5@gmail.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240222_221854_232623_211BEA8C X-CRM114-Status: UNSURE ( 7.95 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.0 (/) X-Spam-Report: =?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?= =?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?= =?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?= =?unknown-8bit?q?ginal?= =?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?= =?unknown-8bit?q?bel?= =?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?= =?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_preview=3A__From=3A_Rafa=C5=82_Mi=C5=82ecki_This_f?= =?unknown-8bit?q?ixes=3A_src/srec2bin=2Ec=3A_In_function?= =?unknown-8bit?b?IOKAmGNoZWNrc3Vt4oCZOiBzcmMvc3JlYzJiaW4uYzoyOTc6Nzogd2Fy?= =?unknown-8bit?b?bmluZzogdmFyaWFibGUg4oCYZHVt4oCZIHNldCBidXQ=?= =?unknown-8bit?q?_not_used_=5B-Wunused-but-set-variable=5D_int_dum=3B_=5E=7E?= =?unknown-8bit?q?=7E_Signed-off-by=3A_Rafa=C5=82_Mi=C5=82ecki?= =?unknown-8bit?q?_---_src/srec2bin=2Ec_=7C_3_---_1_file_changed=2C_3_deletio?= =?unknown-8bit?q?ns=28-=29_?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_analysis_details=3A___=280=2E0_points=2C_5=2E0_req?= =?unknown-8bit?q?uired=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_pts_rule_name______________description?= =?unknown-8bit?q?_----_----------------------_------------------------------?= =?unknown-8bit?q?--------------------?= =?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?= =?unknown-8bit?q?ish_an_SPF_Record?= =?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?= =?unknown-8bit?q?record?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FAU__________Message_has_a_valid_DKIM?= =?unknown-8bit?q?_or_DK_signature_from_author=27s?= =?unknown-8bit?q?_domain?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?= =?unknown-8bit?q?alid_DKIM_or_DK_signature?= =?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?= =?unknown-8bit?q?gnature=2C_not_necessarily_valid?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FEF__________Message_has_a_valid_DKIM?= =?unknown-8bit?q?_or_DK_signature_from?= =?unknown-8bit?q?_envelope-from_domain?= =?unknown-8bit?q?_0=2E0_FREEMAIL=5FFROM__________Sender_email_is_commonly_ab?= =?unknown-8bit?q?used_enduser_mail_provider?= =?unknown-8bit?q?_=5Bzajec5=28at=29gmail=2Ecom=5D?= =?unknown-8bit?q?_0=2E2_FREEMAIL=5FENVFROM=5FEND=5FDIGIT_Envelope-from_freem?= =?unknown-8bit?q?ail_username_ends_in?= =?unknown-8bit?q?_digit?= =?unknown-8bit?q?_=5Bzajec5=28at=29gmail=2Ecom=5D?= =?unknown-8bit?q?_-0=2E0_RCVD=5FIN=5FDNSWL=5FNONE_____RBL=3A_Sender_listed_a?= =?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C_no?= =?unknown-8bit?q?_trust?= =?unknown-8bit?b?IFsyYTAwOjE0NTA6NDg2NDoyMDowOjA6MDoxMjkgbGlzdGVkIGluXQ==?= =?unknown-8bit?b?IFtsaXN0LmRuc3dsLm9yZ10=?= =?unknown-8bit?q?_-0=2E0_T=5FSCC=5FBODY=5FTEXT=5FLINE___No_description_avail?= =?unknown-8bit?q?able=2E?= X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List <openwrt-devel.lists.openwrt.org> List-Unsubscribe: <https://lists.openwrt.org/mailman/options/openwrt-devel>, <mailto:openwrt-devel-request@lists.openwrt.org?subject=unsubscribe> List-Archive: <http://lists.openwrt.org/pipermail/openwrt-devel/> List-Post: <mailto:openwrt-devel@lists.openwrt.org> List-Help: <mailto:openwrt-devel-request@lists.openwrt.org?subject=help> List-Subscribe: <https://lists.openwrt.org/mailman/listinfo/openwrt-devel>, <mailto:openwrt-devel-request@lists.openwrt.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "openwrt-devel" <openwrt-devel-bounces@lists.openwrt.org> Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org |
Series |
[firmware-utils,1/4] srec2bin: drop unused "dum" variable
|
expand
|
diff --git a/src/srec2bin.c b/src/srec2bin.c index ad4222d..9a88909 100644 --- a/src/srec2bin.c +++ b/src/srec2bin.c @@ -294,7 +294,6 @@ int checksum(char *cp,int count) { char *scp; int cksum; - int dum; scp=cp; while(*scp) @@ -309,8 +308,6 @@ int checksum(char *cp,int count) while(count) { cksum += gh(scp,2); - if (count == 2) - dum = ~cksum; scp += 2; count--; }