From patchwork Thu May 18 09:19:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Bauer X-Patchwork-Id: 1783086 X-Patchwork-Delegate: mail@david-bauer.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=BNbxMiug; dkim=fail reason="key not found in DNS" header.d=david-bauer.net header.i=@david-bauer.net header.a=rsa-sha256 header.s=uberspace header.b=qdQujdt5; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QMPdw5h2Yz20dg for ; Thu, 18 May 2023 19:23:00 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=pb+9qcyHdCPseKi55oLDTbHbFCFXGNYAwZHNBenz3HM=; b=BNbxMiugR2Zl3K T6wkdPFs1Oy1e1gD9xm4EMrV/WIoJxGelnXZDpfuxtrAPhRCZy1nbs4ehRmFgBxu5TWeCH8lLjNif gTBTBLbaWUNxE5aWnTnQlO8MOal82f2xBbL6Khz2OBZ8S+Jgh4yUMuofhuxBRczip2ZfD4g903tsA etjR2BJq0ecf7H7FJExvm0LNdwV9g6IOLT6LWy/P8+aiuOfL4WOKEAGNJlu25edj1FG3+BNL8bc13 RHNaHM/hslInIrgFNVyRhsRMq5gVyPSmHDYZopwJLoGzfyoY+b2hQObKbU0K0m7shOFtrEQ56wUGD 98qDXZWK+ntZ7rzYvYhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pzZnW-00CRP2-0G; Thu, 18 May 2023 09:19:46 +0000 Received: from perseus.uberspace.de ([95.143.172.134]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pzZnM-00CRME-1l for openwrt-devel@lists.openwrt.org; Thu, 18 May 2023 09:19:40 +0000 Received: (qmail 19618 invoked by uid 988); 18 May 2023 09:19:21 -0000 Authentication-Results: perseus.uberspace.de; auth=pass (plain) From: David Bauer To: openwrt-devel@lists.openwrt.org Subject: [PATCH] mac80211: always use mac80211 loss detection Date: Thu, 18 May 2023 11:19:12 +0200 Message-Id: <20230518091912.181090-1-mail@david-bauer.net> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Rspamd-Bar: - X-Rspamd-Report: R_MISSING_CHARSET(0.5) MIME_GOOD(-0.1) MID_CONTAINS_FROM(1) BAYES_HAM(-3) X-Rspamd-Score: -1.6 Received: from unknown (HELO unkown) (::1) by perseus.uberspace.de (Haraka/3.0.1) with ESMTPSA; Thu, 18 May 2023 11:19:20 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=david-bauer.net; s=uberspace; h=from; bh=Ke4vtrk28VZWHZYrlxJ9tHaJfHnvVq1SYZcCbwyieB4=; b=qdQujdt5LkpNP0vs3+XJPVdDYDOMLt5RsJE2X4CZQW7TibLPGdGlhSJdQVx8vl87dimt7qZVT+ ria2I7bMNEeTcPZWtQFxPqTYrz1glZ43nznQjinU4pAAphncnC9HF/Zz0WxhQLfEQ9eMA21Rws+x DU0XYlQXVqYwvYhgUBSWM+Sf0NwKjqXxxLfVn4rkr8LzC1f5r8JUgX5W8EIY5gP21hI2eU5jDDBb T15cWQ+sD/yi6Hw2nvqJeoGRV9SJszxE0UNXOxDmhag6UK8g95jpPVltRWTQh6IoY1C4WqScQCME KE65bSZUEO6sQCeZUi90VKPTFNGjNIpuvBU5ta6Lq+fU1CG/GgXvao2oODfVJPXjo0/vM7dy/VkK W42dHlLumH7I3RMvNYJYtSjKX/xVdXG6Lw7pKCbrsnrGnvo4XNBLHjdqb5gSJkOU8p1UrV/yP9MM Ldlbq1qjI6tZCTR6gHW2BAdghUm6WJn4eQ+vuM9uEhNsdSnA0A7LFlDqJ3mvJ+pT12RtFNYCo3vP qYT1Dmcqo5qUxIvaKy71flIfJAXTRpGjQNdAlJyEEcDaITBjI4jgGL7T9XWJuszKDEarJSLch3/C 4/P8GVOdC/AVu1TGZ5X7duPOh1J9VLm0NECthBW8MQSrvm0oigTA0PToefP+O6AK8PcfsgodHt6C k= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230518_021937_450304_4533C8F9 X-CRM114-Status: GOOD ( 10.70 ) X-Spam-Score: -0.5 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: ath10k does not report excessive loss in case of broken block-ack sessions. The loss is communicated to the host-os, but ath10k does not trigger a low-ack events by itself. The mac80211 framework for loss detection however detects this circumstance well in case of ath10k. So use it regardless of ath10k's own loss detection mechanism. Content analysis details: (-0.5 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [95.143.172.134 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay 0.1 DKIM_INVALID DKIM or DK signature exists, but is not valid X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org ath10k does not report excessive loss in case of broken block-ack sessions. The loss is communicated to the host-os, but ath10k does not trigger a low-ack events by itself. The mac80211 framework for loss detection however detects this circumstance well in case of ath10k. So use it regardless of ath10k's own loss detection mechanism. Signed-off-by: David Bauer --- ...1-always-use-mac80211-loss-detection.patch | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 package/kernel/mac80211/patches/subsys/340-mac80211-always-use-mac80211-loss-detection.patch diff --git a/package/kernel/mac80211/patches/subsys/340-mac80211-always-use-mac80211-loss-detection.patch b/package/kernel/mac80211/patches/subsys/340-mac80211-always-use-mac80211-loss-detection.patch new file mode 100644 index 0000000000..1e3a41c302 --- /dev/null +++ b/package/kernel/mac80211/patches/subsys/340-mac80211-always-use-mac80211-loss-detection.patch @@ -0,0 +1,33 @@ +From cdf461888f900c3a149b10a04d72b4a590ecdec3 Mon Sep 17 00:00:00 2001 +From: David Bauer +Date: Tue, 16 May 2023 23:11:32 +0200 +Subject: [PATCH] mac80211: always use mac80211 loss detection + +ath10k does not report excessive loss in case of broken block-ack +sessions. The loss is communicated to the host-os, but ath10k does not +trigger a low-ack events by itself. + +The mac80211 framework for loss detection however detects this +circumstance well in case of ath10k. So use it regardless of ath10k's +own loss detection mechanism. + +Signed-off-by: David Bauer +--- + net/mac80211/status.c | 6 ------ + 1 file changed, 6 deletions(-) + +--- a/net/mac80211/status.c ++++ b/net/mac80211/status.c +@@ -794,12 +794,6 @@ static void ieee80211_lost_packet(struct + unsigned long pkt_time = STA_LOST_PKT_TIME; + unsigned int pkt_thr = STA_LOST_PKT_THRESHOLD; + +- /* If driver relies on its own algorithm for station kickout, skip +- * mac80211 packet loss mechanism. +- */ +- if (ieee80211_hw_check(&sta->local->hw, REPORTS_LOW_ACK)) +- return; +- + /* This packet was aggregated but doesn't carry status info */ + if ((info->flags & IEEE80211_TX_CTL_AMPDU) && + !(info->flags & IEEE80211_TX_STAT_AMPDU))