From patchwork Sun Nov 27 08:38:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leon Busch-George X-Patchwork-Id: 1709285 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=cjbSdkgI; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=georgemail.eu header.i=@georgemail.eu header.a=rsa-sha256 header.s=DKIM001 header.b=Y0qQd244; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NKhwT3wN2z23nt for ; Sun, 27 Nov 2022 19:44:06 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=NtE4gaoKOS9eq3+aDwIcoKA/aGPR6+wHQvtFBcB1UjQ=; b=cjbSdkgIccKf3d WX9InUtvZNJkNj9nQPuhKrrj1Q/1woAb4e+2e8tFsGkI1OUo7ayH4qASOOhumTiqJCCwI2UNdZdSr IP8uVnPQy0xAHnvUXLRfowSa6j5bSj0TP+3JoP0ZRIAbg6jGJTHu+W5/2colZR+Sdv6VhdEO15Tvo BD3KpKoYwW9+cc0gCqj2/Qfbn7SFPLz8eshgT/BAGDgH2crTHWkqMl7jGHqpchiOAgtbhJ9UYW1v/ mkh1PnAx2CYagkNcGP+RKbpOgQL8fmTgClWN1wYAtt31s0K3YJkNqDdJpY7Tp6KrFqLRFJmSzpuBB UtGHHyrEcBrYk2Kyvv/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozDBt-00AWdp-3n; Sun, 27 Nov 2022 08:39:09 +0000 Received: from smtp5.goneo.de ([2001:1640:5::8:30] helo=smtp052.goneo.de) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozDBp-00AWbs-4G for openwrt-devel@lists.openwrt.org; Sun, 27 Nov 2022 08:39:07 +0000 Received: from hub2.goneo.de (hub2.goneo.de [85.220.129.53]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by smtp5.goneo.de (Postfix) with ESMTPS id 3085E10A32CA; Sun, 27 Nov 2022 09:38:57 +0100 (CET) Received: from hub2.goneo.de (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by hub2.goneo.de (Postfix) with ESMTPS id 9125D10A32CC; Sun, 27 Nov 2022 09:38:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=georgemail.eu; s=DKIM001; t=1669538335; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=GUlcB9Wbjm8nunTi9e7JEcFU098dJlCVf5syrulufso=; b=Y0qQd2443ODdHeWfLERnTjXB2A2fnN5aLHugf6gVZf3W1uROTTidttpZYZoxvc7niCOx72 rnkHiPQeexoLaEy+t1HED5/etQo449h8D6WLYgJNiBWCzDlIB35xsO8yUgvZ8uSFD/tTqU dZUXp/KSH1lHccDhjh3vy87imf7F+QL3Mo53TQ93w/Y2p7uOPS1eqiikcTrFPjos7Gv0Q4 Aso9KajzUL6I90Epbe9Bu5dcsQNJcanv4gY2RVBuP+CcITOqZPoELNmmniz6/JuvPakP2e V1UGjlYJUWX8Lq1jIgO7f0pY0FCPTEXYFeN1yWn56oXetUHrN0My07HppUsqOQ== Received: from brot.fritz.box (unknown [IPv6:2a02:908:2a43:bc20:1364:8c68:fb9f:f881]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hub2.goneo.de (Postfix) with ESMTPSA id 5749710A3308; Sun, 27 Nov 2022 09:38:55 +0100 (CET) From: "Leon M. Busch-George" To: openwrt-devel@lists.openwrt.org Cc: "Leon M. Busch-George" Subject: [PATCH] fix uloop initialization Date: Sun, 27 Nov 2022 09:38:09 +0100 Message-Id: <20221127083809.29351-1-leon@georgemail.eu> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Rspamd-UID: a2c69f X-Rspamd-UID: 02d81b X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221127_003905_910287_23549186 X-CRM114-Status: UNSURE ( 9.05 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: uloop_init is already called in main. uloop_done is just missing. Signed-off-by: Leon M. Busch-George --- dev.c | 2 -- main.c | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) Content analysis details: (-0.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [2001:1640:5:0:0:0:8:30 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org uloop_init is already called in main. uloop_done is just missing. Signed-off-by: Leon M. Busch-George --- dev.c | 2 -- main.c | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dev.c b/dev.c index bd10207..9eb7209 100644 --- a/dev.c +++ b/dev.c @@ -353,8 +353,6 @@ int qmi_device_open(struct qmi_dev *qmi, const char *path) struct ustream *us = &qmi->sf.stream; int fd; - uloop_init(); - fd = open(path, O_RDWR | O_EXCL | O_NONBLOCK | O_NOCTTY); if (fd < 0) return -1; diff --git a/main.c b/main.c index aa4634c..e3ccf08 100644 --- a/main.c +++ b/main.c @@ -168,5 +168,7 @@ int main(int argc, char **argv) qmi_device_close(&dev); + uloop_done(); + return ret; }