From patchwork Fri Oct 14 21:06:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Hoffmann X-Patchwork-Id: 1690167 X-Patchwork-Delegate: sander@svanheule.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=CADmb+47; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=3e8.eu header.i=@3e8.eu header.a=rsa-sha256 header.s=mail20211217 header.b=UyiNUmtJ; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MpzgL2pzKz23jk for ; Sat, 15 Oct 2022 08:15:10 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eGA2Ij4G754SPQnjmJDs3R3pbhrjMoyTK4CWB3rBsnU=; b=CADmb+47fl18Nv xjD+L8jnxOuc58y+TdSdOatHd3Rb5O6lFO2YP024nU3wJzJ/6kXUZAaCnCyMNx9ajV1Jt0nxkRyel U56yjaimADEV5H+zerqntY6IyDthJmquM5pT+BvdPkdrtujvo+jedRAGCGWFyTqXvBiBEWavWtmkr x52tSPtGuGQmhMI232XSeKm0zMywWFOjwYYM8NQZz1a4j/cF1SVS/MFiq9iCMAi1bZmEuS3MfTmNy YO5CVjBfcjNFcWDLNpuRsoZUZ8QRk2UaGP9CqXcqUcLgHO1siLR2qXBOfxYbWJv9pRXzh+pW3x5ID uq5ULhPaV78UuMkDiUHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojRvB-00FvVJ-1F; Fri, 14 Oct 2022 21:08:45 +0000 Received: from srv4.3e8.eu ([193.25.101.238]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojRut-00FvSA-O2 for openwrt-devel@lists.openwrt.org; Fri, 14 Oct 2022 21:08:30 +0000 Received: from localhost.localdomain (p200300c6cf1a0ba001060ed8c12b2b70.dip0.t-ipconnect.de [IPv6:2003:c6:cf1a:ba0:106:ed8:c12b:2b70]) (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits)) (No client certificate requested) by srv4.3e8.eu (Postfix) with ESMTPSA id 065B160129; Fri, 14 Oct 2022 23:08:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=3e8.eu; s=mail20211217; t=1665781693; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i8TAMSjCJWEIiV1CyIQ18EC6JDliXCqlbwjmK898HBQ=; b=UyiNUmtJti+sEuRP0QBjnkpzwBDirR/wpPiZhOkegyqFiU01U63ZsmEIUZoekMVd3/KJvm f98XWMrnelXvJEe/Q5CMyHrXSg/QK1OVWdnkgiohgLTS2oG1EpdL56GSFck+Dq1/TVVVui biA44D+2O7k/l3y7cqD5VyENS33TmvPD8U4oS5qT4WsoefW2SoXh8YsPHhNN68Kmnpph1r BDMgvMimp0Bt8H9IBUrnETvyuJ5eu5fTWS7ZNFm5WjWHXiuB/zivSQ+V0Ao3F4dfpVZwAR wmh6AcfPnYwy5MqytvTXtE2TSps5s6J+NxeUJ8p/Izdy1sAD0vqPlf0R04Bc3Q== From: Jan Hoffmann To: openwrt-devel@lists.openwrt.org Cc: Sander Vanheule , Jan Hoffmann Subject: [PATCH 2/5] realtek: simplify log messages in rtl83xx_mdio_probe Date: Fri, 14 Oct 2022 23:06:15 +0200 Message-Id: <20221014210618.3012368-3-jan@3e8.eu> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221014210618.3012368-1-jan@3e8.eu> References: <20221014210618.3012368-1-jan@3e8.eu> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221014_140828_414554_63CFBE32 X-CRM114-Status: UNSURE ( 8.81 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This function currently prints three messages for every switch port at KERN_INFO level. This takes a considerable amount of time during bootup and can even trigger an external watchdog. Replace these log messages by a single one at KERN_DEBUG level. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org This function currently prints three messages for every switch port at KERN_INFO level. This takes a considerable amount of time during bootup and can even trigger an external watchdog. Replace these log messages by a single one at KERN_DEBUG level. Signed-off-by: Jan Hoffmann --- .../linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/common.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/common.c b/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/common.c index 2a60f61c9582..13e63a5f0c5d 100644 --- a/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/common.c +++ b/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/common.c @@ -323,7 +323,6 @@ static int __init rtl83xx_mdio_probe(struct rtl838x_switch_priv *priv) if (of_property_read_u32(dn, "reg", &pn)) continue; - pr_info("%s found port %d\n", __func__, pn); phy_node = of_parse_phandle(dn, "phy-handle", 0); if (!phy_node) { if (pn != priv->cpu_port) @@ -331,14 +330,13 @@ static int __init rtl83xx_mdio_probe(struct rtl838x_switch_priv *priv) continue; } - pr_info("%s port %d has phandle\n", __func__, pn); if (of_property_read_u32(phy_node, "sds", &priv->ports[pn].sds_num)) priv->ports[pn].sds_num = -1; else { pr_info("%s sds port %d is %d\n", __func__, pn, priv->ports[pn].sds_num); } - pr_info("%s port %d has SDS\n", __func__, priv->ports[pn].sds_num); + pr_debug("%s port %d has SDS %d\n", __func__, pn, priv->ports[pn].sds_num); if (of_get_phy_mode(dn, &interface)) interface = PHY_INTERFACE_MODE_NA;