| Message ID | 20221014210618.3012368-3-jan@3e8.eu |
|---|---|
| State | Changes Requested |
| Delegated to: | Sander Vanheule |
| Headers | show |
| Series | realtek: avoid blocking for too long | expand |
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software. Hello Jan! On Fri, 14 Oct 2022 23:06:15 +0200 Jan Hoffmann <jan@3e8.eu> wrote: > This function currently prints three messages for every switch port at > KERN_INFO level. This takes a considerable amount of time during bootup > and can even trigger an external watchdog. > > Replace these log messages by a single one at KERN_DEBUG level. > > Signed-off-by: Jan Hoffmann <jan@3e8.eu> > --- > .../linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/common.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/common.c b/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/common.c > index 2a60f61c9582..13e63a5f0c5d 100644 > --- a/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/common.c > +++ b/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/common.c > @@ -323,7 +323,6 @@ static int __init rtl83xx_mdio_probe(struct rtl838x_switch_priv *priv) > if (of_property_read_u32(dn, "reg", &pn)) > continue; > > - pr_info("%s found port %d\n", __func__, pn); > phy_node = of_parse_phandle(dn, "phy-handle", 0); > if (!phy_node) { > if (pn != priv->cpu_port) > @@ -331,14 +330,13 @@ static int __init rtl83xx_mdio_probe(struct rtl838x_switch_priv *priv) > continue; > } > > - pr_info("%s port %d has phandle\n", __func__, pn); > if (of_property_read_u32(phy_node, "sds", &priv->ports[pn].sds_num)) > priv->ports[pn].sds_num = -1; > else { > pr_info("%s sds port %d is %d\n", __func__, pn, > priv->ports[pn].sds_num); > } The else block should probably get removed with your patch, because it prints redundant information only. > - pr_info("%s port %d has SDS\n", __func__, priv->ports[pn].sds_num); > + pr_debug("%s port %d has SDS %d\n", __func__, pn, priv->ports[pn].sds_num); > > if (of_get_phy_mode(dn, &interface)) > interface = PHY_INTERFACE_MODE_NA; Best regards, Andreas
diff --git a/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/common.c b/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/common.c index 2a60f61c9582..13e63a5f0c5d 100644 --- a/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/common.c +++ b/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/common.c @@ -323,7 +323,6 @@ static int __init rtl83xx_mdio_probe(struct rtl838x_switch_priv *priv) if (of_property_read_u32(dn, "reg", &pn)) continue; - pr_info("%s found port %d\n", __func__, pn); phy_node = of_parse_phandle(dn, "phy-handle", 0); if (!phy_node) { if (pn != priv->cpu_port) @@ -331,14 +330,13 @@ static int __init rtl83xx_mdio_probe(struct rtl838x_switch_priv *priv) continue; } - pr_info("%s port %d has phandle\n", __func__, pn); if (of_property_read_u32(phy_node, "sds", &priv->ports[pn].sds_num)) priv->ports[pn].sds_num = -1; else { pr_info("%s sds port %d is %d\n", __func__, pn, priv->ports[pn].sds_num); } - pr_info("%s port %d has SDS\n", __func__, priv->ports[pn].sds_num); + pr_debug("%s port %d has SDS %d\n", __func__, pn, priv->ports[pn].sds_num); if (of_get_phy_mode(dn, &interface)) interface = PHY_INTERFACE_MODE_NA;
This function currently prints three messages for every switch port at KERN_INFO level. This takes a considerable amount of time during bootup and can even trigger an external watchdog. Replace these log messages by a single one at KERN_DEBUG level. Signed-off-by: Jan Hoffmann <jan@3e8.eu> --- .../linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/common.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)