diff mbox series

fix for sourcing target image config a when target is being replaced

Message ID 20221012082516.2041-1-prasunmaiti87@gmail.com
State Not Applicable
Delegated to: Petr Štetiar
Headers show
Series fix for sourcing target image config a when target is being replaced | expand

Commit Message

Prasun Maiti Oct. 12, 2022, 8:25 a.m. UTC 
From: Prasun Maiti <pmaiti@maxlinear.com>

Sourcing of image/Config.in will not happen 
When a target is installed from target/linux/feeds/ 

Signed-off-by: Prasun Maiti <pmaiti@maxlinear.com>
---
 config/Config-images.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Christian Marangi Nov. 10, 2022, 2:14 p.m. UTC | #1 
On Wed, Oct 12, 2022 at 01:55:16PM +0530, Prasun Maiti wrote:
> From: Prasun Maiti <pmaiti@maxlinear.com>
> 
> Sourcing of image/Config.in will not happen 
> When a target is installed from target/linux/feeds/ 
>

Hi, this patch got reverted after it was merged in master as it cause
wide buildbot compilation failure. This was an RFC and wasn't tested or
we are missing other patch to make this work?

It would be good if you can resubmit this in a v2 or with a RESEND tag.

> Signed-off-by: Prasun Maiti <pmaiti@maxlinear.com>
> ---
>  config/Config-images.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/config/Config-images.in b/config/Config-images.in
> index dcd7575..832e672 100644
> --- a/config/Config-images.in
> +++ b/config/Config-images.in
> @@ -286,6 +286,7 @@ menu "Target Images"
>  	comment "Image Options"
>  
>  	source "target/linux/*/image/Config.in"
> +	source "target/linux/feeds/*/image/Config.in"
>  
>  	config TARGET_KERNEL_PARTSIZE
>  		int "Kernel partition size (in MiB)"
> -- 
> 2.17.1
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Prasun Maiti Nov. 14, 2022, 4:35 p.m. UTC | #2 
Hi Christian,
I think there is no target installed under feeds/ by default. right?
I will resend the patch.

Thanks,
Prasun

On Thu, Nov 10, 2022 at 7:44 PM Christian Marangi <ansuelsmth@gmail.com> wrote:
>
> On Wed, Oct 12, 2022 at 01:55:16PM +0530, Prasun Maiti wrote:
> > From: Prasun Maiti <pmaiti@maxlinear.com>
> >
> > Sourcing of image/Config.in will not happen
> > When a target is installed from target/linux/feeds/
> >
>
> Hi, this patch got reverted after it was merged in master as it cause
> wide buildbot compilation failure. This was an RFC and wasn't tested or
> we are missing other patch to make this work?
>
> It would be good if you can resubmit this in a v2 or with a RESEND tag.
>
> > Signed-off-by: Prasun Maiti <pmaiti@maxlinear.com>
> > ---
> >  config/Config-images.in | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/config/Config-images.in b/config/Config-images.in
> > index dcd7575..832e672 100644
> > --- a/config/Config-images.in
> > +++ b/config/Config-images.in
> > @@ -286,6 +286,7 @@ menu "Target Images"
> >       comment "Image Options"
> >
> >       source "target/linux/*/image/Config.in"
> > +     source "target/linux/feeds/*/image/Config.in"
> >
> >       config TARGET_KERNEL_PARTSIZE
> >               int "Kernel partition size (in MiB)"
> > --
> > 2.17.1
> >
> >
> > _______________________________________________
> > openwrt-devel mailing list
> > openwrt-devel@lists.openwrt.org
> > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
>
> --
>         Ansuel
diff mbox series

Patch

diff --git a/config/Config-images.in b/config/Config-images.in
index dcd7575..832e672 100644
--- a/config/Config-images.in
+++ b/config/Config-images.in
@@ -286,6 +286,7 @@  menu "Target Images"
 	comment "Image Options"
 
 	source "target/linux/*/image/Config.in"
+	source "target/linux/feeds/*/image/Config.in"
 
 	config TARGET_KERNEL_PARTSIZE
 		int "Kernel partition size (in MiB)"