| Message ID | 20220929101032.1672697-1-sven@narfation.org |
|---|---|
| State | Accepted |
| Delegated to: | Hauke Mehrtens |
| Headers | show |
| Series | uboot-envtools: Fix format of autogenerated sectors | expand |
On 29/9/22 12:10, Sven Eckelmann wrote: > The sector number must be stored in hex. Otherwise, the number (like 16) > will be parsed as hex and any write to the partition will end up with an > error like: > > MTD erase error on /dev/mtd5: Invalid argument > > Fixes: 9adfeccd8415 ("uboot-envtools: Add support for IPQ806x AP148 and DB149") > Fixes: 54b275c8ed3a ("ipq40xx: add target") > Signed-off-by: Sven Eckelmann <sven@narfation.org> > --- > package/boot/uboot-envtools/files/ipq40xx | 1 + > package/boot/uboot-envtools/files/ipq806x | 1 + > 2 files changed, 2 insertions(+) Reviewed-by: Philippe Mathieu-Daudé <philmd@fungible.com>
diff --git a/package/boot/uboot-envtools/files/ipq40xx b/package/boot/uboot-envtools/files/ipq40xx index e45e26dcc7..823a33ca1b 100644 --- a/package/boot/uboot-envtools/files/ipq40xx +++ b/package/boot/uboot-envtools/files/ipq40xx @@ -26,6 +26,7 @@ ubootenv_mtdinfo () { fi sectors=$(( $ubootenv_size / $mtd_erase )) + sectors=$(printf "0x%x" $sectors ) echo /dev/$mtd_dev 0x0 $ubootenv_size $mtd_erase $sectors } diff --git a/package/boot/uboot-envtools/files/ipq806x b/package/boot/uboot-envtools/files/ipq806x index a8285d1452..77dfefbcd8 100644 --- a/package/boot/uboot-envtools/files/ipq806x +++ b/package/boot/uboot-envtools/files/ipq806x @@ -26,6 +26,7 @@ ubootenv_mtdinfo () { fi sectors=$(( $ubootenv_size / $mtd_erase )) + sectors=$(printf "0x%x" $sectors ) echo /dev/$mtd_dev 0x0 $ubootenv_size $mtd_erase $sectors }
The sector number must be stored in hex. Otherwise, the number (like 16) will be parsed as hex and any write to the partition will end up with an error like: MTD erase error on /dev/mtd5: Invalid argument Fixes: 9adfeccd8415 ("uboot-envtools: Add support for IPQ806x AP148 and DB149") Fixes: 54b275c8ed3a ("ipq40xx: add target") Signed-off-by: Sven Eckelmann <sven@narfation.org> --- package/boot/uboot-envtools/files/ipq40xx | 1 + package/boot/uboot-envtools/files/ipq806x | 1 + 2 files changed, 2 insertions(+)