| Message ID | 20220823143328.9456-1-reiver@improbability.net |
|---|---|
| State | New |
| Headers | show |
| Series | interface-ip: stop setting prefix indicator flag when IPv6 prefix lifetime changes | expand |
On Tue, 2022-08-23 at 15:33 +0100, Alan Swanson wrote: > Since hnetd has now been dead for years we can safely revert commit > a03216660797173fbe67866f75564e3fec9c1e8d which was causing > unnecessarily frequent interface triggers and service reloads > for IPv6 prefix lifetime changes. This is, of course, for netifd from a git send-email which doesn't need a "netifd" tautology included in the commit log...
diff --git a/interface-ip.c b/interface-ip.c index ab4a5cf..fd2b2ab 100644 --- a/interface-ip.c +++ b/interface-ip.c @@ -1302,10 +1302,6 @@ interface_update_prefix(struct vlist_tree *tree, list_for_each_entry(c, &prefix_new->assignments, head) if ((iface = vlist_find(&interfaces, c->name, iface, node))) interface_set_prefix_address(c, prefix_new, iface, new_valid); - - if (prefix_new->preferred_until != prefix_old->preferred_until || - prefix_new->valid_until != prefix_old->valid_until) - ip->iface->updated |= IUF_PREFIX; } else if (node_new) { /* Set null-route to avoid routing loops */ system_add_route(NULL, &route);
Since hnetd has now been dead for years we can safely revert commit a03216660797173fbe67866f75564e3fec9c1e8d which was causing unnecessarily frequent interface triggers and service reloads for IPv6 prefix lifetime changes. Fixes: FS#713 https://github.com/openwrt/openwrt/issues/5723 Fixes: FS#1492 https://github.com/openwrt/openwrt/issues/6454 Signed-off-by: Alan Swanson <reiver@improbability.net> --- interface-ip.c | 4 ---- 1 file changed, 4 deletions(-)