From patchwork Sun Mar 13 19:47:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hauke Mehrtens X-Patchwork-Id: 1604846 X-Patchwork-Delegate: hauke@hauke-m.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=F+poFI8p; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=hauke-m.de header.i=@hauke-m.de header.a=rsa-sha256 header.s=MBO0001 header.b=kcq/z1QP; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KGqz82Yfpz9sGF for ; Mon, 14 Mar 2022 06:50:43 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=122842dyqZTC3TcBHACGfyS3Evv/GWDoujfvZuF0kxA=; b=F+poFI8pcsxBu8 jEViO5JLpByl+Soo+r3kX/BKdSQJfcZ66pXite4Ac7qpf5tYwApGJbpqlNxlRZRpJo4PvRRVGgcrd JR71D6QCXtZxiB9Hre5//Jk1KRF6VfCIKsi4Czt5KNweHuH+HaPoXGjIq87FyfvILJTCMC/MJm/QO u2cTpyfQkBlLToaw6eDSYKBivt/Ii0kaBSfNVXgM0F+1t8UfMFN+7P/WaXGKB8h/QczHTk+V/J5f1 QGm6WO9iNFG4rkvD2QS8VHC/zMWlE49p/jUiLklwJ9dlCa0JhAqLZADnBYGfs/6gGXccR0cWRIz12 foUYXF3FBDBsKv9tnzfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nTUCP-003JnF-DB; Sun, 13 Mar 2022 19:48:17 +0000 Received: from mout-p-102.mailbox.org ([80.241.56.152]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nTUCL-003Jms-AZ for openwrt-devel@lists.openwrt.org; Sun, 13 Mar 2022 19:48:15 +0000 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4KGqw62PJdz9sS6; Sun, 13 Mar 2022 20:48:06 +0100 (CET) From: Hauke Mehrtens DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hauke-m.de; s=MBO0001; t=1647200884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=xCecB77zyqJT3JtWJd82bbqnyAoj9nmatpkU1T1Q90c=; b=kcq/z1QPNq8Zm2btyaF1zQ1GsviCPOwb9bm+j078pHU52PAhJJryMmUOrti/pl1i2gRSSh 7jFj3e6ahqVVTK/yVn/DgArVeGfWJ59Rpi74KBn3z7s84lDVUzU8S1YKrJICplVNBEwyUN 3be5ApDgzjI09r4dCaj0/EXJ1+VCmFTtk7ERDzhZNQg1Af9j9zLCXNWCQiAng6HHTrbZmB ya7K1HuYhoOHMpwpV+GlJ1CnosTsrz+/9AbfJi+rgbzU+m3afVCoT9UkO7L7feh/jbN5VK pf/mfzc1kiCYspVUefYvmWfGNhdAZh9lGTYtYBL75su9+PGztHcbaDaRu7uzmw== To: openwrt-devel@lists.openwrt.org Cc: git@birger-koblitz.de, Hauke Mehrtens Subject: [PATCH] realtek: Fix kernel dependencies on CONFIG_MDIO_SMBUS Date: Sun, 13 Mar 2022 20:47:48 +0100 Message-Id: <20220313194748.1705385-1-hauke@hauke-m.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220313_124813_687075_F647CC1C X-CRM114-Status: UNSURE ( 7.54 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: CONFIG_SFP depends on CONFIG_MDIO_SMBUS now and this depends on CONFIG_I2C_SMBUS. Activate the missing kernel compile options. This fixes the following warning: WARNING: unmet direct dependencies detected for MDIO_SMBUS Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y] && I2C_SMBUS [=n] Selected by [y]: - S [...] Content analysis details: (-0.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.241.56.152 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org CONFIG_SFP depends on CONFIG_MDIO_SMBUS now and this depends on CONFIG_I2C_SMBUS. Activate the missing kernel compile options. This fixes the following warning: WARNING: unmet direct dependencies detected for MDIO_SMBUS Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y] && I2C_SMBUS [=n] Selected by [y]: - SFP [=y] && NETDEVICES [=y] && PHYLIB [=y] && I2C [=y] && PHYLINK [=y] && (HWMON [=y] || HWMON [=y]=n) Fixes: 45053b507c66 ("realtek: Add support for SFP EEPROM-access over SMBus") Signed-off-by: Hauke Mehrtens Reported-by: Hauke Mehrtens Signed-off-by: Birger Koblitz --- target/linux/realtek/rtl838x/config-5.10 | 2 ++ target/linux/realtek/rtl839x/config-5.10 | 2 ++ 2 files changed, 4 insertions(+) diff --git a/target/linux/realtek/rtl838x/config-5.10 b/target/linux/realtek/rtl838x/config-5.10 index 8e27af95ba46..16964d94c967 100644 --- a/target/linux/realtek/rtl838x/config-5.10 +++ b/target/linux/realtek/rtl838x/config-5.10 @@ -90,6 +90,7 @@ CONFIG_I2C_GPIO=y CONFIG_I2C_MUX=y # CONFIG_I2C_RTL9300 is not set # CONFIG_I2C_MUX_RTL9300 is not set +CONFIG_I2C_SMBUS=y CONFIG_INITRAMFS_SOURCE="" CONFIG_IRQCHIP=y CONFIG_IRQ_DOMAIN=y @@ -107,6 +108,7 @@ CONFIG_MDIO_BUS=y CONFIG_MDIO_DEVICE=y CONFIG_MDIO_DEVRES=y CONFIG_MDIO_I2C=y +CONFIG_MDIO_SMBUS=y CONFIG_MEMFD_CREATE=y CONFIG_MFD_SYSCON=y CONFIG_MIGRATION=y diff --git a/target/linux/realtek/rtl839x/config-5.10 b/target/linux/realtek/rtl839x/config-5.10 index 5704b4265a3c..b3192d1866da 100644 --- a/target/linux/realtek/rtl839x/config-5.10 +++ b/target/linux/realtek/rtl839x/config-5.10 @@ -86,6 +86,7 @@ CONFIG_I2C_BOARDINFO=y CONFIG_I2C_GPIO=y # CONFIG_I2C_RTL9300 is not set # CONFIG_I2C_MUX_RTL9300 is not set +CONFIG_I2C_SMBUS=y CONFIG_INITRAMFS_SOURCE="" CONFIG_IRQCHIP=y CONFIG_IRQ_DOMAIN=y @@ -104,6 +105,7 @@ CONFIG_MDIO_BUS=y CONFIG_MDIO_DEVICE=y CONFIG_MDIO_DEVRES=y CONFIG_MDIO_I2C=y +CONFIG_MDIO_SMBUS=y CONFIG_MEMFD_CREATE=y CONFIG_MFD_SYSCON=y CONFIG_MIGRATION=y